Do not include invalid votes in listgovproposalvotes
#1722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shohamc1
requested review from
Bushstar,
Mixa84,
wafflespeanut,
prasannavl and
Jouzo
as code owners
Bushstar
approved these changes
Feb 1, 2023
|
Superseded by #1725 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind fix
What this PR does / why we need it:
Only masternodes that are active and have minted at least one block are allowed to vote.
getgovproposalwas filtering the valid votes from the total set of votes whereaslistgovproposalvoteswas not, which is the reason for the discrepancy in #1721.This is fixed by checking if a vote is valid on
listgovproposalvotesas well.Which issue(s) does this PR fixes?:
Fixes #1721