Remove positive amount on close vault #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bushstar
requested review from
Mixa84,
wafflespeanut,
prasannavl and
Jouzo
as code owners
prasannavl
reviewed
Jan 30, 2023
prasannavl
reviewed
Jan 30, 2023
Jouzo
previously approved these changes
Feb 6, 2023
Mixa84
previously approved these changes
Feb 6, 2023
prasannavl
approved these changes
Feb 7, 2023
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When closing a vault that the remaining balances is negated by the interest delete that remaining balance.