Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1197: prepare beta-10.4 release #1198

Merged
merged 15 commits into from
Jan 7, 2021
Merged

Conversation

cz4rs
Copy link
Contributor

@cz4rs cz4rs commented Dec 29, 2020

fixes #1197

@cz4rs cz4rs force-pushed the 1.0.0-beta.10.4-proposed-update branch from 4955c71 to 494fbe5 Compare December 29, 2020 15:54
@cz4rs cz4rs added the Release label Dec 29, 2020
@cz4rs cz4rs force-pushed the 1.0.0-beta.10.4-proposed-update branch from 494fbe5 to b9564cc Compare December 29, 2020 16:08
@PhilMiller
Copy link
Member

Tested successfully in EMPIRE with gcc. Nvidia and Intel are pending.

@PhilMiller
Copy link
Member

Intel tests pass. Testing on CUDA is slow.

@cz4rs cz4rs force-pushed the 1.0.0-beta.10.4-proposed-update branch from b9564cc to 19bf7f1 Compare December 29, 2020 19:05
@cz4rs cz4rs force-pushed the 1.0.0-beta.10.4-proposed-update branch from 19bf7f1 to 0bf2e7a Compare December 29, 2020 19:08
@cz4rs
Copy link
Contributor Author

cz4rs commented Dec 30, 2020

@PhilMiller
Codacy and Travis jobs are stuck, other tests pass fine. As with the other PR, I cannot merge it myself (no permissions for override + I think merging into 1.0.0 is restricted as well)

if everything is ok, can you please merge this? (I will create the tag afterwards)

@cz4rs
Copy link
Contributor Author

cz4rs commented Dec 30, 2020

Regarding the extended tests, I have added the build definitions, but it seems like they have not been triggered.

Honestly I don't know if there should be much investigation put into this, since extended tests are failing regularly on develop anyways (I believe this was discussed at the last DARMA weekly, but there's no solution so far)
Screenshot from 2020-12-30 15-51-33

@cz4rs
Copy link
Contributor Author

cz4rs commented Jan 5, 2021

note: #1098 has 2 PRs, but they were both done on 1098-enable-assertions-during-ci branch

@PhilMiller
Copy link
Member

This passes the full EMPIRE test suite in the Debug mode builds that unexpectedly failed. I'm re-running the test in other modes to not repeat my earlier mess.

@PhilMiller
Copy link
Member

PhilMiller commented Jan 6, 2021

Manual and automatic testing of Release mode EMPIRE builds also passes. I'm re-running Intel 19 tests as well

@PhilMiller
Copy link
Member

Intel 19 tests all pass as well. I think this is good to go.

@cz4rs
Copy link
Contributor Author

cz4rs commented Jan 6, 2021

Intel 19 tests all pass as well. I think this is good to go.

👍

@PhilMiller @lifflander
If the CMake conversation above can be resolved as a non-issue, please merge this PR (I cannot do this myself - this is targeting release branch + Codacy is stuck again). I will create a tag & release notes afterwards.

edit: I'm not even sure about Codacy, because it is displayed twice with different statuses for me
regarding Travis - I have no idea why it shows up (the configuration file was removed long time ago)
Screenshot from 2021-01-07 00-12-47

@lifflander
Copy link
Collaborator

lifflander commented Jan 7, 2021

I think Travis CI needs to be removed for merging on release. I've changed the requirements.

Copy link
Collaborator

@lifflander lifflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's merge.

@cz4rs cz4rs merged commit bba71c1 into 1.0.0 Jan 7, 2021
@cz4rs cz4rs mentioned this pull request Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants