-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 1.0.0 beta.10.3 proposed update into 1.0.0 #1187
Conversation
390e7ed
to
ee68ab5
Compare
ee68ab5
to
065bf8a
Compare
ToDo:
Skipped in this release (to avoid further delay): #1173 |
065bf8a
to
7290bec
Compare
…t to avoid ICE in Intel 19.x
|
Looks good so far. Let me know if you need any help from me. The reduce interface did change a lot on develop, but I think the changes Phil made should generally be applicable to 1.0.0. |
482efcc
to
866a3aa
Compare
866a3aa
to
beb8e72
Compare
pushed single commit from #908 to fix another Intel 19 issue (95ff3ea), it might be necessary to include complete solution ToDo:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look as expected, and EMPIRE tests pass.
Those tests were with GCC 7.2.0. I'm building and testing with Cuda 9.2 now. |
And, they passed. I can merge this, unless there's something else that needs to happen with it first |
Fixes #1186, #1194