1098 Enable assertions during CI when release builds are used #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… script (defaulted to false)
Codecov Report
@@ Coverage Diff @@
## develop #1107 +/- ##
===========================================
- Coverage 76.43% 76.25% -0.19%
===========================================
Files 698 702 +4
Lines 26475 26540 +65
===========================================
+ Hits 20237 20238 +1
- Misses 6238 6302 +64
|
JacobDomagala
force-pushed
the
1098-enable-assertions-during-ci
branch
from
8fb1744 to
6f728ea
Compare
lifflander
requested changes
Oct 12, 2020
…flows.ini files so it's properly added during workflow generation
PhilMiller
reviewed
Oct 13, 2020
This was referenced Oct 13, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new flag
vt_ci_buildto distinguish CI build from normal one. By default this only affects CI runs, meaning that if VT is built in Release mode locally (via docker containter or cmake) this will still haveproductionflag set on.Also, I think having the option to check for build type in the code can be useful in future (i.e. for unit tests we might want different behaviour in CI and different locally). So now you can check for CI build using
vt_check_enabled(ci_build)Fixes #1098