Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable assertions during CI when release builds are used #1098

Closed
lifflander opened this issue Sep 29, 2020 · 1 comment · Fixed by #1107 or #1109
Closed

Enable assertions during CI when release builds are used #1098

lifflander opened this issue Sep 29, 2020 · 1 comment · Fixed by #1107 or #1109
Assignees
@JacobDomagala
Labels
1.0.0-beta.10.4 type: task

Comments

@lifflander
Copy link
Collaborator

lifflander commented Sep 29, 2020 •
edited
Loading

Right now, if you build with cmake in release mode, assertions vtAssert*() are disabled. Since the workflows all build in release to reduce memory usage, we don't see if assertions are breaking. I believe the configuration parameter vt_check_enabled(production) is used to switch between assertion failures breaking or not in release mode.

Add a cmake option to control this so we can have assertions in release builds in the workflows.
@lifflander lifflander changed the title Enable assertions during CI Enable assertions during CI when release builds are used Sep 29, 2020
JacobDomagala added a commit that referenced this issue Oct 12, 2020
@JacobDomagala
#1098: Add new CMake flag to detect CI build
3582cba
JacobDomagala added a commit that referenced this issue Oct 12, 2020
@JacobDomagala
#1098: Use new CMake flag in Github workflows and add it to build_cpp…
a5e2903 
… script (defaulted to false)
JacobDomagala added a commit that referenced this issue Oct 12, 2020
@JacobDomagala
#1098: Forward VT_VI_BUILD flag to docker-compose
3cb9f70
JacobDomagala added a commit that referenced this issue Oct 12, 2020
@JacobDomagala
#1098: Add assertion to test whether new flag works on CI
8fb1744
JacobDomagala added a commit that referenced this issue Oct 12, 2020
@JacobDomagala
#1098: Forward VT_CI_BUILD flag to docker-compose
6f728ea
@JacobDomagala JacobDomagala mentioned this issue Oct 12, 2020
Merged
JacobDomagala added a commit that referenced this issue Oct 12, 2020
@JacobDomagala
#1098: Add option to use ci_build flag in code
053d477
JacobDomagala added a commit that referenced this issue Oct 12, 2020
@JacobDomagala
#1098: Add new variable vt_ci_build to workflow-template.yml and work…
3bf637c 
…flows.ini files so it's properly added during workflow generation
JacobDomagala added a commit that referenced this issue Oct 13, 2020
@JacobDomagala
#1098: Set default value of vt_ci_build to '0' inside CMake
25c3b5a
@JacobDomagala
Copy link
Contributor

Reopened after comment #1107 (comment)

@JacobDomagala JacobDomagala reopened this Oct 13, 2020
@JacobDomagala JacobDomagala mentioned this issue Oct 13, 2020
Merged
JacobDomagala added a commit that referenced this issue Oct 13, 2020
@JacobDomagala
#1098: Set default value of vt_ci_build to '0' inside CMake
e66eab2
bradybray pushed a commit that referenced this issue Oct 15, 2020
@JacobDomagala
#1098: Add new CMake flag to detect CI build
63d4bb3
bradybray pushed a commit that referenced this issue Oct 15, 2020
@JacobDomagala
#1098: Use new CMake flag in Github workflows and add it to build_cpp…
9d92947 
… script (defaulted to false)
bradybray pushed a commit that referenced this issue Oct 15, 2020
@JacobDomagala
#1098: Forward VT_CI_BUILD flag to docker-compose
090eb01
bradybray pushed a commit that referenced this issue Oct 15, 2020
@JacobDomagala
#1098: Add option to use ci_build flag in code
df32a33
bradybray pushed a commit that referenced this issue Oct 15, 2020
@JacobDomagala
#1098: Add new variable vt_ci_build to workflow-template.yml and work…
3e9800a 
…flows.ini files so it's properly added during workflow generation
bradybray pushed a commit that referenced this issue Oct 15, 2020
@JacobDomagala
#1098: Set default value of vt_ci_build to '0' inside CMake
c190490
bradybray pushed a commit that referenced this issue Oct 15, 2020
@JacobDomagala
#1098: Add new CMake flag to detect CI build
d3af886
bradybray pushed a commit that referenced this issue Oct 15, 2020
@JacobDomagala
#1098: Use new CMake flag in Github workflows and add it to build_cpp…
4080b30 
… script (defaulted to false)
bradybray pushed a commit that referenced this issue Oct 15, 2020
@JacobDomagala
#1098: Forward VT_CI_BUILD flag to docker-compose
4d88f11
bradybray pushed a commit that referenced this issue Oct 15, 2020
@JacobDomagala
#1098: Add option to use ci_build flag in code
5c9ae1b
bradybray pushed a commit that referenced this issue Oct 15, 2020
@JacobDomagala
#1098: Add new variable vt_ci_build to workflow-template.yml and work…
6bdca1b 
…flows.ini files so it's properly added during workflow generation
bradybray pushed a commit that referenced this issue Oct 15, 2020
@JacobDomagala
#1098: Set default value of vt_ci_build to '0' inside CMake
bbb8f78
cz4rs pushed a commit that referenced this issue Jan 5, 2021
@JacobDomagala @cz4rs
#1098: Add new CMake flag to detect CI build
a363a7d
cz4rs pushed a commit that referenced this issue Jan 5, 2021
@JacobDomagala @cz4rs
#1098: Use new CMake flag in Github workflows and add it to build_cpp…
8ee00da 
… script (defaulted to false)
cz4rs pushed a commit that referenced this issue Jan 5, 2021
@JacobDomagala @cz4rs
#1098: Forward VT_CI_BUILD flag to docker-compose
9f872df
cz4rs pushed a commit that referenced this issue Jan 5, 2021
@JacobDomagala @cz4rs
#1098: Add option to use ci_build flag in code
f66c1bd
cz4rs pushed a commit that referenced this issue Jan 5, 2021
@JacobDomagala @cz4rs
#1098: Set default value of vt_ci_build to '0' inside CMake
e871b61
@cz4rs cz4rs mentioned this issue Jan 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JacobDomagala JacobDomagala

Labels
1.0.0-beta.10.4 type: task
Projects
None yet
Milestone
No milestone
3 participants
@lifflander @cz4rs @JacobDomagala