Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG_SP] The vehicle ignores sharp turns after detecting a collision. #3512

Closed
Beesmaster opened this issue Oct 9, 2024 · 12 comments · Fixed by #3517
Closed

[BUG_SP] The vehicle ignores sharp turns after detecting a collision. #3512

Beesmaster opened this issue Oct 9, 2024 · 12 comments · Fixed by #3517
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Beesmaster
Copy link

READ FIRST
https://github.com/Courseplay/Courseplay_FS22/wiki
It's my first bug, so i'm sorry in advance when i some reported wrong.
Steps to reproduce
Steps to reproduce the behavior:
When the vehicle encounters a collision, it attempts to find an alternative route to return to its course.

Actual behavior
When it finds a way to return to the course, the vehicle ignores sharp turns from that moment onward.

Expected behavior
When the vehicle finds an alternative route, it should not ignore sharp turns on the course, because certain areas may be missed during the operation; for example, the baler might not collect all the grass.
Screenshots
If applicable, add screenshots to help explain your problem.
Screenshots below
image
image

Courseplay version
Version used: 7.4.2.3 (the problem start form 7.4.2 version)

Log
Please attach a log with all debug channels active.
For help with the debug channels,
please check out the readme at the github front page.
I'm not sure what part of log describe a ignoring point's.
Map
Map played on: Szpakowo

Vehicles/ implements involved
Which vehicle or implement? URSUS 4 Pack from kasztan and Samasz hay rake
Mod yes/no ? Yes

Relevant script mods
Mods like Autodrive or VCA and so on. N/A

@Beesmaster Beesmaster added the bug Something isn't working label Oct 9, 2024
@Beesmaster Beesmaster changed the title [BUG_SP] [BUG_SP] The vehicle ignores sharp turns after detecting a collision. Oct 9, 2024
@Tensuko
Copy link
Contributor

Tensuko commented Oct 10, 2024

A complete logfile would have been helpful here.
Just upload the log.txt https://github.com/Courseplay/Courseplay_FS22/wiki

@Tensuko
Copy link
Contributor

Tensuko commented Oct 10, 2024

log.txt
fsScreen_2024_10_10_17_55_48
fsScreen_2024_10_10_17_56_20

@Beesmaster
Copy link
Author

log.txt
Please find the log in the attachment. To ensure that the problem includes the log, I placed the CASE 7250 PRO with Meprozet on the field, and the issue was repeated.

@pvaiko pvaiko linked a pull request Oct 10, 2024 that will close this issue
@Tensuko Tensuko added this to the 7.4.2.4 milestone Oct 11, 2024
Tensuko added a commit that referenced this issue Oct 14, 2024
- Fix for #3491
- Fix for #3493
- Fix for #3506
- Fix for #3512
- Fix for #3515
- Fix for #3522
- Fix for #3524
- Fix invalid waypoint direction
- Added global setting for refilling fuel, so the driver won't stop when it run out of fuel. Players can drive near it with a tank wagon and it will fill up itself.
- Added vehicle setting for refilling consumables for basically all kind of consumables. The Driver will wait until the consumable is added by placing container near it or fill it up with a shovel or auger wagon. When nothing more is near the driver or nothing more is filled in withint a specific timethe driver will continue it's work.
- Smoother headlands #3510

Hopefully found the last bugs :)
Preparing now for ModHub? :)
@Beesmaster
Copy link
Author

Hello Team,

Today, the issue occurred again during the round ballers operation. The machine's behavior was exactly as previously described. Attached are the log and a screenshot showing where the bug appeared again. As you can see in the log, I stopped the machine and restarted it. Since then, it has been working correctly. It seems this bug only occurs during round ballers operation, as I don’t recall encountering it during other tasks, like plowing, when the machine was blocked.

log.txt
bug ignoring sharp corners

@Tensuko
Copy link
Contributor

Tensuko commented Oct 27, 2024

So it is only during baling?
Nothing else?

@Beesmaster
Copy link
Author

Today, I noticed this issue again during baling. I will test it with other tasks and keep you updated.

@Beesmaster
Copy link
Author

So, I confirm that the problem still exists. I tested vehicles during baling, plowing, and cultivation of the field. I used two different tractors and three machines. The problem occurs when the vehicle tries to turn on the field for the next path. As I reported during version 4.3 (maybe something happened during the repair of other bugs?), this issue persists.

This confirms the issue during plowing. The vehicle fails to lift the plow and turn it.

1
2

And also the confirmation durin the cultivation field:

Normal behavior,
3

Blocking machine by the balle.

6

Beahvior after the vehicle find alternative path:

7
8

Log:
log.txt

@Beesmaster
Copy link
Author

Additionally, this issue seems very similar to what I found. The vehicle behavior is identical.

#3391

However, I'd like to confirm that the courses generated on my screen are indeed new. I want to be sure all courses are freshly created.

@pvaiko pvaiko reopened this Oct 27, 2024
@pvaiko
Copy link
Contributor

pvaiko commented Oct 27, 2024

Log: log.txt

For the record: what happened here is that the ProximityController keeps calling the blocking object listener of the RecoveryTurn (instead of calling it once only) while the pathfinder is still running and this throws off the logic. As far as I can tell, has nothing to do with the latest changes.

pvaiko added a commit that referenced this issue Oct 27, 2024
Also, proximity controller calls the blocked object listener
once only, then restarts the timer.

#3512
@Beesmaster
Copy link
Author

Hi Pvaiko.
Of course, that was only my suggestion. Maybe I was lucky and didn't notice that in the previous version of CP. One thing I'm pretty sure of is that the problem wasn't in 7.3. If you want, this evening I can test 7.3 if that would be helpful.

@pvaiko
Copy link
Contributor

pvaiko commented Oct 28, 2024

I think it never worked properly if the pathfinding took longer than 4 update loops, but don't waste your time with it, if you want, test the pull request.

@Beesmaster
Copy link
Author

Hello Team,

I tested the pull request, and now everything works properly. When the vehicle encounters a blockade while turning, it finds an alternative path and continues to operate correctly. There’s only one area for potential improvement: finding an alternative path during plowing. Currently, while the vehicle searches for a new path, the plow remains down and does not switch to the opposite side. However, once the vehicle reaches the next turn, it resumes working correctly, so this is a big improvement.

Attached is a screenshot showing how the vehicle finds an alternative path during plowing, along with the log.
image

log.txt

@Tensuko Tensuko modified the milestones: 7.4.2.4, 7.5.0.1 Oct 29, 2024
@Tensuko Tensuko closed this as completed Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants