Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midway merge 0.5.1 #687

Merged
merged 74 commits into from
Jun 5, 2019
Merged

Midway merge 0.5.1 #687

merged 74 commits into from
Jun 5, 2019

Conversation

cemozerr
Copy link
Contributor

PR Description

Updates codebase to spec version 0.5.1.

Fixed Issue(s)

schroedingerscode and others added 30 commits April 1, 2019 12:29
* Change BeaconState, add BeaconBlockHeader

* Update ethereum/datastructures/src/main/java/tech/pegasys/artemis/datastructures/Constants.java

* Update ethereum/datastructures/src/main/java/tech/pegasys/artemis/datastructures/state/BeaconState.java

* Update ethereum/datastructures/src/main/java/tech/pegasys/artemis/datastructures/Constants.java

* Remove constant
* Change constants init

* 711 changes until epoch

* Use new block processing functions, remove old ones

* Rewrite all epoch functions

* Remove old epoch functions

* Finish complete rewrite of state transition
* Updates function signatures, adds and updates docstrings, removes duplicate functions.

* Changes Integer to int types.

* Switched 3 function names to plural.
…licate functions (Consensys#555)

* Updates function signatures, adds and updates docstrings, removes duplicate functions.

* Changes Integer to int types.

* Switched 3 function names to plural.
* Updated get_initial_beacon_state instances to correct name get_genesis_beacon_state.

* Update constant name

* Fixes BeaconStateTest

* Update Fork value types and tests.
…ensys#554)

* First pass through data structures, add comments where bounded tuples go.

* Eliminate length mixin for known length Bytes32 values.

* Add reference to packaged Cava SSZ Jar. This is temporary while Cava migrates to Apache.

* Add support for fixed length lists.

* Add support for fixed length lixed of variable sized Bytes.

* Dummy change to README.md to show that it is writable

* comment to resolve discussion

* fix for cem
* Change lmdGhost & run spotlessApply

* Change start block to state

* Rename to start_state
* Fixes indexing error in verify_merkle_branch

* Removes unnecessary change
* Fixes build errors related to tests

* Removes unused function ceil_div8
* Rewrite hash_tree_root convenience functions for SSZ v0.5.1.

* Add hash_tree_root function to Artemis SSZ container types.

* Check in fixes for all hash_tree_root usages except BeaconState. BeaconState is still pending.

* First pass hash_tree_root for BeaconState, resolve majority of compile errors.

* Finish BeaconState hash_tree_root, resolve remaining compile errors.

* SSZ mix_in_length helper for hash_tree_root calculation must use little endian byte order.

* Fixes to make merkleize and pack v0.5.1 compliant.

* Remove references to old merkleHash function.

* Refactor SSZ hash_tree_root to eliminate duplicated boilerplate code where possible.
* Resolve math error in SSZ pack.

* BLSSignature should use writeFixedBytes.

* Make referenced List mutable for merkleizing.

* Don't write length mixin when serializing BLSPublicKey.

* Change byte order in get_domain. Will need to investigate further.
@cemozerr cemozerr marked this pull request as ready for review June 4, 2019 21:17
Copy link
Contributor

@schroedingerscode schroedingerscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having worked on this for a month or more, I can definitively say that this is good enough for me.

@jrhea jrhea merged commit 8dfc941 into Consensys:master Jun 5, 2019
@jrhea jrhea mentioned this pull request Jun 5, 2019
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants