-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Midway merge 0.5.1 #687
Merged
Merged
Midway merge 0.5.1 #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change BeaconState, add BeaconBlockHeader * Update ethereum/datastructures/src/main/java/tech/pegasys/artemis/datastructures/Constants.java * Update ethereum/datastructures/src/main/java/tech/pegasys/artemis/datastructures/state/BeaconState.java * Update ethereum/datastructures/src/main/java/tech/pegasys/artemis/datastructures/Constants.java * Remove constant
* Change constants init * 711 changes until epoch * Use new block processing functions, remove old ones * Rewrite all epoch functions * Remove old epoch functions * Finish complete rewrite of state transition
* Updates function signatures, adds and updates docstrings, removes duplicate functions. * Changes Integer to int types. * Switched 3 function names to plural.
…licate functions (Consensys#555) * Updates function signatures, adds and updates docstrings, removes duplicate functions. * Changes Integer to int types. * Switched 3 function names to plural.
* Updated get_initial_beacon_state instances to correct name get_genesis_beacon_state. * Update constant name * Fixes BeaconStateTest * Update Fork value types and tests.
…ensys#554) * First pass through data structures, add comments where bounded tuples go. * Eliminate length mixin for known length Bytes32 values. * Add reference to packaged Cava SSZ Jar. This is temporary while Cava migrates to Apache. * Add support for fixed length lists. * Add support for fixed length lixed of variable sized Bytes. * Dummy change to README.md to show that it is writable * comment to resolve discussion * fix for cem
* Change lmdGhost & run spotlessApply * Change start block to state * Rename to start_state
* Fixes indexing error in verify_merkle_branch * Removes unnecessary change
…nsys#588)" (Consensys#589) This reverts commit 21f3c84.
* Fixes build errors related to tests * Removes unused function ceil_div8
* Rewrite hash_tree_root convenience functions for SSZ v0.5.1. * Add hash_tree_root function to Artemis SSZ container types. * Check in fixes for all hash_tree_root usages except BeaconState. BeaconState is still pending. * First pass hash_tree_root for BeaconState, resolve majority of compile errors. * Finish BeaconState hash_tree_root, resolve remaining compile errors. * SSZ mix_in_length helper for hash_tree_root calculation must use little endian byte order. * Fixes to make merkleize and pack v0.5.1 compliant. * Remove references to old merkleHash function. * Refactor SSZ hash_tree_root to eliminate duplicated boilerplate code where possible.
* Resolve math error in SSZ pack. * BLSSignature should use writeFixedBytes. * Make referenced List mutable for merkleizing. * Don't write length mixin when serializing BLSPublicKey. * Change byte order in get_domain. Will need to investigate further.
…n. (Consensys#630)" (Consensys#631) This reverts commit eeb3d5d.
…() to prevent NPE
…d back once we have ssz changes merged into tuweni
Auto-generate protobuf for grpc
schroedingerscode
approved these changes
Jun 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having worked on this for a month or more, I can definitively say that this is good enough for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Updates codebase to spec version 0.5.1.
Fixed Issue(s)