-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update helper functions documentation #557
Merged
akhila-raju
merged 5 commits into
Consensys:v0.5.1-integration
from
akhila-raju:updatehelpers
Apr 5, 2019
Merged
Update helper functions documentation #557
akhila-raju
merged 5 commits into
Consensys:v0.5.1-integration
from
akhila-raju:updatehelpers
Apr 5, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhila-raju
added
the
doc-change-required
Indicates an issue or PR that requires doc to be updated
label
Apr 5, 2019
akhila-raju
changed the title
Update helper documentation
Update helper functions documentation
Apr 5, 2019
schroedingerscode
previously requested changes
Apr 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a naming preference...your call on that one.
ethereum/statetransition/src/main/java/tech/pegasys/artemis/statetransition/LmdGhost.java
Show resolved
Hide resolved
...tetransition/src/main/java/tech/pegasys/artemis/statetransition/util/EpochProcessorUtil.java
Show resolved
Hide resolved
schroedingerscode
dismissed
their stale review
April 5, 2019 16:12
Misread a var when I was reviewing.
schroedingerscode
approved these changes
Apr 5, 2019
cemozerr
reviewed
Apr 5, 2019
...m/datastructures/src/main/java/tech/pegasys/artemis/datastructures/util/BeaconStateUtil.java
Show resolved
Hide resolved
cemozerr
reviewed
Apr 5, 2019
...m/datastructures/src/main/java/tech/pegasys/artemis/datastructures/util/BeaconStateUtil.java
Show resolved
Hide resolved
akhila-raju
pushed a commit
that referenced
this pull request
Apr 5, 2019
This reverts commit 2c5719f.
cemozerr
pushed a commit
that referenced
this pull request
Apr 5, 2019
alexandratran
removed
the
doc-change-required
Indicates an issue or PR that requires doc to be updated
label
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Updates helper functions documentation