Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary argument #644

Merged
merged 1 commit into from
May 8, 2019
Merged

Remove unnecessary argument #644

merged 1 commit into from
May 8, 2019

Conversation

cemozerr
Copy link
Contributor

@cemozerr cemozerr commented May 8, 2019

PR Description

Removes legacy code (unneccesary argument passed into state transition).

Fixed Issue(s)

akhila-raju
akhila-raju approved these changes May 8, 2019
View reviewed changes
Copy link
Contributor

@akhila-raju akhila-raju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

schroedingerscode
schroedingerscode approved these changes May 8, 2019
View reviewed changes
Copy link
Contributor

@schroedingerscode schroedingerscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, figured we'd need to set that during state transition too. LGTM

@cemozerr cemozerr merged commit f4af8ff into Consensys:v0.5.1-integration May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schroedingerscode schroedingerscode schroedingerscode approved these changes

@akhila-raju akhila-raju akhila-raju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cemozerr @akhila-raju @schroedingerscode