Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change lmdGhost & run spotlessApply #585

Merged
merged 3 commits into from
Apr 16, 2019
Merged

Change lmdGhost & run spotlessApply #585

merged 3 commits into from
Apr 16, 2019

Conversation

cemozerr
Copy link
Contributor

PR Description

This PR updates LMD Ghost to match spec v0.5.1. Also runs spotlessApply.

@cemozerr cemozerr added the enhancement 🕵️‍♀️ New feature or request label Apr 15, 2019
@cemozerr cemozerr added this to the Beacon Chain v0.5.1 Spec milestone Apr 15, 2019
@cemozerr cemozerr self-assigned this Apr 15, 2019
akhila-raju
akhila-raju reviewed Apr 15, 2019
View reviewed changes
Copy link
Contributor

@akhila-raju akhila-raju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments - please get another pair of eyes on the logic for lmd_ghost 🙂

dangerousfood
dangerousfood approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@dangerousfood dangerousfood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cemozerr cemozerr merged commit a952307 into Consensys:v0.5.1-integration Apr 16, 2019
@cemozerr cemozerr deleted the updateLmdGhost branch April 16, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhila-raju akhila-raju akhila-raju left review comments

@dangerousfood dangerousfood dangerousfood approved these changes

Assignees

@cemozerr cemozerr

Labels
enhancement 🕵️‍♀️ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cemozerr @dangerousfood @akhila-raju