Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement parse and compare hooks #16

Draft
wants to merge 78 commits into
base: develop
Choose a base branch
from

Conversation

olmokramer
Copy link

This adds 4 lifecycle hooks:

  • A pre-parsing stage hook, which is called before all submissions are parsed. It is called with the list with all submission paths eligible for the comparison, i.e. all paths that are not filtered out by SubmissionSetBuilder.isExcludedEntry.
  • A post-parsing hook per submission, which is called after the submission has been parsed. It is called with the Submission object that has been parsed.
  • A pre-comparing stage hook, which is called before the comparisons are started. It is called with a list of all comparison tuples.
  • A post-comparing hook, which is called after each comparison. It is called with the SubmissionTuple that has just been compared.

@olmokramer olmokramer force-pushed the feature/add-parse-and-compare-hooks branch 3 times, most recently from 48ecef4 to b72c61f Compare September 8, 2023 14:24
@olmokramer olmokramer force-pushed the feature/add-parse-and-compare-hooks branch from 0be6f36 to c8b2379 Compare September 18, 2023 14:39
Kr0nox and others added 25 commits September 18, 2023 17:44
Store selections from overview when switching views
…/report-viewer (jplag#1306)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…iewer (jplag#1304)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ort-viewer (jplag#1305)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…0 in /report-viewer (jplag#1308)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [org.eclipse.emf:org.eclipse.emf.ecore](https://github.com/eclipse-emf/org.eclipse.emf) from 2.34.0 to 2.35.0.
- [Commits](https://github.com/eclipse-emf/org.eclipse.emf/commits)

---
updated-dependencies:
- dependency-name: org.eclipse.emf:org.eclipse.emf.ecore
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [org.eclipse.emf:org.eclipse.emf.ecore.xmi](https://github.com/eclipse-emf/org.eclipse.emf) from 2.18.0 to 2.35.0.
- [Commits](https://github.com/eclipse-emf/org.eclipse.emf/commits)

---
updated-dependencies:
- dependency-name: org.eclipse.emf:org.eclipse.emf.ecore.xmi
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [org.eclipse.emf:org.eclipse.emf.common](https://github.com/eclipse-emf/org.eclipse.emf) from 2.28.0 to 2.29.0.
- [Commits](https://github.com/eclipse-emf/org.eclipse.emf/commits)

---
updated-dependencies:
- dependency-name: org.eclipse.emf:org.eclipse.emf.common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [org.apache.maven.plugins:maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.5.0 to 3.6.0.
- [Release notes](https://github.com/apache/maven-javadoc-plugin/releases)
- [Commits](apache/maven-javadoc-plugin@maven-javadoc-plugin-3.5.0...maven-javadoc-plugin-3.6.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-javadoc-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…ltiple-advanced-args

Allow passing multiple options in the "Advanced" group
…ewer (jplag#1318)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…eport-viewer (jplag#1315)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…/report-viewer (jplag#1314)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…er (jplag#1316)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…o 4.5.5 (jplag#1313)

Bumps edu.stanford.nlp:stanford-corenlp from 4.5.4 to 4.5.5.

---
updated-dependencies:
- dependency-name: edu.stanford.nlp:stanford-corenlp
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…8.11 (jplag#1312)

Bumps [org.scalameta:scalameta_2.13](https://github.com/scalameta/scalameta) from 4.8.10 to 4.8.11.
- [Release notes](https://github.com/scalameta/scalameta/releases)
- [Commits](scalameta/scalameta@v4.8.10...v4.8.11)

---
updated-dependencies:
- dependency-name: org.scalameta:scalameta_2.13
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This adds 4 hooks that can be set on the `JPlagOptions` class:

- A pre-parsing stage hook, which is called before all submissions are
  parsed. It is called with the list with all submission paths eligible
  for the comparison, i.e. all paths that are not filtered out by
  `SubmissionSetBuilder.isExcludedEntry`.
- A post-parsing hook per submission, which is called after the
  submission has been parsed. It is called with the `Submission`
  object that has been parsed.
- A pre-comparing stage hook, which is called before the comparisons
  are started. It is called with a list of all comparison tuples.
- A post-comparing hook, which is called after each comparison. It
  is called with the `SubmissionTuple` that has just been compared.
@olmokramer olmokramer force-pushed the feature/add-parse-and-compare-hooks branch from c8b2379 to 55624bd Compare October 3, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants