Re-write/Fix antlr-utils #1263
Merged
Re-write/Fix antlr-utils #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brodmo
force-pushed
the
antlr-utils-rewrite
branch
from
1b965b7 to
ef9dce3
Compare
tsaglam
added
enhancement
TwoOfTwelve
requested changes
Aug 28, 2023
language-antlr-utils/src/main/java/de/jplag/antlr/AbstractAntlrParserAdapter.java
Outdated
Show resolved
Hide resolved
language-antlr-utils/src/main/java/de/jplag/antlr/AbstractAntlrParserAdapter.java
Outdated
Show resolved
Hide resolved
language-antlr-utils/src/main/java/de/jplag/antlr/AbstractAntlrListener.java
Show resolved
Hide resolved
brodmo
force-pushed
the
antlr-utils-rewrite
branch
from
6258e95 to
cc156ec
Compare
tsaglam
requested changes
Aug 29, 2023
language-antlr-utils/src/main/java/de/jplag/antlr/TokenCollector.java
Outdated
Show resolved
Hide resolved
language-antlr-utils/src/main/java/de/jplag/antlr/TokenCollector.java
Outdated
Show resolved
Hide resolved
language-antlr-utils/src/main/java/de/jplag/antlr/AbstractAntlrListener.java
Show resolved
Hide resolved
language-antlr-utils/src/main/java/de/jplag/antlr/AbstractAntlrParserAdapter.java
Outdated
Show resolved
Hide resolved
Kr0nox
requested changes
Sep 12, 2023
brodmo
force-pushed
the
antlr-utils-rewrite
branch
from
ea7da49 to
3efd496
Compare
|
[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed! |
|
Should be ready now, sorry for the delay |
TwoOfTwelve
approved these changes
Sep 14, 2023
Kr0nox
approved these changes
Sep 14, 2023
tsaglam
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing antrl-utils lacks some critical functionality (support for listeners, updating semantics upon adding tokens) and is, in my eyes, a bit more complicated than necessary. This pull request adds the missing functionality, streamlines the interface, and simplifies the internal code.