Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips in report viewer #1292

Merged
merged 17 commits into from
Sep 18, 2023
Merged

Tooltips in report viewer #1292

merged 17 commits into from
Sep 18, 2023

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Sep 10, 2023

This PR adds an easy way of adding tooltips to the report viewer.
In addition it adds a generalized selector for metrics.

Some components already got tooltips. more can be added in either this or a seperate PR.
Due to the growing amount of components, I moved the components related to the options selector into its own sub folder

@Kr0nox Kr0nox requested a review from sebinside September 10, 2023 10:55
@Kr0nox Kr0nox changed the title tooltip component Tooltips Sep 10, 2023
@Kr0nox Kr0nox changed the title Tooltips Tooltips in report viewer Sep 10, 2023
@sonarqubecloud
Copy link

[JPlag Report Viewer] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@sebinside sebinside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should discuss the fade-in delay and the content of the tooltips (and possibilities for more helpful tooltips!) in a future meeting with @tsaglam, but for now, this can be merged.

@sebinside sebinside merged commit 0fe97ee into develop Sep 18, 2023
@sebinside sebinside deleted the report-viewer/tooltips branch September 18, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants