Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapper for async Views #1320

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Wrapper for async Views #1320

merged 1 commit into from
Sep 29, 2023

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Sep 28, 2023

The router has some problems with the suspense block for async components.
Because of this, this PR adds a wrapper for all async components

@Kr0nox Kr0nox requested a review from sebinside September 28, 2023 13:26
@sonarqubecloud
Copy link

[JPlag Report Viewer] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tsaglam tsaglam added bug Issue/PR that involves a bug enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Sep 29, 2023
sebinside
sebinside approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@sebinside sebinside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement, the bug seems to be fixed and the report viewer feels even more snappier. I like it!

@sebinside sebinside merged commit 9149f42 into develop Sep 29, 2023
17 checks passed
@sebinside sebinside deleted the report-viewer/view-wrapper branch September 29, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebinside sebinside sebinside approved these changes

Assignees
No one assigned
Labels
bug Issue/PR that involves a bug enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kr0nox @sebinside @tsaglam