Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EXT_feature_metadata to EXT_structural_metadata #654

Merged
merged 153 commits into from
Sep 8, 2023

Conversation

j9liu
Copy link
Contributor

@j9liu j9liu commented May 24, 2023

Closes #407. This PR is a DRAFT that I'm opening to track the remaining tasks on the staging branch.

When complete, this PR will handle metadata based on EXT_structural_metadata, the 3D Tiles 1.1 metadata extension. EXT_feature_metadata should still be parsed, but it will be internally converted to EXT_structural_metadata Batch tables in .b3dm and .pnts tiles will be converted to property tables in EXT_structural_metadata. Feature IDs will be indicated by EXT_mesh_features.

EXT_feature_metadata will no longer be supported.

Progress

Additionally, Cesium for Unreal and Cesium for Unity's metadata systems should be updated to account for differences in the implementation.

Observations

  • schemaUri doesn't seem to be handled for EXT_feature_metadata, and EXT_structural_metadata requires either it or schema to be present. Support should be added in a future PR
  • Property views on ENUM types are not supported

Janine Liu and others added 30 commits May 10, 2023 15:43
Use `EXT_mesh_features` to indicate batch IDs
Use partial template specialization to reduce code duplication
Add classes to convert between C++ and `EXT_structural_metadata` property types
@kring kring marked this pull request as ready for review September 8, 2023 13:25
@kring
Copy link
Member

kring commented Sep 8, 2023

Amazing work @j9liu!

@kring kring merged commit 7fd4361 into main Sep 8, 2023
2 checks passed
@kring kring deleted the upgrade-feature-metadata branch September 8, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support EXT_mesh_features
3 participants