-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EXT_feature_metadata
to EXT_structural_metadata
#654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `EXT_mesh_features` to indicate batch IDs
…o specialize-traits
…o specialize-traits
Use partial template specialization to reduce code duplication
Add classes to convert between C++ and `EXT_structural_metadata` property types
Add `StructuralMetadataPropertyView`
Create `PropertyView` base class with normalization handling
…roperty-attributes
Add `PropertyAttributeView` and `PropertyAttributePropertyView`.
…inal-metadata-changes
Miscellaneous `EXT_structural_metadata` changes
Amazing work @j9liu! |
This was referenced Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #407. This PR is a DRAFT that I'm opening to track the remaining tasks on the staging branch.
When complete, this PR will handle metadata based on
EXT_structural_metadata
, the 3D Tiles 1.1 metadata extension.Batch tables inEXT_feature_metadata
should still be parsed, but it will be internally converted toEXT_structural_metadata
.b3dm
and.pnts
tiles will be converted to property tables inEXT_structural_metadata
. Feature IDs will be indicated byEXT_mesh_features
.EXT_feature_metadata
will no longer be supported.Progress
EXT_mesh_features
EXT_structural_metadata
counterparts to underlying metadata retrieval implementationEXT_structural_metadata
#655EXT_feature_metadata
andEXT_mesh_features
files #668EXT_structural_metadata
inupsampleGltfForRasterOverlays
#667PropertyView
base class with normalization handling #713PropertyAttributeView
andPropertyAttributePropertyView
. #716EXT_structural_metadata
changes #719Additionally, Cesium for Unreal and Cesium for Unity's metadata systems should be updated to account for differences in the implementation.
Observations
schemaUri
doesn't seem to be handled forEXT_feature_metadata
, andEXT_structural_metadata
requires either it orschema
to be present. Support should be added in a future PRENUM
types are not supported