Add PropertyAttributeView and PropertyAttributePropertyView.
#716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j9liu
commented
Aug 29, 2023
j9liu
commented
Aug 29, 2023
8 tasks
|
This all looks good to me. Happy to merge it after #713. |
Base automatically changed from
additional-property-details
to
upgrade-feature-metadata
September 8, 2023 01:56
…roperty-attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds views for
PropertyAttributeandPropertyAttributeProperty, similar to the views for property tables and textures. Unlike the others, which can construct views on theModelextension alone, thePropertyAttributeViewrequires aMeshPrimitiveto construct aPropertyAttributePropertyViewon. This is because the data exists as an attribute on the primitive-level, not as data on the root model.Added some unit tests as well. Feel free to ignore the changes in the non-
PropertyAttributespecs. Most of it was reorganizing the tests, cleaning up code, and correcting some uncaught errors from the previous PR.