Remove old metadata implementation files #658
Conversation
|
Hold on merging this -- I'll work on integrating the new implementation into Unreal, using the old files as reference. When I confirm that it works in Unreal I'll un-draft this. |
j9liu
force-pushed
the
replace-feature-metadata-files
branch
from
17e1c85 to
a50093c
Compare
| @@ -34,14 +32,14 @@ template <typename ElementType> class MetadataArrayView { | |||
| int64_t size() const noexcept { return static_cast<int64_t>(_values.size()); } | |||
|
|
|||
| private: | |||
| const gsl::span<const ElementType> _values; | |||
| gsl::span<const ElementType> _values; | |||
There was a problem hiding this comment.
The const here was incorrect; it prevented me from using the array view in a std::variant in Cesium for Unreal.
|
@kring updated this PR, and happy to have it be merged now. There are some miscellaneous edits to I tried to update the changelog in a comprehensive but readable way, but there's a lot of changes. So feel free to workshop it. |
|
I'm going to self-merge this since this is mostly file renames (and I don't want to keep adding to @kring's backlog). |
This PR does the following:
EXT_feature_metadata.MeshFeaturesandStructuralMetadatanamespace.This is based on #656, so merge that first.