Add classes to convert between C++ and EXT_structural_metadata property types
#640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't fully reviewed this yet, because I got distracted with seeing if I could simplify the traits with some partial template specialization. But it definitely looks good at a high level! |
…o specialize-traits
…o specialize-traits
Use partial template specialization to reduce code duplication
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
EXT_structural_metadatacounterparts to thePropertyType.handPropertyTypeTraits.hfiles under anew files and a "StructuralMetadata" namespace. The idea is that once everything is done, the old files will be deleted and the new files will be renamed.@kring It's a pretty monotonous PR but I'd love to know if there's any way to make this more... nice? Templated? If at all possible. Especially with the
vecNandmatNpermutations. I also was incorrect, there are integermatNs and my Visual Studio Intellisense wasn't 100% working 🙃There's a Visual Studio warning in
TestStructuralMetadataPropertyTypeTraitsthat the function takes up a lot of memory on the stack -- should I address this?