Import feature flag validation API and related UI changes, validation table #1798

Yagnik56 · 2024-08-05T11:47:34Z

This PR introduces several new features and improvements:

Validation Enhancements:

Added a new validation API.
Implemented validation-related UI changes.
Introduced a compatibility table with a spinner that appears during validation.

Bug Fixes:

Corrected the FeatureFlag Validator components. (Issue)
Fixed UI issues in the Import Modal File Success. (Issue)
Addressed the happy path scenarios for the Import Modal File UI. (Issue)
Added a spinner for the pending state during validation. (Issue)
Ensured the endpoint returns the compatibility of import validation. (Issue)

Merged PRs:

Merged the FeatureFlag Import API. (PR)
Refactored 'List' to 'Segment' in FeatureFlag. (PR)
Included changes to address errors thrown on updating FeatureFlag. (PR)

This PR is now ready for review

backend/packages/Upgrade/src/api/services/FeatureFlagService.ts

bcb37

I've looked at the backend. I had a couple suggestions.

backend/packages/Upgrade/src/api/services/FeatureFlagService.ts

RidhamShah · 2024-08-06T06:29:56Z

@bcb37 just a clarification, does the warning state only come if any public subsegments of private segments are not present?

...hboard/feature-flags/modals/import-feature-flag-modal/import-feature-flag-modal.component.ts

bcb37 · 2024-08-06T18:25:19Z

@bcb37 just a clarification, does the warning state only come if any public subsegments of private segments are not present?

That's my understanding, yes.

zackcl · 2024-08-07T13:27:27Z

...hboard/feature-flags/modals/import-feature-flag-modal/import-feature-flag-modal.component.ts

+        (await this.featureFlagsDataService.validateFeatureFlag(files).toPromise()) as ValidateFeatureFlagError[]
+      ).filter((data) => data.compatibilityType != null) || [];
+    this.importFileErrorsDataSource.data = this.importFileErrors;
+    this.featureFlagsService.setIsLoadingImportFeatureFlag(false);


It looks like Observable<Object>.toPromise() is deprecated and is replaced with firstValueFrom and lastValueFrom. Could you update this?

zackcl · 2024-08-07T13:28:55Z

@Yagnik56 It looks like importing with dragging and dropping a file is not implemented yet.

FeatureFlag import API

zackcl · 2024-08-26T12:17:58Z

It seems like the compatibility type is always "Incompatible" even if I import the valid one (which I just exported).

Yagnik56 · 2024-08-26T12:22:52Z

It seems like the compatibility type is always "Incompatible" even if I import the valid one (which I just exported).

@zackcl Did you change the KEY after you exported the FF? duplicate key will give you an incompatible message...

zackcl · 2024-08-26T12:34:39Z

@Yagnik56 No, I tried importing when there are no flags defined. I exported a feature flag, and then deleted the existing one, and then imported the exported one. Can you also try this yourself?

RidhamShah · 2024-08-27T05:47:08Z

@Yagnik56 No, I tried importing when there are no flags defined. I exported a feature flag, and then deleted the existing one, and then imported the exported one. Can you also try this yourself?

@zackcl The export structure is not perfect, there were some property names mismatched, this is discussed in export PR. Its merge is remaining that's why exported FeatrueFlags shows error while importing

…ion-rename-list-to-segment Rename 'list' to 'segment' in FeatureFlagListValidator and related files

backend/packages/Upgrade/src/api/controllers/validators/FeatureFlagImportValidator.ts

* solve feature flag throwing error update * Removed unused properties from featureFlags related interfaces --------- Co-authored-by: RidhamShah <[email protected]>

danoswaltCL · 2024-09-04T13:51:10Z

@VivekFitkariwala will check latest

ppratikcr7 and others added 7 commits July 26, 2024 14:48

import ff validation api and frontend integration part1 WIP

84387a9

merge conflict resolved

163ac7a

merge conflict resolved

855ee4d

import validation to return compatibility

61ae289

resolved merge conflicts

637b9c4

validation req, table, loading spinner and import action button code

480e16e

resolved merge conflicts

042415b

Yagnik56 requested review from zackcl and danoswaltCL August 5, 2024 11:47

Yagnik56 assigned Yagnik56 and RidhamShah Aug 5, 2024

Yagnik56 requested review from VivekFitkariwala and bcb37 August 5, 2024 11:48

This was linked to issues Aug 5, 2024

FF: Pending state in Import Flag modal while validating json #1717

Closed

FF: Import Modal File Validation Happy Path #1720

Closed

bcb37 reviewed Aug 5, 2024

View reviewed changes

backend/packages/Upgrade/src/api/services/FeatureFlagService.ts Outdated Show resolved Hide resolved

bcb37 requested changes Aug 5, 2024

View reviewed changes

backend/packages/Upgrade/src/api/services/FeatureFlagService.ts Outdated Show resolved Hide resolved

solve git comments

2807b75

Yagnik56 linked an issue Aug 6, 2024 that may be closed by this pull request

FF: Endpoint to Validate Imported JSON files #1716

Closed

Yagnik56 requested a review from bcb37 August 6, 2024 08:53

danoswaltCL reviewed Aug 6, 2024

View reviewed changes

...hboard/feature-flags/modals/import-feature-flag-modal/import-feature-flag-modal.component.ts Outdated Show resolved Hide resolved

bcb37 previously approved these changes Aug 6, 2024

View reviewed changes

Merge branch 'dev' into featureflag/import-validation-api

98d1ee4

Yagnik56 dismissed bcb37’s stale review via 98d1ee4 August 7, 2024 04:37

Yagnik56 and others added 2 commits August 7, 2024 10:10

resolved the review cmt

bd3b41b

update compatibility warning code

f96ee40

zackcl reviewed Aug 7, 2024

View reviewed changes

RidhamShah and others added 3 commits August 23, 2024 12:11

Update import in FeatureFlagService.ts

661b1a8

updated code to have transaction per import file

07f7755

Merge pull request #1825 from CarnegieLearningWeb/featureflag/import-api

675650f

FeatureFlag import API

Yagnik56 dismissed VivekFitkariwala’s stale review via 675650f August 26, 2024 11:31

Merge branch 'dev' into featureflag/import-validation-api

a3da3cb

Yagnik56 requested review from danoswaltCL and VivekFitkariwala August 26, 2024 12:23

RidhamShah mentioned this pull request Aug 27, 2024

BadRequestError when updating a feature flag with one or more include lists defined #1840

Closed

RidhamShah and others added 6 commits August 29, 2024 12:08

Rename 'list' to 'segment' in FeatureFlagListValidator and related files

8bd7cb1

revert unwanted changes

fb02b2a

solve failing testcases

0aac418

Merge pull request #1879 from CarnegieLearningWeb/featureflag/validat…

c2f5295

…ion-rename-list-to-segment Rename 'list' to 'segment' in FeatureFlagListValidator and related files

refractor the import data format to match exported file format

17cd315

Merge branch 'dev' into featureflag/import-validation-api

bb62ccf

VivekFitkariwala requested changes Sep 2, 2024

View reviewed changes

backend/packages/Upgrade/src/api/controllers/validators/FeatureFlagImportValidator.ts Outdated Show resolved Hide resolved

RidhamShah and others added 2 commits September 3, 2024 17:40

Solve feature flag throwing error on update (#1885)

b7baef5

* solve feature flag throwing error update * Removed unused properties from featureFlags related interfaces --------- Co-authored-by: RidhamShah <[email protected]>

Make interface for common properties of validator

a4f6025

RidhamShah requested a review from VivekFitkariwala September 4, 2024 04:59

danoswaltCL added the epic: feature flags label Sep 4, 2024

RidhamShah added 2 commits September 5, 2024 19:05

Merge branch 'dev' into featureflag/import-validation-api

c1115fb

Solve error and merge conflicts for import

e19b162

VivekFitkariwala approved these changes Sep 6, 2024

View reviewed changes

Merge branch 'dev' into featureflag/import-validation-api

020314f

Yagnik56 merged commit bc3d70f into dev Sep 7, 2024
14 checks passed

Yagnik56 deleted the featureflag/import-validation-api branch September 7, 2024 04:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Import feature flag validation API and related UI changes, validation table #1798

Import feature flag validation API and related UI changes, validation table #1798

Yagnik56 commented Aug 5, 2024 •

edited by RidhamShah

Loading

bcb37 left a comment

RidhamShah commented Aug 6, 2024

bcb37 commented Aug 6, 2024

zackcl Aug 7, 2024 •

edited

Loading

zackcl commented Aug 7, 2024

zackcl commented Aug 26, 2024

Yagnik56 commented Aug 26, 2024

zackcl commented Aug 26, 2024

RidhamShah commented Aug 27, 2024

danoswaltCL commented Sep 4, 2024

Import feature flag validation API and related UI changes, validation table #1798

Import feature flag validation API and related UI changes, validation table #1798

Conversation

Yagnik56 commented Aug 5, 2024 • edited by RidhamShah Loading

Validation Enhancements:

Bug Fixes:

Merged PRs:

bcb37 left a comment

Choose a reason for hiding this comment

RidhamShah commented Aug 6, 2024

bcb37 commented Aug 6, 2024

zackcl Aug 7, 2024 • edited Loading

Choose a reason for hiding this comment

zackcl commented Aug 7, 2024

zackcl commented Aug 26, 2024

Yagnik56 commented Aug 26, 2024

zackcl commented Aug 26, 2024

RidhamShah commented Aug 27, 2024

danoswaltCL commented Sep 4, 2024

Yagnik56 commented Aug 5, 2024 •

edited by RidhamShah

Loading

zackcl Aug 7, 2024 •

edited

Loading