Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF: Pending state in Import Flag modal while validating json #1717

Closed
danoswaltCL opened this issue Jul 2, 2024 · 2 comments · Fixed by #1798
Closed

FF: Pending state in Import Flag modal while validating json #1717

danoswaltCL opened this issue Jul 2, 2024 · 2 comments · Fixed by #1798

Comments

@danoswaltCL
Copy link
Collaborator

danoswaltCL commented Jul 2, 2024

On successful drag end or on successful user-select (i.e. a json file was able to be parse), a call will go out to /featureflags/validation. While that call is pending:

  • the large draggable "Import" widget will be hidden
  • a spinner will show in the middle of the modal (retain the same height as when showing the widget though so it's not janky and popping up and down in height)
  • when the response has been received, the spinner will disappear and the next state will be dispatched.
@zackcl
Copy link
Collaborator

zackcl commented Jul 12, 2024

The load-spinner sounds good to me.

@danoswaltCL danoswaltCL moved this to Refined ToDo in UpGrade Project Jul 19, 2024
@danoswaltCL danoswaltCL changed the title FF: Design needed for validation pending state in Import modal FF: Pending state in Import Flag modal while validating json Jul 19, 2024
@danoswaltCL danoswaltCL moved this from Refined ToDo to In Progress in UpGrade Project Jul 19, 2024
@Yagnik56 Yagnik56 moved this from In Progress to Code Review in UpGrade Project Aug 21, 2024
@amurphy-cl amurphy-cl added this to the Program Increment PI13 milestone Sep 10, 2024
@amurphy-cl amurphy-cl assigned bcb37 and unassigned Yagnik56 Sep 10, 2024
@bcb37
Copy link
Collaborator

bcb37 commented Sep 11, 2024

QA: this looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
5 participants