FF: Endpoint to Validate Imported JSON files

[danoswaltCL]

On drag end or select of valid feature-flag JSON file(s) in the import modal, we will need to support a view that gives the user a list of files, their compatibility status (COMPATIBLE, WARNING and INCOMPATIBLE, and a text warning message for the warning and incompatible states that will give more complete information about what the user can expect or need to correct in order to proceed.

@ppratikcr7 @VivekFitkariwala please help me to fill out the details for acceptance criteria of the response and request so that it will look familiar to the way we do it for experiments.

[bcb37]

The response and request objects should look like they do for /api/flags/:id , with "featureFlagSegmentInclusion" and "featureFlagSegmentExclusion" arrays that define the inclusion and exclusion lists, which should be created via calls to the /segment endpoints as part of the import action. I'm not sure we do it for experiments, but maybe we should verify that all included/excluded (public) segments already exist?

[amurphy-cl]

Reminder that for v1, imports will be one at a time.

Imported feature flag design IDs should not be processed (a new ID will be assigned).

Required fields: Name, Key, Description (can be null if empty), App Context, Tags (can be null), Include List, Exclude List

If there are public segments that don't exist during the import, the compatibility status will be WARNING
UI will say that "At least one segment listed in this feature flag could not be found".

[ppratikcr7]

For backend:

the /validation api will expect the below format:

[{
fileName: string;
fileContent: string;
}]
This api will return the below format:

[{
fileName: string;
compatibilityType: FF_COMPATIBILITY_TYPE;
}]
enum FF_COMPATIBILITY_TYPE {
COMPATIBLE = 'compatible',
WARNING = 'warning',
INCOMPATIBLE = 'incompatible',
}
Based on the returned filenames and their compatibilityType, we can show the required message in the modal

[ppratikcr7]

@danoswaltCL @bcb37 @zackcl @amurphy-cl Just to confirm once, are we going to have the includeList and excludeList in import FF file? In the Add feature button next to the hamburger's import ff we only take the below details and allow to add or import the includeList and excludeList separately later.

{
"id": "be3ae74f-370a-4015-93f3-7761d16f8b11",
"name": "test",
"key": "FF_1",
"description": null,
"context": ["sub"],
"tags": [
"ff",
"test"
]
}

[amurphy-cl]

Yeah, only the constructed lists, not segments that are public.

[Yagnik56]

This bug is related to this issue.

[bcb37]

This works as expected. Moving to done

[ppratikcr7]

QA: Found a bug in this. If we try to import a duplicate feature flag which already exists, we show compatible label and we get a 500 error while clicking on import due to duplicate key constraint. I feel this was addressed and resolved for add feature flag but is remaining for import feature flag. @RidhamShah Can you please resolve this?

[Yagnik56]

I am working on this issue.

[ppratikcr7]

I will QA this

[ppratikcr7]

QA passed