Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment list should not be created for feature flag which doesn't exist #1918

Closed
Yagnik56 opened this issue Sep 10, 2024 · 4 comments · Fixed by #1948 or #1999
Closed

Segment list should not be created for feature flag which doesn't exist #1918

Yagnik56 opened this issue Sep 10, 2024 · 4 comments · Fixed by #1948 or #1999
Assignees
Labels
bug Something isn't working epic: feature flags priority: high High priority issue release 6.0

Comments

@Yagnik56
Copy link
Collaborator

Yagnik56 commented Sep 10, 2024

Issue:
In the add list, we can only select a segment if it exists with the same context as the feature flag, but while importing, we haven't applied any validation to make sure the segment list that is getting created already exists. This might apply to groups as well.

(For this case warning should be shown on import while creating but was not showing)

@RidhamShah
Copy link
Collaborator

A validation was also added to check multiple imports of duplicate files as the second file will try to create on key already used and throw an error.

@RidhamShah RidhamShah self-assigned this Sep 12, 2024
@RidhamShah RidhamShah linked a pull request Sep 13, 2024 that will close this issue
@Yagnik56 Yagnik56 assigned Yagnik56 and unassigned ppratikcr7 Sep 27, 2024
@Yagnik56
Copy link
Collaborator Author

Yagnik56 commented Sep 27, 2024

segment list should be ignored if it doesn't exist but here that's not happening and it is getting created.
Also, the segment list validation is just checking the id and attaching a list to a segment with a different context which shouldn't be allowed.

video1844997364.mp4

@Yagnik56 Yagnik56 moved this from QA to Refined ToDo in UpGrade Project Sep 27, 2024
@Yagnik56 Yagnik56 removed their assignment Sep 27, 2024
@Yagnik56 Yagnik56 reopened this Sep 27, 2024
@zackcl zackcl added the priority: high High priority issue label Sep 27, 2024
@RidhamShah RidhamShah assigned RidhamShah and unassigned Yagnik56 Oct 1, 2024
@RidhamShah RidhamShah linked a pull request Oct 1, 2024 that will close this issue
@ppratikcr7 ppratikcr7 moved this from Code Review to QA in UpGrade Project Oct 3, 2024
@ppratikcr7 ppratikcr7 changed the title segment list created for feature flag which doesn't exist Segment list should not be created for feature flag which doesn't exist Oct 4, 2024
@ppratikcr7 ppratikcr7 self-assigned this Oct 4, 2024
@ppratikcr7
Copy link
Collaborator

I will QA this

@ppratikcr7
Copy link
Collaborator

QA passed

@ppratikcr7 ppratikcr7 moved this from QA to Done in UpGrade Project Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working epic: feature flags priority: high High priority issue release 6.0
Projects
Status: Done
4 participants