Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect FeatureFlag Validator components #1831

Closed
RidhamShah opened this issue Aug 16, 2024 · 1 comment · Fixed by #1798
Closed

Incorrect FeatureFlag Validator components #1831

RidhamShah opened this issue Aug 16, 2024 · 1 comment · Fixed by #1798
Assignees
Labels

Comments

@RidhamShah
Copy link
Collaborator

Describe the bug
While working on this task, I identified an issue within the FeatureFlagValidator component. The validator treats featureFlagSegmentInclusion and featureFlagSegmentExclusion as objects containing segments as an array. However, in all other instances, we have defined featureFlagSegmentInclusion and featureFlagSegmentExclusion as arrays of objects, each containing segment, enabled, and listType.

Additionally, this validator is utilized in the create and update calls of the FeatureFlag, which do not include featureFlagSegmentInclusion or featureFlagSegmentExclusion (only name, key, context, and tags are present). This discrepancy is likely why the error has not surfaced, but it is crucial that we address this issue before it causes any disruptions.

Expected behavior
FeatureFlagInclusion and FeatureFlagExclusion should be an array of object containing Segment, enabled and listType

@bcb37
Copy link
Collaborator

bcb37 commented Sep 25, 2024

QA: passed. FF Inclusions and Exclusions are validated with the correct types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
3 participants