feat: Only lower definitions to Hugr if they are used #496
Conversation
…into implicit module
…mplicit-decorators
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
==========================================
+ Coverage 91.42% 91.55% +0.12%
==========================================
Files 59 60 +1
Lines 6064 6131 +67
==========================================
+ Hits 5544 5613 +69
+ Misses 520 518 -2 ☔ View full report in Codecov by Sentry. |
| CompiledLocals = dict[PlaceId, Wire] | ||
|
|
||
|
|
||
| class CompiledGlobals: |
There was a problem hiding this comment.
We should probably rename this, considering the class does way more than just holding the globals. See #497
mark-koch
force-pushed
the
feat/lower-used
branch
from
8fadb7c to
b65f837
Compare
…ix/notebook-imports
guppylang/compiler/core.py
Outdated
| """Compilation context containing all available definitions. | ||
|
|
||
| This context drives the Hugr lowering by keeping track of which definitions are | ||
| used when lowering the definitions provided via the `required` keyword. The |
There was a problem hiding this comment.
I dropped the required parameter, as we already have other ways to add to the worklist (and compile_outer) from outside (e.g. for nested functions) - __getitem__ does basically the same thing
| return self.compiled[def_id] | ||
|
|
||
| def _compile(self, defn: CheckedDef) -> CompiledDef: | ||
| if isinstance(defn, CompilableDef): |
There was a problem hiding this comment.
For another PR, I reckon we could probably get rid of CompilableDef by giving CheckedDefs an implementation of compile_outer that just returns self
| @@ -325,19 +326,19 @@ def compile(self) -> Package: | |||
| return self._compiled_hugr | |||
|
|
|||
| self.check() | |||
| checked_defs = self._imported_checked_defs | self._checked_defs | |||
There was a problem hiding this comment.
I removed def _compile_defs as the old code (removed here) was the only place calling it
guppylang/definition/common.py
Outdated
| @@ -72,6 +73,10 @@ def description(self) -> str: | |||
| a function, but got {description of this definition} instead". | |||
| """ | |||
|
|
|||
| def compile(self) -> Package: | |||
There was a problem hiding this comment.
this is missing coverage, is it unused? I will check
|
Fixing #470 is a nice side-effect, not the right reason to do this, but this is good anyway :) |
This was actually mentioned in the PR description:
....but given there are no uses in tests, I think that's fair, can become another PR with usage examples easily enough |
|
🤖 I have created a release *beep* *boop* --- ## [0.12.0](v0.11.0...v0.12.0) (2024-09-18) ### ⚠ BREAKING CHANGES * Pytket circuits loaded via a `py` expression no longer take ownership of the passed qubits. * Lists and function tensors are no longer available by default. `guppylang.enable_experimental_features()` must be called before compilation to enable them. * The `GuppyModule` argument is now optional for all decorators and no longer the first positional argument. Removed the explicit module objects `builtins`, `quantum`, and `angle`. * `quantum_functional` is now its own Guppy module and no longer implicitly comes with `quantum`. * Linear function arguments are now borrowed by default; removed the now redundant `@inout` annotation ### Features * Add functions to quantum module and make quantum_functional independent ([#494](#494)) ([0b0b1af](0b0b1af)) * Hide lists and function tensors behind experimental flag ([#501](#501)) ([c867f48](c867f48)) * Make linear types [@inout](https://github.com/inout) by default; add [@owned](https://github.com/owned) annotation ([#486](#486)) ([e900c96](e900c96)) * Only lower definitions to Hugr if they are used ([#496](#496)) ([cc2c8a4](cc2c8a4)) * Support implicit modules for all decorators and turn builtins into implicit module ([#476](#476)) ([cc8a424](cc8a424)) * Use inout for pytket circuits ([#500](#500)) ([a980ec2](a980ec2)) ### Bug Fixes * `angle` is now a struct and emitted as a rotation ([#485](#485)) ([992b138](992b138)) * Evade false positives for inout variable usage ([#493](#493)) ([6fdb5d6](6fdb5d6)) * Fix redefinition of structs ([#499](#499)) ([0b156e9](0b156e9)) * Initialise _checked in GuppyModule ([#491](#491)) ([3dd5dd3](3dd5dd3)), closes [#489](#489) * use correct array ops ([#503](#503)) ([720d8b8](720d8b8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Pulled out from #496. ~Needs tests.~ --------- Co-authored-by: Seyon Sivarajah <[email protected]>
Closes #434 and closes #470.