feat!: Use inout for pytket circuits (#500)

BREAKING CHANGE: Pytket circuits loaded via a `py` expression no longer take ownership of the passed qubits. --------- Co-authored-by: Alan Lawrence <[email protected]> Co-authored-by: Douglas Wilson <[email protected]>
CQCL · Sep 17, 2024 · a980ec2 · a980ec2
1 parent cc2c8a4
commit a980ec2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/guppylang/checker/expr_checker.py b/guppylang/checker/expr_checker.py
@@ -1124,10 +1124,8 @@ def python_value_to_guppy_type(v: Any, node: ast.expr, globals: Globals) -> Type
                             [], globals
                         )
                         return FunctionType(
-                            [FuncInput(qubit, InputFlags.NoFlags)] * v.n_qubits,
-                            row_to_type(
-                                [qubit] * v.n_qubits + [bool_type()] * v.n_bits
-                            ),
+                            [FuncInput(qubit, InputFlags.Inout)] * v.n_qubits,
+                            row_to_type([bool_type()] * v.n_bits),
                         )
                     except ImportError:
                         raise GuppyError(

diff --git a/guppylang/compiler/expr_compiler.py b/guppylang/compiler/expr_compiler.py
@@ -1,5 +1,4 @@
 import ast
-import json
 from collections.abc import Iterable, Iterator, Sequence
 from contextlib import contextmanager
 from typing import Any, TypeGuard, TypeVar
@@ -8,7 +7,7 @@
 import hugr.std.float
 import hugr.std.int
 import hugr.std.logic
-from hugr import Wire, ops
+from hugr import Hugr, Wire, ops
 from hugr import tys as ht
 from hugr import val as hv
 from hugr.build.cond_loop import Conditional
@@ -564,7 +563,7 @@ def python_value_to_hugr(v: Any, exp_ty: Type) -> hv.Value | None:
                         Tk2Circuit,
                     )
 
-                    circ = json.loads(Tk2Circuit(v).to_hugr_json())  # type: ignore[attr-defined, unused-ignore]
+                    circ = Hugr.load_json(Tk2Circuit(v).to_hugr_json())  # type: ignore[attr-defined, unused-ignore]
                     return hv.Function(circ)
             except ImportError:
                 pass