feat!: Hide lists and function tensors behind experimental flag #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
==========================================
- Coverage 91.99% 91.52% -0.48%
==========================================
Files 59 60 +1
Lines 5923 6109 +186
==========================================
+ Hits 5449 5591 +142
- Misses 474 518 +44 ☔ View full report in Codecov by Sentry. |
acl-cqc
approved these changes
Sep 16, 2024
guppylang/checker/expr_checker.py
Outdated
| @@ -990,6 +996,15 @@ def instantiate_poly(node: ast.expr, ty: FunctionType, inst: Inst) -> ast.expr: | |||
| return with_type(ty, node) | |||
|
|
|||
|
|
|||
| def check_function_tensors_enabled(node: ast.expr | None = None) -> None: | |||
There was a problem hiding this comment.
nit: I wonder if the two check_xxx_enabled should live together in experimental.py
guppylang/checker/expr_checker.py
Outdated
| def check_function_tensors_enabled(node: ast.expr | None = None) -> None: | ||
| if not guppylang.experimental.EXPERIMENTAL_FEATURES_ENABLED: | ||
| raise GuppyError( | ||
| "Function tensors are an experimental feature. Call " |
There was a problem hiding this comment.
Maybe Use would be better than Call ?
guppylang/tys/builtin.py
Outdated
| def check_lists_enabled(loc: AstNode | None = None) -> None: | ||
| if not guppylang.experimental.EXPERIMENTAL_FEATURES_ENABLED: | ||
| raise GuppyError( | ||
| "Lists are an experimental feature and not fully supported yet. Call " |
There was a problem hiding this comment.
ditto*2 (Call -> Use, move into experimental.py ?)
|
Changes enacted. I think even "experimental features" would be good to have tests but this is better than simply not feature-flagging them ;) so merging... |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
🤖 I have created a release *beep* *boop* --- ## [0.12.0](v0.11.0...v0.12.0) (2024-09-18) ### ⚠ BREAKING CHANGES * Pytket circuits loaded via a `py` expression no longer take ownership of the passed qubits. * Lists and function tensors are no longer available by default. `guppylang.enable_experimental_features()` must be called before compilation to enable them. * The `GuppyModule` argument is now optional for all decorators and no longer the first positional argument. Removed the explicit module objects `builtins`, `quantum`, and `angle`. * `quantum_functional` is now its own Guppy module and no longer implicitly comes with `quantum`. * Linear function arguments are now borrowed by default; removed the now redundant `@inout` annotation ### Features * Add functions to quantum module and make quantum_functional independent ([#494](#494)) ([0b0b1af](0b0b1af)) * Hide lists and function tensors behind experimental flag ([#501](#501)) ([c867f48](c867f48)) * Make linear types [@inout](https://github.com/inout) by default; add [@owned](https://github.com/owned) annotation ([#486](#486)) ([e900c96](e900c96)) * Only lower definitions to Hugr if they are used ([#496](#496)) ([cc2c8a4](cc2c8a4)) * Support implicit modules for all decorators and turn builtins into implicit module ([#476](#476)) ([cc8a424](cc8a424)) * Use inout for pytket circuits ([#500](#500)) ([a980ec2](a980ec2)) ### Bug Fixes * `angle` is now a struct and emitted as a rotation ([#485](#485)) ([992b138](992b138)) * Evade false positives for inout variable usage ([#493](#493)) ([6fdb5d6](6fdb5d6)) * Fix redefinition of structs ([#499](#499)) ([0b156e9](0b156e9)) * Initialise _checked in GuppyModule ([#491](#491)) ([3dd5dd3](3dd5dd3)), closes [#489](#489) * use correct array ops ([#503](#503)) ([720d8b8](720d8b8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #437.
BREAKING CHANGE: Lists and function tensors are no longer available by default.
guppylang.enable_experimental_features()must be called before compilation to enable them.