Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix implicit imports in notebooks #495

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

mark-koch
Copy link
Collaborator

Fixes #490

@mark-koch mark-koch requested a review from a team as a code owner September 13, 2024 22:07
@mark-koch mark-koch requested review from ss2165 and removed request for a team September 13, 2024 22:07
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.86207% with 7 lines in your changes missing coverage. Please review.

Project coverage is 91.41%. Comparing base (f24183d) to head (f9aaaa9).

Files with missing lines Patch % Lines
guppylang/ipython_inspect.py 33.33% 4 Missing ⚠️
guppylang/decorator.py 86.95% 3 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           feat/implicit-decorators     #495      +/-   ##
============================================================
- Coverage                     91.51%   91.41%   -0.10%     
============================================================
  Files                            59       59              
  Lines                          6044     6059      +15     
============================================================
+ Hits                           5531     5539       +8     
- Misses                          513      520       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@doug-q doug-q merged commit fc29e84 into feat/implicit-decorators Sep 16, 2024
2 checks passed
@doug-q doug-q deleted the fix/notebook-imports branch September 16, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants