Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log activities from subscriptions used in an MLZ deployment into the Operations log analytics workspace #412

Merged
merged 15 commits into from
Sep 16, 2021

Conversation

shawngib
Copy link
Member

@shawngib shawngib commented Sep 14, 2021

Description

Adds a diagnostic setting that pushes logs from activity logging into the operations RG's log analytics workspace. This is a subscription level deployment so it hangs around after deleting RG's and will need to be deleted.

Issue reference

The issue this PR will close: #373

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback re: consistent naming like ops => operations and ident => identity. Naming these things uniformly makes for easier refactors in the future.

src/bicep/modules/centralLogging.bicep Outdated Show resolved Hide resolved
src/bicep/modules/policyAssignment.bicep Outdated Show resolved Hide resolved
src/bicep/mlz.bicep Outdated Show resolved Hide resolved
src/bicep/mlz.bicep Outdated Show resolved Hide resolved
src/bicep/mlz.bicep Outdated Show resolved Hide resolved
src/bicep/mlz.bicep Outdated Show resolved Hide resolved
src/bicep/mlz.bicep Outdated Show resolved Hide resolved
src/bicep/mlz.bicep Outdated Show resolved Hide resolved
src/bicep/mlz.bicep Outdated Show resolved Hide resolved
src/bicep/modules/policyAssignment.bicep Outdated Show resolved Hide resolved
Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification on the deployment names at the subscription scope. That makes sense. If we could standardize on deploy-<hub/identity/operations/sharedServices>-activity-logging that'd be helpful 👍

src/bicep/mlz.bicep Outdated Show resolved Hide resolved
src/bicep/mlz.bicep Outdated Show resolved Hide resolved
src/bicep/mlz.bicep Outdated Show resolved Hide resolved
src/bicep/mlz.bicep Outdated Show resolved Hide resolved
src/bicep/mlz.bicep Outdated Show resolved Hide resolved
src/bicep/mlz.bicep Outdated Show resolved Hide resolved
shawngib and others added 6 commits September 15, 2021 12:05
operations module naming

Co-authored-by: Glenn Musa <[email protected]>
module naming convention update

Co-authored-by: Glenn Musa <[email protected]>
@glennmusa glennmusa changed the title Correctly pushing activity diagnostic settings. log activities from subscriptions used in an MLZ deployment into the Operations log analytics workspace Sep 15, 2021
@glennmusa
Copy link
Contributor

Awesome! This all deployed and seemed to be working in my manual deployment.

I have a suggestion to merge into your work in #414 for naming things at the root module instead of in the component module. If you want to take a look, and if it's a good idea, merge it back into this branch?

Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shawngib! 👍

@glennmusa glennmusa merged commit 77462d0 into bicep Sep 16, 2021
@glennmusa glennmusa deleted the shawngib/sg-add-bicep-activity-logging-again branch September 16, 2021 13:22
Breanna-Stryker added a commit that referenced this pull request Sep 17, 2021
* prefer local backends for terraform

* add a Bicep Azure Sentinel module (#385)

* Remove Client/Client Secret/Tenant Vars from Terraform Templates

Co-authored-by: Bree Stryker <[email protected]>

* add workflows to lint and build .bicep modules (#400)

* disable verbose lint output (#402)

* optionally deploy built-in Policy Initiatives for NIST 800-53, CMMC Level 3, or DOD IL5 (#397)

* log activities from subscriptions used in a deployment into the Operations log analytics workspace (#412)

* optionally deploy Azure Bastion Host from the base deployment (#406)

Co-authored-by: Vidya Bala <[email protected]>
Co-authored-by: Bree Stryker <[email protected]>
Co-authored-by: Glenn Musa <[email protected]>
Co-authored-by: Shawn Gibbs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable diagnostic logging of Azure Activity to central (T1) log analytics workspace
2 participants