add a Bicep Azure Sentinel module #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennmusa
changed the title
glennmusa
suggested changes
Sep 2, 2021
There was a problem hiding this comment.
Thanks @vidyambala! Was able to get this working with some changes documented in this review.
|
Updated the module with recommendation. |
glennmusa
suggested changes
Sep 3, 2021
filename change in VS not reflecting in GitHub
glennmusa
suggested changes
Sep 7, 2021
Co-authored-by: Glenn Musa <[email protected]>
glennmusa
approved these changes
Sep 7, 2021
Breanna-Stryker
added a commit
that referenced
this pull request
Sep 17, 2021
* prefer local backends for terraform * add a Bicep Azure Sentinel module (#385) * Remove Client/Client Secret/Tenant Vars from Terraform Templates Co-authored-by: Bree Stryker <[email protected]> * add workflows to lint and build .bicep modules (#400) * disable verbose lint output (#402) * optionally deploy built-in Policy Initiatives for NIST 800-53, CMMC Level 3, or DOD IL5 (#397) * log activities from subscriptions used in a deployment into the Operations log analytics workspace (#412) * optionally deploy Azure Bastion Host from the base deployment (#406) Co-authored-by: Vidya Bala <[email protected]> Co-authored-by: Bree Stryker <[email protected]> Co-authored-by: Glenn Musa <[email protected]> Co-authored-by: Shawn Gibbs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Azure Sentinel resource deployment in TF converted to Bicep module.
Issue reference
The issue this PR will close: #359
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
shellcheck.vscode/extensions.json.)