Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diagnostic name with log analytics workspace name #414

Merged
merged 1 commit into from
Sep 16, 2021
Merged

diagnostic name with log analytics workspace name #414

merged 1 commit into from
Sep 16, 2021

Conversation

glennmusa
Copy link
Contributor

setting the diagnostic setting name from the root module instead of at the component module and the value to be explicitly what is being logged where instead of using the generated random name

@glennmusa glennmusa requested a review from shawngib September 15, 2021 20:57
@glennmusa glennmusa mentioned this pull request Sep 15, 2021
Merged
6 tasks
shawngib
shawngib approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@shawngib shawngib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense in this case to be more descriptive of what it will be used for.

@glennmusa glennmusa merged commit 0b5e4b3 into shawngib/sg-add-bicep-activity-logging-again Sep 16, 2021
@glennmusa glennmusa deleted the glenn/activityLogDiagnosticName branch September 16, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawngib shawngib shawngib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glennmusa @shawngib