Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FrontDoor - Updated HealthProbeSettings in test for WAF compliance - avm/res/network/front-door #1702

Merged
merged 8 commits into from
Apr 26, 2024

Conversation

rozkurt
Copy link
Contributor

@rozkurt rozkurt commented Apr 18, 2024

Description

fix - This PR is offering updated parameters for E2E scenario in order to help with testing WAF alignment of the module

Fixes #1603

-->

Pipeline Reference

Pipeline
avm.res.network.front-door

Type of Change

  • Update to CI Environment or utlities (Non-module effecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@rozkurt rozkurt requested a review from prjelesi April 18, 2024 12:39
@rozkurt rozkurt self-assigned this Apr 18, 2024
@rozkurt rozkurt requested review from a team as code owners April 18, 2024 12:39
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Apr 18, 2024
@rozkurt rozkurt changed the title Updated HealthProbeSettings with WAF Aligned parameters for E2E test … fix - Updated HealthProbeSettings with WAF Aligned parameters for E2E test … Apr 18, 2024
@rozkurt rozkurt changed the title fix - Updated HealthProbeSettings with WAF Aligned parameters for E2E test … fix: Updated HealthProbeSettings with WAF Aligned parameters for E2E test … Apr 18, 2024
@AlexanderSehr AlexanderSehr changed the title fix: Updated HealthProbeSettings with WAF Aligned parameters for E2E test … fix: FrontDoor - Updated HealthProbeSettings in test for WAF compliance Apr 18, 2024
@matebarabas matebarabas changed the title fix: FrontDoor - Updated HealthProbeSettings in test for WAF compliance fix: FrontDoor - Updated HealthProbeSettings in test for WAF compliance - avm/res/network/front-door Apr 18, 2024
@matebarabas matebarabas added Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Apr 18, 2024
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rozkurt and thanks for your contribution.
Would you be fine with setting up your testing environment and attach a pipeline badge proving the module validation succeeds?

@rozkurt rozkurt enabled auto-merge (squash) April 26, 2024 12:42
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@rozkurt rozkurt merged commit 494d8b6 into Azure:main Apr 26, 2024
4 checks passed
donk-msft pushed a commit to donk-msft/bicep-registry-modules that referenced this pull request Apr 29, 2024
…ce - `avm/res/network/front-door` (Azure#1702)

## Description

fix - This PR is offering updated parameters for E2E scenario in order
to help with testing WAF alignment of the module

Fixes Azure#1603


-->

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.network.front-door](https://github.com/rozkurt/bicep-registry-modules/actions/workflows/avm.res.network.front-door.yml/badge.svg?branch=AFD_WAF_Alignment)](https://github.com/rozkurt/bicep-registry-modules/actions/workflows/avm.res.network.front-door.yml)
|

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [ ] Azure Verified Module updates:
- [X] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [X] I'm sure there are no other open Pull Requests for the same
update/change
- [ ] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [ ] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to day with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

---------

Co-authored-by: Erika Gressi <[email protected]>
Co-authored-by: Recep Ozkurt <[email protected]>
@rozkurt rozkurt deleted the AFD_WAF_Alignment branch June 6, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failed pipeline] avm.res.network.front-door
4 participants