-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: FrontDoor - Updated HealthProbeSettings in test for WAF compliance - avm/res/network/front-door
#1702
Conversation
avm/res/network/front-door
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rozkurt and thanks for your contribution.
Would you be fine with setting up your testing environment and attach a pipeline badge proving the module validation succeeds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗
…ce - `avm/res/network/front-door` (Azure#1702) ## Description fix - This PR is offering updated parameters for E2E scenario in order to help with testing WAF alignment of the module Fixes Azure#1603 --> ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [![avm.res.network.front-door](https://github.com/rozkurt/bicep-registry-modules/actions/workflows/avm.res.network.front-door.yml/badge.svg?branch=AFD_WAF_Alignment)](https://github.com/rozkurt/bicep-registry-modules/actions/workflows/avm.res.network.front-door.yml) | ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [ ] Azure Verified Module updates: - [X] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [X] I'm sure there are no other open Pull Requests for the same update/change - [ ] I have run `Set-AVMModule` locally to generate the supporting module files. - [ ] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to day with the contribution guide at https://aka.ms/avm/contribute/bicep --> --------- Co-authored-by: Erika Gressi <[email protected]> Co-authored-by: Recep Ozkurt <[email protected]>
Description
fix - This PR is offering updated parameters for E2E scenario in order to help with testing WAF alignment of the module
Fixes #1603
-->
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.