Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FrontDoor - Updated HealthProbeSettings in test for WAF compliance - avm/res/network/front-door #1702

Merged
merged 8 commits into from
Apr 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions avm/res/network/front-door/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -639,10 +639,10 @@ module frontDoor 'br/public:avm/res/network/front-door:<version>' = {
{
name: 'heathProbe'
properties: {
enabledState: ''
healthProbeMethod: ''
enabledState: 'Enabled'
healthProbeMethod: 'HEAD'
intervalInSeconds: 60
path: '/'
path: '/healthz'
protocol: 'Https'
}
}
Expand Down Expand Up @@ -765,10 +765,10 @@ module frontDoor 'br/public:avm/res/network/front-door:<version>' = {
{
"name": "heathProbe",
"properties": {
"enabledState": "",
"healthProbeMethod": "",
"enabledState": "Enabled",
"healthProbeMethod": "HEAD",
"intervalInSeconds": 60,
"path": "/",
"path": "/healthz",
"protocol": "Https"
}
}
Expand Down
4 changes: 2 additions & 2 deletions avm/res/network/front-door/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "11688367630078848691"
"version": "0.26.170.59819",
"templateHash": "10103314410755472523"
},
"name": "Azure Front Doors",
"description": "This module deploys an Azure Front Door.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ resource resourceGroup 'Microsoft.Resources/resourceGroups@2021-04-01' = {
}

// Diagnostics
// ===========
// ============
module diagnosticDependencies '../../../../../../utilities/e2e-template-assets/templates/diagnostic.dependencies.bicep' = {
scope: resourceGroup
name: '${uniqueString(deployment().name, resourceLocation)}-diagnosticDependencies'
Expand Down Expand Up @@ -99,10 +99,10 @@ module testDeployment '../../../main.bicep' = [
{
name: 'heathProbe'
properties: {
enabledState: ''
healthProbeMethod: ''
enabledState: 'Enabled'
eriqua marked this conversation as resolved.
Show resolved Hide resolved
healthProbeMethod: 'HEAD'
eriqua marked this conversation as resolved.
Show resolved Hide resolved
intervalInSeconds: 60
path: '/'
path: '/healthz'
protocol: 'Https'
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ spec:
# Azure App Service
- Azure.AppService.WebProbe # Supressed as the probe path is specific to the app
- Azure.AppService.WebProbePath # Supressed as the probe path is specific to the app
# Azure Front Door
- Azure.FrontDoor.Probe # Supressed as the probe is being provided as parameter and we are not able to enforce as default value
- Azure.FrontDoor.ProbeMethod # Supressed as the probe method is being provided as parameter and we are not able to enforce as default value
- Azure.FrontDoor.ProbePath # Supressed as the probe path is being provided as parameter and we are not able to enforce as default value
if:
name: "."
contains:
Expand Down