Skip to content

Commit

Permalink
fix: FrontDoor - Updated HealthProbeSettings in test for WAF complian…
Browse files Browse the repository at this point in the history
…ce - `avm/res/network/front-door` (Azure#1702)

## Description

fix - This PR is offering updated parameters for E2E scenario in order
to help with testing WAF alignment of the module

Fixes Azure#1603


-->

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.network.front-door](https://github.com/rozkurt/bicep-registry-modules/actions/workflows/avm.res.network.front-door.yml/badge.svg?branch=AFD_WAF_Alignment)](https://github.com/rozkurt/bicep-registry-modules/actions/workflows/avm.res.network.front-door.yml)
|

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [ ] Azure Verified Module updates:
- [X] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [X] I'm sure there are no other open Pull Requests for the same
update/change
- [ ] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [ ] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to day with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

---------

Co-authored-by: Erika Gressi <[email protected]>
Co-authored-by: Recep Ozkurt <[email protected]>
  • Loading branch information
3 people authored and DonKoning committed Apr 29, 2024
1 parent fc5473b commit 68303db
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 12 deletions.
12 changes: 6 additions & 6 deletions avm/res/network/front-door/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -639,10 +639,10 @@ module frontDoor 'br/public:avm/res/network/front-door:<version>' = {
{
name: 'heathProbe'
properties: {
enabledState: ''
healthProbeMethod: ''
enabledState: 'Enabled'
healthProbeMethod: 'HEAD'
intervalInSeconds: 60
path: '/'
path: '/healthz'
protocol: 'Https'
}
}
Expand Down Expand Up @@ -765,10 +765,10 @@ module frontDoor 'br/public:avm/res/network/front-door:<version>' = {
{
"name": "heathProbe",
"properties": {
"enabledState": "",
"healthProbeMethod": "",
"enabledState": "Enabled",
"healthProbeMethod": "HEAD",
"intervalInSeconds": 60,
"path": "/",
"path": "/healthz",
"protocol": "Https"
}
}
Expand Down
4 changes: 2 additions & 2 deletions avm/res/network/front-door/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "11688367630078848691"
"version": "0.26.170.59819",
"templateHash": "10103314410755472523"
},
"name": "Azure Front Doors",
"description": "This module deploys an Azure Front Door.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ resource resourceGroup 'Microsoft.Resources/resourceGroups@2021-04-01' = {
}

// Diagnostics
// ===========
// ============
module diagnosticDependencies '../../../../../../utilities/e2e-template-assets/templates/diagnostic.dependencies.bicep' = {
scope: resourceGroup
name: '${uniqueString(deployment().name, resourceLocation)}-diagnosticDependencies'
Expand Down Expand Up @@ -99,10 +99,10 @@ module testDeployment '../../../main.bicep' = [
{
name: 'heathProbe'
properties: {
enabledState: ''
healthProbeMethod: ''
enabledState: 'Enabled'
healthProbeMethod: 'HEAD'
intervalInSeconds: 60
path: '/'
path: '/healthz'
protocol: 'Https'
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ spec:
# Azure App Service
- Azure.AppService.WebProbe # Supressed as the probe path is specific to the app
- Azure.AppService.WebProbePath # Supressed as the probe path is specific to the app
# Azure Front Door
- Azure.FrontDoor.Probe # Supressed as the probe is being provided as parameter and we are not able to enforce as default value
- Azure.FrontDoor.ProbeMethod # Supressed as the probe method is being provided as parameter and we are not able to enforce as default value
- Azure.FrontDoor.ProbePath # Supressed as the probe path is being provided as parameter and we are not able to enforce as default value
if:
name: "."
contains:
Expand Down

0 comments on commit 68303db

Please sign in to comment.