Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Failed pipeline] avm.res.network.front-door #1603

Closed
github-actions bot opened this issue Apr 7, 2024 · 5 comments · Fixed by #1702
Closed

[Failed pipeline] avm.res.network.front-door #1603

github-actions bot opened this issue Apr 7, 2024 · 5 comments · Fixed by #1702
Assignees
Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2024

Failed run: https://github.com/Azure/bicep-registry-modules/actions/runs/8565946707

@github-actions github-actions bot added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working labels Apr 7, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

Note

This label was added as per ITA06.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Apr 7, 2024
Copy link
Contributor Author

github-actions bot commented Apr 9, 2024

Copy link
Contributor Author

@rozkurt rozkurt removed the Needs: Triage 🔍 Maintainers need to triage still label Apr 11, 2024
@rozkurt
Copy link
Contributor

rozkurt commented Apr 11, 2024

@matebarabas sorry for belated response but I've started reviewing!

CC: @prjelesi

Copy link

rozkurt added a commit that referenced this issue Apr 26, 2024
…ce - `avm/res/network/front-door` (#1702)

## Description

fix - This PR is offering updated parameters for E2E scenario in order
to help with testing WAF alignment of the module

Fixes #1603


-->

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.network.front-door](https://github.com/rozkurt/bicep-registry-modules/actions/workflows/avm.res.network.front-door.yml/badge.svg?branch=AFD_WAF_Alignment)](https://github.com/rozkurt/bicep-registry-modules/actions/workflows/avm.res.network.front-door.yml)
|

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [ ] Azure Verified Module updates:
- [X] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [X] I'm sure there are no other open Pull Requests for the same
update/change
- [ ] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [ ] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to day with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

---------

Co-authored-by: Erika Gressi <[email protected]>
Co-authored-by: Recep Ozkurt <[email protected]>
donk-msft pushed a commit to donk-msft/bicep-registry-modules that referenced this issue Apr 29, 2024
…ce - `avm/res/network/front-door` (Azure#1702)

## Description

fix - This PR is offering updated parameters for E2E scenario in order
to help with testing WAF alignment of the module

Fixes Azure#1603


-->

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.network.front-door](https://github.com/rozkurt/bicep-registry-modules/actions/workflows/avm.res.network.front-door.yml/badge.svg?branch=AFD_WAF_Alignment)](https://github.com/rozkurt/bicep-registry-modules/actions/workflows/avm.res.network.front-door.yml)
|

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [ ] Azure Verified Module updates:
- [X] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [X] I'm sure there are no other open Pull Requests for the same
update/change
- [ ] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [ ] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to day with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

---------

Co-authored-by: Erika Gressi <[email protected]>
Co-authored-by: Recep Ozkurt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
None yet
2 participants