[core-client] Allow resettable streams #24049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timovv
requested review from
xirzec,
jeremymeng and
deyaaeldeen
as code owners
ghost
added
the
timovv
commented
Nov 30, 2022
| @@ -433,10 +433,11 @@ function serializeBasicTypes(typeName: string, objectName: string, value: any): | |||
| !(value instanceof ArrayBuffer) && | |||
| !ArrayBuffer.isView(value) && | |||
| // File objects count as a type of Blob, so we want to use instanceof explicitly | |||
| !((typeof Blob === "function" || typeof Blob === "object") && value instanceof Blob) | |||
| !((typeof Blob === "function" || typeof Blob === "object") && value instanceof Blob) && | |||
| objectType !== "function" | |||
There was a problem hiding this comment.
Not sure if we can make this check more specific in a meaningful way, but am definitely open to ideas.
|
API change check API changes are not detected in this pull request. |
deyaaeldeen
approved these changes
Nov 30, 2022
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Jun 27, 2023
[Hub Generated] Review request for Microsoft.MachineLearningServices to add version preview/2023-06-01-preview (Azure#24049) * Adds base for updating Microsoft.MachineLearningServices from version preview/2023-04-01-preview to version 2023-06-01-preview * Updates readme * Updates API version in new specs and examples * MFE 2023-06-01-preview staging (Azure#24051) * Updated mfe.json * Added package example * Updated custom-words.txt * Updated package examples * Added pattern retriction to resource name parameters * Fixed cross-api breaking changes * Fixed cross-api breaking changes * Added descriptions * Added description * Separate workspace rp swagger from mlc (Azure#24249) * separate workspace rp swagger from mlc * add missing parameter * Updated mfe.json descriptions for put 200 responses (Azure#24295) * update EnableNodePublicIp for computeInstance of MLC (Azure#24231) Co-authored-by: Bingchen Li <[email protected]> * Update workspaceRP swagger with automation result (Azure#24333) * Update workspace rp swagger with automation result rename pe definition to avoid conflict fix update PE name Update connection credential hide armid fix more things Fix enum issue fix polymorphism Update examples Update body name and example fix more issue update response body Fix Revert "file change" This reverts commit 4a1fdccf6eb22e1dda82d3acce8065fae171f422. file change Update swagger fix errors update format add example for connetion list secrets api run prettier * Fixing more issue * revert custom-words * run prettier * Update securityDefinitions * Revert operation id * Update description and summary. * fix prettier issue and add description * remove redundent object definition * fixing swagger issue revert PaginationParameter * Revert back to old file with only reorder for better compare * Revert "Revert back to old file with only reorder for better compare" This reverts commit 8feb7d84319124ff3a447daffef894da18ef0077. * Revert connection v2 tag issue * Add back delete op for network rule * Add back example for the removed API * Suppress header check caused by old design * fix delete rule in path * Update example error * Update delete rule api and remove suppression * Fixed merge conflicts in custom-words.txt (Azure#24532) --------- Co-authored-by: ZhidaLiu <[email protected]> Co-authored-by: libc16 <[email protected]> Co-authored-by: Bingchen Li <[email protected]> Co-authored-by: Wes Haggard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/core-clientDescribe the problem that is addressed by this PR
Support for resettable streams was added to
core-rest-pipelinesome time ago in #21013, but a corresponding change tocore-client's validation is also needed (see the issue: #24048)Provide a list of related PRs (if any)
uploadBlobanduploadManifest#24048