[web-pubsub-client/react] Export WebPubSubClientState type & Expose _state #24333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
WebPubSub
customer-reported
|
Thank you for your contribution gfortaine! We will review the pull request and get back to you soon. |
gfortaine
force-pushed
the
feat/web-pubsub-client/react
branch
2 times, most recently
from
6faec6e to
a6b39e7
Compare
|
@zackliu a really minor fix related to WebPubSubClientState for a forthcoming React hook we are working on. Indeed, it looks like a better approach to directly import WebPubSubClientState than duplicating it. By the way, it seems that we would also need to be able to access |
gfortaine
force-pushed
the
feat/web-pubsub-client/react
branch
2 times, most recently
from
19898b0 to
50b0725
Compare
gfortaine
changed the title
gfortaine
requested review from
bterlson,
xirzec,
jeremymeng and
vicancy
as code owners
gfortaine
force-pushed
the
feat/web-pubsub-client/react
branch
from
50b0725 to
fb29395
Compare
gfortaine
changed the title
gfortaine
changed the title
gfortaine
force-pushed
the
feat/web-pubsub-client/react
branch
from
0ed0d33 to
c5f2531
Compare
ghost
added
the
no-recent-activity
|
Hi @gfortaine. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
ghost
closed this
|
Hi @gfortaine. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass. |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Jun 27, 2023
[Hub Generated] Review request for Microsoft.MachineLearningServices to add version preview/2023-06-01-preview (Azure#24049) * Adds base for updating Microsoft.MachineLearningServices from version preview/2023-04-01-preview to version 2023-06-01-preview * Updates readme * Updates API version in new specs and examples * MFE 2023-06-01-preview staging (Azure#24051) * Updated mfe.json * Added package example * Updated custom-words.txt * Updated package examples * Added pattern retriction to resource name parameters * Fixed cross-api breaking changes * Fixed cross-api breaking changes * Added descriptions * Added description * Separate workspace rp swagger from mlc (Azure#24249) * separate workspace rp swagger from mlc * add missing parameter * Updated mfe.json descriptions for put 200 responses (Azure#24295) * update EnableNodePublicIp for computeInstance of MLC (Azure#24231) Co-authored-by: Bingchen Li <[email protected]> * Update workspaceRP swagger with automation result (Azure#24333) * Update workspace rp swagger with automation result rename pe definition to avoid conflict fix update PE name Update connection credential hide armid fix more things Fix enum issue fix polymorphism Update examples Update body name and example fix more issue update response body Fix Revert "file change" This reverts commit 4a1fdccf6eb22e1dda82d3acce8065fae171f422. file change Update swagger fix errors update format add example for connetion list secrets api run prettier * Fixing more issue * revert custom-words * run prettier * Update securityDefinitions * Revert operation id * Update description and summary. * fix prettier issue and add description * remove redundent object definition * fixing swagger issue revert PaginationParameter * Revert back to old file with only reorder for better compare * Revert "Revert back to old file with only reorder for better compare" This reverts commit 8feb7d84319124ff3a447daffef894da18ef0077. * Revert connection v2 tag issue * Add back delete op for network rule * Add back example for the removed API * Suppress header check caused by old design * fix delete rule in path * Update example error * Update delete rule api and remove suppression * Fixed merge conflicts in custom-words.txt (Azure#24532) --------- Co-authored-by: ZhidaLiu <[email protected]> Co-authored-by: libc16 <[email protected]> Co-authored-by: Bingchen Li <[email protected]> Co-authored-by: Wes Haggard <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR: (Applicable only to SDK release request PRs)
Checklists