[core-rest-pipeline] support resettable stream request body #21013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add support of the following request body types - `() => NodeJS.ReadableStream` for NodeJS - `() => ReadableStream<Uint8Array> for browser
ghost
added
the
jeremymeng
requested review from
bterlson,
HarshaNalluru,
sadasant and
timovv
as code owners
|
API changes have been detected in API changes - export declare type RequestBodyType = NodeJS.ReadableStream | ReadableStream<Uint8Array> | Blob | ArrayBuffer | ArrayBufferView | FormData | string | null;
+ export declare type RequestBodyType = NodeJS.ReadableStream | (() => NodeJS.ReadableStream) | ReadableStream<Uint8Array> | (() => ReadableStream<Uint8Array>) | Blob | ArrayBuffer | ArrayBufferView | FormData | string | null; |
xirzec
approved these changes
Mar 24, 2022
This was referenced Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support of the following request body types
() => NodeJS.ReadableStreamfor NodeJS() => ReadableStream<Uint8Array>for browserPackages impacted by this PR
core-rest-pipeline
Issues associated with this PR
#20831
Describe the problem that is addressed by this PR
We support this in core-http but not in core-rest-pipeline.