Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core-rest-pipeline] Support resettable streams #20831

Closed
xirzec opened this issue Mar 14, 2022 · 1 comment
Closed

[core-rest-pipeline] Support resettable streams #20831

xirzec opened this issue Mar 14, 2022 · 1 comment
Assignees
@jeremymeng
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.

Comments

@xirzec
Copy link
Member

xirzec commented Mar 14, 2022

Currently our request body takes NodeJS.ReadableStream | ReadableStream<Uint8Array> - but we should also support passing a resettable stream (i.e. () => ReadableStream)

This also helps reduce a gap from core-http migration
@xirzec xirzec added Client This issue points to a problem in the data-plane of the library. Azure.Core labels Mar 14, 2022
@jeremymeng jeremymeng self-assigned this Mar 23, 2022
@jeremymeng jeremymeng mentioned this issue Mar 24, 2022
Merged
@xirzec
Copy link
Member Author

xirzec commented Apr 11, 2022

Looks like this is resolved by @jeremymeng 's change

@xirzec xirzec closed this as completed Apr 11, 2022
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Sep 27, 2022
@jjaviercv-msft
CodeGen from PR 20831 in Azure/azure-rest-api-specs
067b015 
Add properties to ExpressRoute gateway resource types to allow custom… (Azure#20831)

* Add properties to ExpressRoute gateway resource types to allow customers to control traffic flow

* Fix JSON

* Fix issues.

Co-authored-by: Javier Colomer <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremymeng jeremymeng

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xirzec @jeremymeng