-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG FIX: Fixed HopLink properties: context should be a dictionary, uint32 from… #9868
Conversation
…at instead of int32
[Staging] Swagger Validation Report
🔄 |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-go - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
|
azure-sdk-for-js - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Can one of the admins verify this patch? |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
|
@@ -3397,10 +3397,10 @@ | |||
}, | |||
"context": { | |||
"readOnly": true, | |||
"type": "array", | |||
"description": "Provides additional context on the issue.", | |||
"items": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be a breaking change, could you explain why not use a new API version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, @lirenhe , it's a bug fix. SDK and CLI experience is broken because of it (type is deserialized incorrectly)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need IssueContext
? Can we remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, we can't. It is used in another place. It was there before this change
…into fix_kv_python_readme * 'master' of https://github.com/Azure/azure-rest-api-specs: (22 commits) Update DeletionRecovery Level (Azure#9895) Updating operations API to enable metrics via public metrics REST API. (Azure#9918) Xynoclafe/2020 06 version (Azure#9888) update java md (Azure#9923) Compute 2020-06-01 API version (Azure#9167) Merge Dev containerservice microsoft.container service 2020 06 01 (Azure#9914) new Batch Document Translation API Preview 1.0 (Azure#9218) 1. Add a property as required (Azure#9899) Operational insights delete wrong lines data export (Azure#9849) [SRP]Adding allowBlobPublicAccess and minimumTlsVersion property for June19 and April19 (Azure#9831) [Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2019-12-01 (Azure#9838) add Java to AVS (Azure#9855) LaMigrationDate (Azure#9882) change vmware client name to AVSClient (Azure#9863) Fix typo in common private links definition for actionsRequired (Azure#9727) Microsoft.Support RP documentation updates (Azure#9880) BUG FIX: Fixed HopLink properties: context should be a dictionary, uint32 from… (Azure#9868) Update ci-fix.md (Azure#9881) Update Attestation control plane swagger to include 2 new defaultprovider API (Azure#9819) update java readme digitaltwins (Azure#9878) ...
…nt32 from… (Azure#9868) * Fixed HopLink properties: context should be a dictionary, uint32 fromat instead of int32 * removed format for RoundTripTime
…at instead of int32
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.