Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new Batch Document Translation API Preview 1.0 #9218

Merged
merged 18 commits into from
Jun 22, 2020
Merged

new Batch Document Translation API Preview 1.0 #9218

merged 18 commits into from
Jun 22, 2020

Conversation

alexhcheng
Copy link
Contributor

@alexhcheng alexhcheng commented Apr 24, 2020 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@alexhcheng alexhcheng requested a review from yangyuan as a code owner April 24, 2020 20:20
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alexhcheng
Copy link
Contributor Author

I messed up my old PR when i tried to rebase my fork
#8810
I'll close that one and use this one instead.

@alexhcheng alexhcheng mentioned this pull request Apr 24, 2020
Closed
5 tasks
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 24, 2020 •
edited
Loading

azure-cli-extensions

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 24, 2020 •
edited
Loading

azure-sdk-for-trenton

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 24, 2020 •
edited
Loading

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 77830f2 with merge commit 71aa473. SDK Automation 13.0.17.20200619.4 
    [azure-cognitiveservices-translatortext][ChangeLog] WARNING: Failed to generate ChangeLog.
  • ⚠️azure-cognitiveservices-translatortext [View full logs]  [Release SDK Changes] 
    [build_conf] INFO:packaging_tools:Building template azure-cognitiveservices-translatortext
[build_conf] INFO:packaging_tools.conf:Build default conf for azure-cognitiveservices-translatortext
[build_conf] INFO:packaging_tools:Template done azure-cognitiveservices-translatortext
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
Not exact 2 reports found:
code_reports/latest/report.json
Not generating changelog.
[ChangeLog] WARNING: Failed to generate ChangeLog.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 24, 2020 •
edited
Loading

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 24, 2020 •
edited
Loading

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 24, 2020 •
edited
Loading

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 77830f2 with merge commit 71aa473. SDK Automation 13.0.17.20200619.4 
    Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/TranslatorTextClient.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/Translators.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/implementation/TranslatorTextClientImpl.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/implementation/TranslatorsImpl.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/implementation/package-info.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/BreakSentenceResultItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/BreakSentenceTextInput.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/DetectResultItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/DetectTextInput.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/DictionaryExampleResultItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/DictionaryExampleResultItemExamplesItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/DictionaryExampleTextInput.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/DictionaryLookupResultItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/DictionaryLookupResultItemTranslationsItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/DictionaryLookupResultItemTranslationsItemBackTranslationsItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/DictionaryLookupTextInput.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/ErrorMessage.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/ErrorMessageError.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/ErrorMessageException.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/LanguagesResult.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/LanguagesResultDictionary.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/LanguagesResultDictionaryLanguageCode.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/LanguagesResultDictionaryLanguageCodeTranslationsItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/LanguagesResultTranslation.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/LanguagesResultTranslationLanguageCode.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/LanguagesResultTransliteration.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/LanguagesResultTransliterationLanguageCode.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/LanguagesResultTransliterationLanguageCodeScriptsItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/LanguagesResultTransliterationLanguageCodeScriptsItemToScriptsItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/TranslateResultAllItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/TranslateResultAllItemDetectedLanguage.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/TranslateResultAllItemTranslationsItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/TranslateResultAllItemTranslationsItemAlignment.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/TranslateResultAllItemTranslationsItemSentLen.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/TranslateResultAllItemTranslationsItemSentLenSrcSentLenItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/TranslateResultAllItemTranslationsItemSentLenTransSentLenItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/TranslateResultAllItemTranslationsItemTransliteration.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/TranslateResultItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/TranslateResultItemTranslationItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/TranslateTextInput.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/TransliterateResultItem.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/TransliterateTextInput.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/models/package-info.java
/z/work/azure-sdk-for-java/cognitiveservices/data-plane/translatortext/src/main/java/com/microsoft/azure/cognitiveservices/translatortext/package-info.java

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Apr 24, 2020 •
edited
Loading

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

This was referenced Apr 24, 2020
Open
Closed
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@annelo-msft annelo-msft requested a review from johanste April 27, 2020 21:24
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alexhcheng alexhcheng requested a review from yangyuan May 5, 2020 20:22
@alexhcheng
Copy link
Contributor Author

@anuchandy this is ready to merge. thank you

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented May 20, 2020 •
edited
Loading

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request May 20, 2020
Closed
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

yangyuan
yangyuan reviewed May 20, 2020
View reviewed changes
...tion/cognitiveservices/data-plane/TranslatorText/preview/v1.0-preview.1/TranslatorBatch.json Outdated
}
],
"x-ms-parameterized-host": {
"hostTemplate": "{endpoint}/translator/text/document/v1.0-preview.1",
Copy link
Member

@yangyuan yangyuan May 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both hostTemplate and path have v1.0-preview.1. Looks suspicious.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. this is fixed now

yangyuan
yangyuan approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@yangyuan yangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File structure looks all right.
There are some details doesn't look right.
Please validate the SDK BEFORE merging this PR.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alexhcheng
Copy link
Contributor Author

hi @anuchandy this is ready to be merged. I fix the issue Yuan identified and I was able to successfully make request using the autorest csharp sdk.

@anuchandy anuchandy merged commit 71aa473 into Azure:master Jun 22, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 22, 2020 •
edited
Loading

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 22, 2020 •
edited
Loading

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Oct 5, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …
6511824 
…into fix_kv_python_readme

* 'master' of https://github.com/Azure/azure-rest-api-specs: (22 commits)
  Update DeletionRecovery Level (Azure#9895)
  Updating operations API to enable metrics via public metrics REST API. (Azure#9918)
  Xynoclafe/2020 06 version (Azure#9888)
  update java md (Azure#9923)
  Compute 2020-06-01 API version (Azure#9167)
  Merge Dev containerservice microsoft.container service 2020 06 01 (Azure#9914)
  new Batch Document Translation API Preview 1.0 (Azure#9218)
  1. Add a property as required (Azure#9899)
  Operational insights delete wrong lines data export (Azure#9849)
  [SRP]Adding allowBlobPublicAccess and minimumTlsVersion property for June19 and April19 (Azure#9831)
  [Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2019-12-01 (Azure#9838)
  add Java to AVS (Azure#9855)
  LaMigrationDate (Azure#9882)
  change vmware client name to AVSClient (Azure#9863)
  Fix typo in common private links definition for actionsRequired (Azure#9727)
  Microsoft.Support RP documentation updates (Azure#9880)
  BUG FIX: Fixed HopLink properties: context should be a dictionary, uint32 from… (Azure#9868)
  Update ci-fix.md (Azure#9881)
  Update Attestation control plane swagger to include 2 new defaultprovider API (Azure#9819)
  update java readme digitaltwins (Azure#9878)
  ...
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
@alexhcheng @00Kai0
new Batch Document Translation API Preview 1.0 (Azure#9218)
e41489c 
* Merged from master again

* updated swagger based on API review feedback

* updated post

* fix spelling

* added x-ms-pageable, x-ms-error-response, x-ms-long-running

* fix enum

* remove long running operation

* bug in sdk go generation

* Revert "bug in sdk go generation"

This reverts commit 025b875.

* remove x-ms-pageable

* addressed changes

* fix casing for x-ms-parameterized-host

* fix endpoint in examples

* move everything in the same SDK readme file

* change path to v1.0_preview.1

* fix path

* dummy change to restart merge for a 502 server error on sdk generation

* fix batch json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annelo-msft annelo-msft annelo-msft left review comments

@yangyuan yangyuan yangyuan approved these changes

@anuchandy anuchandy anuchandy approved these changes

@johanste johanste Awaiting requested review from johanste

Assignees

@anuchandy anuchandy

Labels
AzureAPIBoardSignedOff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexhcheng @azuresdkci @anuchandy @yangyuan @johanste @annelo-msft