[Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2019-12-01 #9838

novinc · 2020-06-15T18:42:32Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for AME onboarding.
Validation tools have been run on swagger spec(s) updated and errors have all been fixed with this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.

adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Please follow the link to find more details on PR review process.

…e/2018-10-01 to version 2019-12-01

This reverts commit 6715de3.

openapi-pipeline-app · 2020-06-15T18:42:37Z

[Staging] Swagger Validation Report

️️✔️~[Staging] BreakingChange [Detail]

_{Posted by Swagger Pipeline}

azure-pipelines · 2020-06-15T18:42:49Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-06-15T18:44:21Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 26e10fd with merge commit ae8d69c. SDK Automation 13.0.17.20200619.4

️✔️@azure/arm-containerinstance [View full logs] [Release SDK Changes]

azure-arm-containerinstance-5.4.0.tgz

Only show 100 items here, please refer to log for details.

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/containerInstanceManagementClient.js → ./dist/arm-containerinstance.js...
[npmPack] created ./dist/arm-containerinstance.js in 351ms
[npmPack] npm notice 
[npmPack] npm notice package: @azure/[email protected]
[npmPack] npm notice === Tarball Contents === 
[npmPack] npm notice 98.3kB  dist/arm-containerinstance.js                        
[npmPack] npm notice 33.5kB  dist/arm-containerinstance.min.js                    
[npmPack] npm notice 16.3kB  esm/operations/containerGroups.js                    
[npmPack] npm notice 1.1kB   esm/models/containerGroupsMappers.js                 
[npmPack] npm notice 2.0kB   esm/containerInstanceManagementClient.js             
[npmPack] npm notice 2.7kB   esm/containerInstanceManagementClientContext.js      
[npmPack] npm notice 3.5kB   esm/operations/containers.js                         
[npmPack] npm notice 490B    esm/models/containersMappers.js                      
[npmPack] npm notice 345B    esm/models/index.js                                  
[npmPack] npm notice 474B    esm/operations/index.js                              
[npmPack] npm notice 4.9kB   esm/operations/location.js                           
[npmPack] npm notice 540B    esm/models/locationMappers.js                        
[npmPack] npm notice 47.0kB  esm/models/mappers.js                                
[npmPack] npm notice 2.3kB   esm/operations/operations.js                         
[npmPack] npm notice 455B    esm/models/operationsMappers.js                      
[npmPack] npm notice 2.2kB   esm/models/parameters.js                             
[npmPack] npm notice 1.0kB   rollup.config.js                                     
[npmPack] npm notice 1.7kB   package.json                                         
[npmPack] npm notice 457B    tsconfig.json                                        
[npmPack] npm notice 191.9kB dist/arm-containerinstance.js.map                    
[npmPack] npm notice 29.3kB  dist/arm-containerinstance.min.js.map                
[npmPack] npm notice 4.5kB   esm/operations/containerGroups.d.ts.map              
[npmPack] npm notice 7.9kB   esm/operations/containerGroups.js.map                
[npmPack] npm notice 577B    esm/models/containerGroupsMappers.d.ts.map           
[npmPack] npm notice 590B    esm/models/containerGroupsMappers.js.map             
[npmPack] npm notice 749B    esm/containerInstanceManagementClient.d.ts.map       
[npmPack] npm notice 903B    esm/containerInstanceManagementClient.js.map         
[npmPack] npm notice 533B    esm/containerInstanceManagementClientContext.d.ts.map
[npmPack] npm notice 1.4kB   esm/containerInstanceManagementClientContext.js.map  
[npmPack] npm notice 1.5kB   esm/operations/containers.d.ts.map                   
[npmPack] npm notice 1.9kB   esm/operations/containers.js.map                     
[npmPack] npm notice 228B    esm/models/containersMappers.d.ts.map                
[npmPack] npm notice 241B    esm/models/containersMappers.js.map                  
[npmPack] npm notice 14.1kB  esm/models/index.d.ts.map                            
[npmPack] npm notice 202B    esm/operations/index.d.ts.map                        
[npmPack] npm notice 126B    esm/models/index.js.map                              
[npmPack] npm notice 217B    esm/operations/index.js.map                          
[npmPack] npm notice 2.2kB   esm/operations/location.d.ts.map                     
[npmPack] npm notice 3.1kB   esm/operations/location.js.map                       
[npmPack] npm notice 264B    esm/models/locationMappers.d.ts.map                  
[npmPack] npm notice 277B    esm/models/locationMappers.js.map                    
[npmPack] npm notice 2.5kB   esm/models/mappers.d.ts.map                          
[npmPack] npm notice 26.5kB  esm/models/mappers.js.map                            
[npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map                   
[npmPack] npm notice 1.4kB   esm/operations/operations.js.map                     
[npmPack] npm notice 215B    esm/models/operationsMappers.d.ts.map                
[npmPack] npm notice 228B    esm/models/operationsMappers.js.map                  
[npmPack] npm notice 588B    esm/models/parameters.d.ts.map                       
[npmPack] npm notice 1.7kB   esm/models/parameters.js.map                         
[npmPack] npm notice 3.3kB   README.md                                            
[npmPack] npm notice 14.5kB  esm/operations/containerGroups.d.ts                  
[npmPack] npm notice 25.7kB  src/operations/containerGroups.ts                    
[npmPack] npm notice 778B    esm/models/containerGroupsMappers.d.ts               
[npmPack] npm notice 1.1kB   src/models/containerGroupsMappers.ts                 
[npmPack] npm notice 1.4kB   esm/containerInstanceManagementClient.d.ts           
[npmPack] npm notice 1.9kB   src/containerInstanceManagementClient.ts             
[npmPack] npm notice 967B    esm/containerInstanceManagementClientContext.d.ts    
[npmPack] npm notice 2.5kB   src/containerInstanceManagementClientContext.ts      
[npmPack] npm notice 4.1kB   esm/operations/containers.d.ts                       
[npmPack] npm notice 7.2kB   src/operations/containers.ts                         
[npmPack] npm notice 180B    esm/models/containersMappers.d.ts                    
[npmPack] npm notice 456B    src/models/containersMappers.ts                      
[npmPack] npm notice 38.4kB  esm/models/index.d.ts                                
[npmPack] npm notice 158B    esm/operations/index.d.ts                            
[npmPack] npm notice 36.6kB  src/models/index.ts                                  
[npmPack] npm notice 442B    src/operations/index.ts                              
[npmPack] npm notice 5.6kB   esm/operations/location.d.ts                         
[npmPack] npm notice 10.7kB  src/operations/location.ts                           
[npmPack] npm notice 230B    esm/models/locationMappers.d.ts                      
[npmPack] npm notice 516B    src/models/locationMappers.ts                        
[npmPack] npm notice 3.3kB   esm/models/mappers.d.ts                              
[npmPack] npm notice 36.9kB  src/models/mappers.ts                                
[npmPack] npm notice 2.1kB   esm/operations/operations.d.ts                       
[npmPack] npm notice 4.2kB   src/operations/operations.ts                         
[npmPack] npm notice 145B    esm/models/operationsMappers.d.ts                    
[npmPack] npm notice 419B    src/models/operationsMappers.ts                      
[npmPack] npm notice 673B    esm/models/parameters.d.ts                           
[npmPack] npm notice 2.3kB   src/models/parameters.ts                             
[npmPack] npm notice 1.1kB   LICENSE.txt                                          
[npmPack] npm notice === Tarball Details === 
[npmPack] npm notice name:          @azure/arm-containerinstance            
[npmPack] npm notice version:       5.4.0                                   
[npmPack] npm notice filename:      azure-arm-containerinstance-5.4.0.tgz   
[npmPack] npm notice package size:  82.9 kB                                 
[npmPack] npm notice unpacked size: 723.9 kB                                
[npmPack] npm notice shasum:        60c8ea6dd829c726bfaa3e0b6debab107d3118fe
[npmPack] npm notice integrity:     sha512-MU6Z2mqnjruQ/[...]AoBLAb1g/h1Ow==

openapi-sdkautomation · 2020-06-15T18:44:22Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-15T18:44:23Z

azure-sdk-for-python - Release

- Breaking Change detected in SDK

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 26e10fd with merge commit ae8d69c. SDK Automation 13.0.17.20200619.4

⚠️azure-mgmt-containerinstance [View full logs] [Release SDK Changes] Breaking Change Detected

[build_conf] INFO:packaging_tools:Building template azure-mgmt-containerinstance
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-containerinstance
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 24.781% size of original (original: 26298 chars, delta: 6517 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model ContainerGroup has a new parameter encryption_properties
[ChangeLog]   - Model ContainerGroup has a new parameter sku
[ChangeLog]   - Model ContainerGroup has a new parameter init_containers
[ChangeLog]   - Added operation group ContainersOperations
[ChangeLog]   - Added operation group LocationOperations
[ChangeLog] 
[ChangeLog] **Breaking changes**
[ChangeLog] 
[ChangeLog]   - Model CachedImages no longer has parameter id
[ChangeLog]   - Removed operation group ContainerGroupUsageOperations
[ChangeLog]   - Removed operation group ContainerOperations
[ChangeLog]   - Removed operation group ServiceAssociationLinkOperations

openapi-sdkautomation · 2020-06-15T18:44:23Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 26e10fd with merge commit ae8d69c. SDK Automation 13.0.17.20200619.4
️✔️containerinstance/mgmt/2018-04-01 [View full logs] [Release SDK Changes]
- containerinstance.mgmt.2018-04-01.zip
️✔️containerinstance/mgmt/2018-06-01 [View full logs] [Release SDK Changes]
- containerinstance.mgmt.2018-06-01.zip
️✔️containerinstance/mgmt/2018-09-01 [View full logs] [Release SDK Changes]
- containerinstance.mgmt.2018-09-01.zip
️✔️containerinstance/mgmt/2018-10-01 [View full logs] [Release SDK Changes]
- containerinstance.mgmt.2018-10-01.zip
️✔️containerinstance/mgmt/2019-12-01 [View full logs] [Release SDK Changes]
- containerinstance.mgmt.2019-12-01.zip
️✔️preview/containerinstance/mgmt/2017-08-01-preview [View full logs] [Release SDK Changes]
- preview.containerinstance.mgmt.2017-08-01-preview.zip
️✔️preview/containerinstance/mgmt/2017-10-01-preview [View full logs] [Release SDK Changes]
- preview.containerinstance.mgmt.2017-10-01-preview.zip
️✔️preview/containerinstance/mgmt/2017-12-01-preview [View full logs] [Release SDK Changes]
- preview.containerinstance.mgmt.2017-12-01-preview.zip
️✔️preview/containerinstance/mgmt/2018-02-01-preview [View full logs] [Release SDK Changes]
- preview.containerinstance.mgmt.2018-02-01-preview.zip

openapi-sdkautomation · 2020-06-15T18:44:25Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-15T18:44:26Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-15T18:44:28Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 26e10fd with merge commit ae8d69c. SDK Automation 13.0.17.20200619.4

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.ContainerInstance [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.ContainerInstance.3.0.0.nupkg
- Microsoft.Azure.Management.ContainerInstance.3.0.0.snupkg

openapi-sdkautomation · 2020-06-15T18:47:04Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 26e10fd with merge commit ae8d69c. SDK Automation 13.0.17.20200619.4
️✔️sdk/containerinstance/mgmt-v2017_08_01_preview [View full logs] [Release SDK Changes]
️✔️sdk/containerinstance/mgmt-v2017_10_01_preview [View full logs] [Release SDK Changes]
️✔️sdk/containerinstance/mgmt-v2017_12_01_preview [View full logs] [Release SDK Changes]
️✔️sdk/containerinstance/mgmt-v2018_02_01_preview [View full logs] [Release SDK Changes]
️✔️sdk/containerinstance/mgmt-v2018_04_01 [View full logs] [Release SDK Changes]
️✔️sdk/containerinstance/mgmt-v2018_10_01 [View full logs] [Release SDK Changes]
️✔️sdk/containerinstance/mgmt-v2019_12_01 [View full logs] [Release SDK Changes]

azuresdkci · 2020-06-15T19:00:55Z

Can one of the admins verify this patch?

azure-pipelines · 2020-06-18T00:23:55Z

Azure Pipelines successfully started running 1 pipeline(s).

chiragg4u

Changes looks good. Any reason for creating 2019-12-01 version? why note 2020-07-01?

novinc · 2020-06-20T01:28:06Z

We’ve had this api version for a while but never got around to actually releasing the spec/clients for it since it was punted in priority. We would have to make code changes to rename it so I kept the name.

chiragg4u

Approved.

novinc · 2020-06-20T01:48:32Z

Thanks, @fengzhou-msft could you merge this when you get the chance?

…into fix_kv_python_readme * 'master' of https://github.com/Azure/azure-rest-api-specs: (22 commits) Update DeletionRecovery Level (Azure#9895) Updating operations API to enable metrics via public metrics REST API. (Azure#9918) Xynoclafe/2020 06 version (Azure#9888) update java md (Azure#9923) Compute 2020-06-01 API version (Azure#9167) Merge Dev containerservice microsoft.container service 2020 06 01 (Azure#9914) new Batch Document Translation API Preview 1.0 (Azure#9218) 1. Add a property as required (Azure#9899) Operational insights delete wrong lines data export (Azure#9849) [SRP]Adding allowBlobPublicAccess and minimumTlsVersion property for June19 and April19 (Azure#9831) [Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2019-12-01 (Azure#9838) add Java to AVS (Azure#9855) LaMigrationDate (Azure#9882) change vmware client name to AVSClient (Azure#9863) Fix typo in common private links definition for actionsRequired (Azure#9727) Microsoft.Support RP documentation updates (Azure#9880) BUG FIX: Fixed HopLink properties: context should be a dictionary, uint32 from… (Azure#9868) Update ci-fix.md (Azure#9881) Update Attestation control plane swagger to include 2 new defaultprovider API (Azure#9819) update java readme digitaltwins (Azure#9878) ...

… version stable/2019-12-01 (Azure#9838)

novinc and others added 8 commits June 12, 2020 15:38

Adds base for updating Microsoft.ContainerInstance from version stabl…

44904e1

…e/2018-10-01 to version 2019-12-01

Updates readme

6f8c962

Updates API version in new specs and examples

4045c69

added the changes for the new api and fixed some examples

6715de3

Revert "added the changes for the new api and fixed some examples"

e6014e6

This reverts commit 6715de3.

added the changes for the new api and fixed some examples round 2

608f35a

remove id from cached image props

8c23313

add example for 200 delete

831d51e

novinc requested a review from samkreter as a code owner June 15, 2020 18:42

openapi-assignment-bot bot assigned fengzhou-msft Jun 15, 2020

novinc added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 15, 2020

novinc requested review from fengzhou-msft, RikkiGibson, lmazuel, akning-ms and ChenTanyi and removed request for samkreter and RikkiGibson June 16, 2020 22:47

updated readme files

26e10fd

openapi-sdkautomation bot mentioned this pull request Jun 18, 2020

[AutoPR sdk/containerinstance/mgmt-v2019_12_01] [Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2019-12-01 AzureSDKAutomation/azure-sdk-for-java#3338

Closed

fengzhou-msft approved these changes Jun 18, 2020

View reviewed changes

novinc requested review from shahabhijeet and ravbhatnagar and removed request for lmazuel, akning-ms, ChenTanyi and shahabhijeet June 19, 2020 22:48

chiragg4u reviewed Jun 20, 2020

View reviewed changes

chiragg4u approved these changes Jun 20, 2020

View reviewed changes

chiragg4u added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 20, 2020

fengzhou-msft merged commit ae8d69c into Azure:master Jun 20, 2020

novinc mentioned this pull request Jun 22, 2020

Update containerinstance client to the 2019-12-01 api Azure/azure-sdk-for-net#12906

Merged

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

[Hub Generated] Review request for Microsoft.ContainerInstance to add…

71f8e6b

… version stable/2019-12-01 (Azure#9838)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2019-12-01 #9838

[Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2019-12-01 #9838

novinc commented Jun 15, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jun 15, 2020 •

edited

Loading

azure-pipelines bot commented Jun 15, 2020

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading

azuresdkci commented Jun 15, 2020

azure-pipelines bot commented Jun 18, 2020

chiragg4u left a comment

novinc commented Jun 20, 2020

chiragg4u left a comment

novinc commented Jun 20, 2020

[Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2019-12-01 #9838

[Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2019-12-01 #9838

Conversation

novinc commented Jun 15, 2020 • edited Loading

Contribution checklist:

ARM API Review Checklist

openapi-pipeline-app bot commented Jun 15, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Jun 15, 2020

openapi-sdkautomation bot commented Jun 15, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Jun 15, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Jun 15, 2020 • edited Loading

azure-sdk-for-python - Release

- Breaking Change detected in SDK

openapi-sdkautomation bot commented Jun 15, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Jun 15, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

openapi-sdkautomation bot commented Jun 15, 2020 • edited Loading

Trenton Generation - Release

openapi-sdkautomation bot commented Jun 15, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Jun 15, 2020 • edited Loading

azure-sdk-for-java - Release

azuresdkci commented Jun 15, 2020

azure-pipelines bot commented Jun 18, 2020

chiragg4u left a comment

Choose a reason for hiding this comment

novinc commented Jun 20, 2020

chiragg4u left a comment

Choose a reason for hiding this comment

novinc commented Jun 20, 2020

novinc commented Jun 15, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 15, 2020 •

edited

Loading