Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG FIX: Fixed HopLink properties: context should be a dictionary, uint32 from… #9868

Merged
merged 2 commits into from
Jun 18, 2020
Merged

BUG FIX: Fixed HopLink properties: context should be a dictionary, uint32 from… #9868

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45cfe4c
Fixed HopLink properties: context should be a dictionary, uint32 from…
irrogozh Jun 17, 2020
d7968ec
removed format for RoundTripTime
irrogozh Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions ...fication/network/resource-manager/Microsoft.Network/stable/2020-05-01/networkWatcher.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3397,10 +3397,10 @@
},
"context": {
"readOnly": true,
"type": "array",
"description": "Provides additional context on the issue.",
"items": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a breaking change, could you explain why not use a new API version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, @lirenhe , it's a bug fix. SDK and CLI experience is broken because of it (type is deserialized incorrectly)

Copy link
Contributor

@mmyyrroonn mmyyrroonn Jun 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need IssueContext? Can we remove this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we can't. It is used in another place. It was there before this change

"$ref": "#/definitions/IssueContext"
"type": "object",
"description": "Provides additional context on links.",
"additionalProperties": {
"type": "string"
}
},
"resourceId": {
Expand All @@ -3416,19 +3416,16 @@
"roundTripTimeMin": {
"description": "Minimum roundtrip time in milliseconds.",
"readOnly": true,
"format": "int32",
"type": "integer"
},
"roundTripTimeAvg": {
"description": "Average roundtrip time in milliseconds.",
"readOnly": true,
"format": "int32",
"type": "integer"
},
"roundTripTimeMax": {
"description": "Maximum roundtrip time in milliseconds.",
"readOnly": true,
"format": "int32",
"type": "integer"
}
}
Expand Down