Review request for Microsoft.ContainerService to add version 2022-06-01 #19848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/2022-04-01 to version 2022-06-01
* Add NetworkPlugin none option to 2022-06-01 * improve description for none value
…19581) * remove useless directive * fix R4041
* GA AKS support for Dedicated Host Group * fit some format minor issue * add newline in end of files
* Defender updates * sample * remove old description
|
Hi, @FumingZhang Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @FumingZhang your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.6)] | new version | base version |
|---|---|---|
| managedClusters.json | 2022-06-01(84159c9) | 2022-04-01(main) |
| managedClusters.json | 2022-06-01(84159c9) | 2022-05-02(main) |
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
|
The new version is missing a definition that was found in the old version. Was 'ManagedClusterSecurityProfileAzureDefender' removed or renamed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2227:3 Old: Microsoft.ContainerService/stable/2022-04-01/managedClusters.json#L2221:3 |
|
The new version is missing a property found in the old version. Was 'azureDefender' renamed or removed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L5468:7 Old: Microsoft.ContainerService/stable/2022-04-01/managedClusters.json#L5426:7 |
The following breaking changes are detected by comparison with the latest preview version:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedClusters/{resourceName}/rotateServiceAccountSigningKeys' removed or restructured? Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L1399:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.ContainerService/managedclustersnapshots' removed or restructured? Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2305:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedclustersnapshots' removed or restructured? Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2344:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedclustersnapshots/{resourceName}' removed or restructured? Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2386:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.ContainerService/locations/{location}/trustedAccessRoles' removed or restructured? Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2572:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedClusters/{resourceName}/trustedAccessRoleBindings' removed or restructured? Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2614:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ContainerService/managedClusters/{resourceName}/trustedAccessRoleBindings/{trustedAccessRoleBindingName}' removed or restructured? Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2659:5 |
|
| The new version is missing a definition that was found in the old version. Was 'ManagedClusterOIDCIssuerProfile' removed or renamed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2227:3 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2800:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ManagedClusterIngressProfile' removed or renamed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2227:3 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2800:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ManagedClusterIngressProfileWebAppRouting' removed or renamed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2227:3 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2800:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ManagedClusterSecurityProfileWorkloadIdentity' removed or renamed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2227:3 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2800:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ManagedClusterStorageProfileBlobCSIDriver' removed or renamed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2227:3 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2800:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ManagedClusterSnapshot' removed or renamed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2227:3 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2800:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ManagedClusterSnapshotProperties' removed or renamed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2227:3 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2800:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ManagedClusterPropertiesForSnapshot' removed or renamed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2227:3 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2800:3 |
|
| The new version is missing a definition that was found in the old version. Was 'NetworkProfileForSnapshot' removed or renamed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2227:3 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2800:3 |
|
| The new version is missing a definition that was found in the old version. Was 'NetworkPlugin' removed or renamed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2227:3 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2800:3 |
|
| The new version is missing a definition that was found in the old version. Was 'NetworkPluginMode' removed or renamed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2227:3 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2800:3 |
|
| The new version is missing a definition that was found in the old version. Was 'NetworkPolicy' removed or renamed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2227:3 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2800:3 |
|
| The new version is missing a definition that was found in the old version. Was 'NetworkMode' removed or renamed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2227:3 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2800:3 |
|
| The new version is missing a definition that was found in the old version. Was 'LoadBalancerSku' removed or renamed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2227:3 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2800:3 |
|
| The new version is missing a definition that was found in the old version. Was 'CapacityReservationGroupID' removed or renamed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2227:3 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2800:3 |
|
| The new version is missing a definition that was found in the old version. Was 'TrustedAccessRoleBindingProperties' removed or renamed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2227:3 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2800:3 |
|
| The new version is missing a definition that was found in the old version. Was 'TrustedAccessRoleBinding' removed or renamed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2227:3 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2800:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ManagedClusterWorkloadAutoScalerProfile' removed or renamed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2227:3 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2800:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ManagedClusterWorkloadAutoScalerProfileKeda' removed or renamed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2227:3 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L2800:3 |
|
| The new version is missing a client parameter that was found in the old version. Was 'IgnorePodDisruptionBudgetParameter' removed or renamed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L5688:3 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L6697:3 |
|
| The new version is missing a client parameter that was found in the old version. Was 'TrustedAccessRoleBindingNameParameter' removed or renamed? New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L5688:3 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L6697:3 |
|
| The new version is removing enum value(s) 'Windows2019, Windows2022' from the old version. New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2647:9 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L3224:9 |
|
| The new version is removing enum value(s) 'Windows2019, Windows2022' from the old version. New: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2647:9 Old: Microsoft.ContainerService/preview/2022-05-02-preview/managedClusters.json#L3224:9 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-2022-06 | package-2022-06(84159c9) | default(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L1199 |
|
The response schema of operations API '/providers/Microsoft.ContainerService/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L37 |
|
The private endpoint model 'PrivateLinkResourcesListResult' schema does not conform to the common type definition. Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L4903 |
| Per the Noun_Verb convention for Operation Ids, the noun 'AgentPools' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L1182 |
|
| 'PUT' operation 'PrivateEndpointConnections_Update' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L1547 |
|
| The operation 'ManagedClusters_GetCommandResult' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L1859 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L1648 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L1802 |
|
| Based on the response model schema, operation 'PrivateEndpointConnections_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L1452 |
|
| Based on the response model schema, operation 'PrivateLinkResources_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L1709 |
|
| OperationId should contain the verb: 'listcredential' in:'ManagedClusters_GetAccessProfile'. Consider updating the operationId Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L244 |
|
| OperationId should contain the verb: 'resolveprivatelinkserviceid' in:'ResolvePrivateLinkServiceId_POST'. Consider updating the operationId Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L1756 |
|
| The child tracked resource, 'agentPools' with immediate parent 'ManagedCluster', must have a list by immediate parent operation. Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2901 |
|
| The child tracked resource, 'commandResults' with immediate parent 'ManagedCluster', must have a list by immediate parent operation. Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L3347 |
|
| The child tracked resource, 'privateEndpointConnections' with immediate parent 'ManagedCluster', must have a list by immediate parent operation. Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L4807 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableAutoScaling Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2660 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableNodePublicIP Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2712 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableEncryptionAtHost Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2769 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableUltraSSD Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2774 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableFIPS Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2778 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableCSIProxy Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2950 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L2968 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableMultipleStandardLoadBalancers Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L3515 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L3578 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableRBAC Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L3731 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enablePodSecurityPolicy Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L3735 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableLocalAccounts Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L3893 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enablePrivateCluster Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L3965 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enablePrivateClusterPublicFQDN Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L3975 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableRunCommand Location: Microsoft.ContainerService/stable/2022-06-01/managedClusters.json#L3979 |
️❌Avocado: 4 Errors, 0 Warnings failed [Detail]
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️SDK Track2 Validation: 1 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/84159c97605238946622563dd34fa5d10c412cc0/specification/containerservice/resource-manager/readme.md#tag-package-2022-06">containerservice/resource-manager/readme.md#package-2022-06
| Rule | Message |
|---|---|
| "readme":"containerservice/resource-manager/readme.md", "tag":"package-2022-06", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
|
Hi @FumingZhang, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
Hi @FumingZhang, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Jul 20, 2022
FumingZhang
requested review from
ArcturusZhang,
palma21 and
matthchr
as code owners
|
Dear review board, I would like to clarify the failures in the CI checks. For SDK azure-powershell, it happened in our previous PRs like stable/04-01 and preview/06-02-preview. This used to be optional and is enabled recently. Confirmed with owner @dolauli, this would not work for some modules and could be ignored. For SDK azure-sdk-for-net, it also happened in our previous PRs like stable/04-01 and preview/06-02-preview. I suppose this should be a known issue. For Swagger Avocado, it happened in our previous PR stable/04-01. I've listed the detailed explanation for each error in comment. These errors started appearing after this update of Avocado. Would really appreciate if some mechanism could be provided to disable the alarms, cc owner @ruowan. For Breaking Change(Cross-Version) and Swagger SDK Breaking Change Tracking, it's caused by rebranding of Microsoft Defender. The modification has been added to our previous preview API (2022-05-02-preview) and is about to be introduced into this stable API 2022-06-01. Feature owner has got the approval from Jeffrey, see comment. |
is there not any actual unique property or combination of proprties that are unique in the array Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/stable/2022-06-01/managedClusters.json:4148 in 84159c9. [](commit_id = 84159c9, deletion_comment = False) |
pl check everywhere In reply to: 1190801564 Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/stable/2022-06-01/managedClusters.json:4148 in 06d72d6. [](commit_id = 06d72d6, deletion_comment = False) |
rkmanda
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
jianyexi
approved these changes
Jul 21, 2022
palma21
reviewed
Jul 21, 2022
| } | ||
| }, | ||
| "securityProfile": { | ||
| "defender": { |
There was a problem hiding this comment.
@matthchr @FumingZhang was this approved? If not this should be removed
There was a problem hiding this comment.
This PR has been merged. I'll remove this wrong example and add the missing examples back in the following API version.
I've opened a work item to track this.
There was a problem hiding this comment.
I took a closer look, this example should be fine? I suppose it is following the data model after the rebranding of defender. @palma21
This was referenced Jul 21, 2022
|
I approved here but I don't see others approvals. |
6 tasks
3 tasks
akning-ms
pushed a commit
that referenced
this pull request
Aug 1, 2022
* update folder structure * small errors and CI check * [Language Text] Update swagger titles (#19835) * [Language Text] Update swagger titles * edits * address feedback * Review request for Microsoft.ContainerService to add version 2022-06-01 (#19848) * Adds base for updating Microsoft.ContainerService from version stable/2022-04-01 to version 2022-06-01 * Updates readme * Updates API version in new specs and examples * update readmes (#19421) * Add key management service profile of a managed cluster for version 2022-06-01 (#19529) * Add NetworkPlugin none option to 2022-06-01 (#19510) * Add NetworkPlugin none option to 2022-06-01 * improve description for none value * Fix violated rule R4041 for 2022-06-01 managedCluster swagger (#19581) * remove useless directive * fix R4041 * GA AKS support for Dedicated Host Group (#19547) * GA AKS support for Dedicated Host Group * fit some format minor issue * add newline in end of files * Defender updates (#19665) * Defender updates * sample * remove old description Co-authored-by: Bin Xia <[email protected]> Co-authored-by: Matt Stam <[email protected]> Co-authored-by: Jianping Zeng <[email protected]> Co-authored-by: Or Parnes <[email protected]> * Update resources.json (#19861) * Pattts/predictive autoscale 20221001 (#19765) * Rev Autoscale API from 2021-05-01-preview to 2022-10-01. * Fix minor swagger issue. Default should be 'false' * Fix swagger validation error * Defining a new package 2022-10 * AutoscaleSettingResource now reference allOf 'resource' which is the actual autoscaleSetting resource definition * Fix require property issue * Run prettier against autoscale_API.json * [Maps - Render & Spatial Services] add v2022-08-01 (#19520) * copy old swagger to new folders * set api version to 2022-08-01 * apply api changes Co-authored-by: Gigi Grajo <[email protected]> * update appconfiguration (#19330) * update appconfiguration * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md * [Hub Generated] Publish private branch 'main' (#19852) * Add StorageMover specification for PubliC Preview * SpellCheck fix * Update custom-words * Update specification/storagemover/resource-manager/readme.md Co-authored-by: Abhishek Krishna <[email protected]> Co-authored-by: Dapeng Zhang <[email protected]> * Merging Dynatrace swagger in stable folder (#19862) * Committing base swagger version * Removing preview tag from stable folder api version * Changing version name in all the files * Updating readme.go and readme.md files * [CDN] Fix customDomains property type in Endpoint (#19788) * [CDN] Fix customDomains property type in Endpoint * Fix linter error Co-authored-by: Bo Zhang <[email protected]> * Adding Microsoft.Sql AdvancedThreatProtectionSettings APIs for MI on v5 tag for 2022-02-01-preview (#19866) * update folders * [Hub Generated] Review request for Microsoft.KeyVault to add version stable/7.3 (#19844) * Update description of exportable attribute and release_policy.data * Remove submodule azure-reset-api-specs * Fix description for exportable Co-authored-by: Sunny Solanki <[email protected]> * Add latest StorageMover updates (#19876) * Add StorageMover specification for PubliC Preview * SpellCheck fix * Update custom-words * Update specification/storagemover/resource-manager/readme.md * Add latest StorageMover updates Co-authored-by: Abhishek Krishna <[email protected]> Co-authored-by: Dapeng Zhang <[email protected]> * Update readme.python.md (#19899) * Update readme.python.md * Update readme.md * Moving files from azure-rest-spec-pr to azure-rest-spec repo after api review (#19878) * Moving files from azure-rest-spec-pr to azure-rest-spec repo after api review * Add known words * Removed static IP allocation only from examples (#19858) * Removed static IP allocation * Removed static only from examples Co-authored-by: Arpit Gagneja <[email protected]> * Update securityinsights readme.python (#19903) * update securityinsights readme.python * Update readme.python.md Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]> * fix lint errors in Synapse trigger.json (#19660) * put json files into RP folders * update readme * Add CONTRIBUTING.md (#19257) * Add CONTRIBUTING.md * Apply suggestions from PR review Co-authored-by: Heath Stewart <[email protected]> * Apply suggestions from PR review Co-authored-by: Weidong Xu <[email protected]> * Regen toc for CONTRIBUTING.md * Address PR review comments * Address PR review comments Co-authored-by: Heath Stewart <[email protected]> Co-authored-by: Weidong Xu <[email protected]> * fix devcenter readme.go.md config (#19906) * fix readme.go.md config * rename to SkuInfo * add annotation for labservices (#19884) * add to description of OS state (#19764) * [Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview (#19767) * Updated the managed hsm resource manager spec to include two additional properties for private endpoint connection item * Update managed hsm private endpoint connection item in mhsm spec for latest api version * Address LRO_RESPONSE_HEADER violation for managed hsm Long running operations that are annotated with x-ms-long-running-operation:true must return location header or azure-AsyncOperation in response. Added the missing location header for managed hsm update command as well as to the corresponding examples. * [Microsoft.DeviceUpdate] Adding first stable API version (#19846) * Copied the most recent preview version into the first stable version * Updated api version in new stable version, added the tag to readme.md * Fixed typo * Fixed the wrong path in readme.md * Reverted VS Code automatic breaking change * Fix broken link (#19688) * add aadObjectId property to kustoPool (#19856) Co-authored-by: Amit Elran <[email protected]> * Updata securityinsights readme.python (#19917) * update securityinsights readme.python * update readme.python Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]> * modify readme.typescripy.md for compute package (#19607) Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]> * Dev gubalasu frontdoor microsoft.network 2021 06 01 (#19578) * Adds base for updating Microsoft.Network from version stable/2020-05-01 to version 2021-06-01 * Updates readme * Updates API version in new specs and examples * update waf configs and examples from 2020-11-01 * Update api version in new specs and examples * Migration api update * Update readme * Fix readme * update readme * Fix readme again * Fix readme * Fix readme * update waf policy provisioning state * Update securityinsights readme.python (#19923) * update securityinsights readme.python * update readme.python * last modify * Update readme.python.md Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]> * sync with changes made to master * update folder structure * small errors and CI check * update folders * put json files into RP folders * update readme * resolve capitalization and number misplacement accident Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Deyaaeldeen Almahallawi <[email protected]> Co-authored-by: FumingZhang <[email protected]> Co-authored-by: Bin Xia <[email protected]> Co-authored-by: Matt Stam <[email protected]> Co-authored-by: Jianping Zeng <[email protected]> Co-authored-by: Or Parnes <[email protected]> Co-authored-by: Alexander Batishchev <[email protected]> Co-authored-by: PatrickTseng <[email protected]> Co-authored-by: gigi <[email protected]> Co-authored-by: Gigi Grajo <[email protected]> Co-authored-by: zhenbiao wei <[email protected]> Co-authored-by: Abhishek Krishna <[email protected]> Co-authored-by: Abhishek Krishna <[email protected]> Co-authored-by: Dapeng Zhang <[email protected]> Co-authored-by: Divyansh Agarwal <[email protected]> Co-authored-by: t-bzhan <[email protected]> Co-authored-by: Bo Zhang <[email protected]> Co-authored-by: Uriel Cohen <[email protected]> Co-authored-by: susolank <[email protected]> Co-authored-by: Sunny Solanki <[email protected]> Co-authored-by: Ralf Beckers <[email protected]> Co-authored-by: arpit-gagneja <[email protected]> Co-authored-by: Arpit Gagneja <[email protected]> Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]> Co-authored-by: YanjunGao <[email protected]> Co-authored-by: Mike Kistler <[email protected]> Co-authored-by: Heath Stewart <[email protected]> Co-authored-by: Weidong Xu <[email protected]> Co-authored-by: Jiahui Peng <[email protected]> Co-authored-by: j-zhong-ms <[email protected]> Co-authored-by: Tom FitzMacken <[email protected]> Co-authored-by: neeerajaakula <[email protected]> Co-authored-by: darkoa-msft <[email protected]> Co-authored-by: Roy Wellington <[email protected]> Co-authored-by: Amit Elran <[email protected]> Co-authored-by: Amit Elran <[email protected]> Co-authored-by: kazrael2119 <[email protected]> Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]> Co-authored-by: gubalasu <[email protected]>
25 tasks
FumingZhang
deleted the
fuming/dev-containerservice-Microsoft.ContainerService-2022-06-01
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Deployed to global cloud by 07/07, sov cloud by 07/12.
07/21.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.