Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt aks, upgrade api-version to 2022-06 #30118

Merged
merged 7 commits into from
Jul 25, 2022

Conversation

XiaofeiCao
Copy link
Contributor

@XiaofeiCao XiaofeiCao commented Jul 25, 2022

Description

Fix https://github.com/Azure/sdk-release-request/issues/3023.

Manual code fb003a4 to set new property in AgentPoolInner.

Breaking change approved according to Azure/azure-rest-api-specs#19848 (comment).

Live Tests passed.

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@XiaofeiCao XiaofeiCao self-assigned this Jul 25, 2022
@XiaofeiCao XiaofeiCao added Mgmt This issue is related to a management-plane library. Mgmt - Track 2 labels Jul 25, 2022
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 25, 2022

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-resourcemanager-containerservice

@XiaofeiCao XiaofeiCao marked this pull request as ready for review July 25, 2022 07:29
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it only azureDefender? And it not affect our convenience code?

@XiaofeiCao
Copy link
Contributor Author

Yes, only azureDefender to defender due to rebranding(according to Fuming).

No convenience code is affected.

@XiaofeiCao XiaofeiCao merged commit ebf2b3b into Azure:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt - Track 2 Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants