-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev gubalasu frontdoor microsoft.network 2021 06 01 #19578
Dev gubalasu frontdoor microsoft.network 2021 06 01 #19578
Conversation
…01 to version 2021-06-01
Hi, @gubalasu Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
compared swaggers (via Oad v0.9.6)] | new version | base version |
---|---|---|
frontdoor.json | 2021-06-01(6fcbbbb) | 2020-05-01(main) |
frontdoor.json | 2021-06-01(6fcbbbb) | 2018-08-01(main) |
network.json | 2021-06-01(6fcbbbb) | 2020-11-01(main) |
network.json | 2021-06-01(6fcbbbb) | 2019-03-01(main) |
webapplicationfirewall.json | 2021-06-01(6fcbbbb) | 2020-11-01(main) |
webapplicationfirewall.json | 2021-06-01(6fcbbbb) | 2019-03-01(main) |
The following breaking changes are detected by comparison with the latest preview version:
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 1 Warnings warning [Detail]
compared tags (via openapi-validator v1.13.0) | new version | base version |
---|---|---|
package-2022-05 | package-2022-05(6fcbbbb) | package-2022-05(main) |
package-2021-06 | package-2021-06(6fcbbbb) | default(main) |
The following errors/warnings are introduced by current PR:
Rule | Message |
---|---|
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List Policies in a Resource Group Location: Microsoft.Network/stable/2021-06-01/webapplicationfirewall.json#L253 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/frontdoor/resource-manager/readme.md tag: specification/frontdoor/resource-manager/readme.md#tag-package-2022-05 |
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️
SDK Track2 Validation: 11 Warnings warning [Detail]
- The following tags are being changed in this PR
Rule | Message |
---|---|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2021-06", "details":"Using directive.0.suppress which is deprecated and will be removed in the future." |
|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2021-06", "details":"Using directive.1.suppress which is deprecated and will be removed in the future." |
|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2021-06", "details":"Using directive.2.suppress which is deprecated and will be removed in the future." |
|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2021-06", "details":"Using directive.3.suppress which is deprecated and will be removed in the future." |
|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2021-06", "details":"Using directive.4.suppress which is deprecated and will be removed in the future." |
|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2021-06", "details":"Using directive.5.suppress which is deprecated and will be removed in the future." |
|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2021-06", "details":"Using directive.6.suppress which is deprecated and will be removed in the future." |
|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2021-06", "details":"Using directive.7.suppress which is deprecated and will be removed in the future." |
|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2021-06", "details":"Using directive.8.suppress which is deprecated and will be removed in the future." |
|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2021-06", "details":"Using directive.9.suppress which is deprecated and will be removed in the future." |
|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2021-06", "details":"Using directive.10.suppress which is deprecated and will be removed in the future." |
|
💬 | "readme":"frontdoor/resource-manager/readme.md", "tag":"package-2022-05", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0 -> 1.11.0)" |
💬 | "readme":"frontdoor/resource-manager/readme.md", "tag":"package-2022-05", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0->1.11.0)" |
💬 | "readme":"frontdoor/resource-manager/readme.md", "tag":"package-2022-05", "details":"> Installing AutoRest extension '@autorest/modelerfour' (4.21.4 -> 4.21.4)" |
💬 | "readme":"frontdoor/resource-manager/readme.md", "tag":"package-2022-05", "details":"> Installed AutoRest extension '@autorest/modelerfour' (4.21.4->4.21.4)" |
💬 | "readme":"frontdoor/resource-manager/readme.md", "tag":"package-2022-05", "details":"Autorest completed in 11.16s. 0 files generated." |
💬 | "readme":"frontdoor/resource-manager/readme.md", "tag":"package-2021-06", "details":"AutoRest core version selected from configuration: ^3.2.0." |
💬 | "readme":"frontdoor/resource-manager/readme.md", "tag":"package-2021-06", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0->1.11.0)" |
💬 | "readme":"frontdoor/resource-manager/readme.md", "tag":"package-2021-06", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.21.4->4.21.4)" |
💬 | "readme":"frontdoor/resource-manager/readme.md", "tag":"package-2021-06", "details":"Autorest completed in 5.25s. 0 files generated." |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2022-05", "details":"Using directive.0.suppress which is deprecated and will be removed in the future." |
|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2022-05", "details":"Using directive.1.suppress which is deprecated and will be removed in the future." |
|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2022-05", "details":"Using directive.2.suppress which is deprecated and will be removed in the future." |
|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2022-05", "details":"Using directive.3.suppress which is deprecated and will be removed in the future." |
|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2022-05", "details":"Using directive.4.suppress which is deprecated and will be removed in the future." |
|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2022-05", "details":"Using directive.5.suppress which is deprecated and will be removed in the future." |
|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2022-05", "details":"Using directive.6.suppress which is deprecated and will be removed in the future." |
|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2022-05", "details":"Using directive.7.suppress which is deprecated and will be removed in the future." |
|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2022-05", "details":"Using directive.8.suppress which is deprecated and will be removed in the future." |
|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2022-05", "details":"Using directive.9.suppress which is deprecated and will be removed in the future." |
|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2022-05", "details":"Using directive.10.suppress which is deprecated and will be removed in the future." |
|
💬 | "readme":"frontdoor/resource-manager/readme.md", "tag":"package-2022-05", "details":"AutoRest core version selected from configuration: ^3.2.0." |
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
Hi @gubalasu, Your PR has some issues. Please fix the CI sequentially by following the order of
|
@rkmanda Most of the comments you left are from the apis copied over from older versions. Can you look at the changes after this commit: "94a0eed75ff04f4305c0bda0d046137910ed9484". For easy viewing for you, these are the only changes as part of the new API version. https://github.com/Azure/azure-rest-api-specs/pull/19578/files/c4fdf0c76beb83e0c376b48bdc8d03741ced24df..9daa5372baa14a3ba23ec47dde489efe5fed612c |
@rkmanda I have responded to your comments that are related to the changes I am introducing in this current api version. Can you take a look at them. |
@rkmanda Can you please take a look at this now |
@gubalasu I am the reviewer for the week, so will take it from here. I think there are two items to update, provisioning state enum values and a nit one. |
@jorgecotillo Updated the Provisioning state enum values one. Regarding the other nit one, I wouldnt want to update that name now, as it has been copied over from older version and it will break the older version if I make this update. Can you please look at this now |
@ArcturusZhang Can you take a look at this PR to get it merged |
* update folder structure * small errors and CI check * [Language Text] Update swagger titles (#19835) * [Language Text] Update swagger titles * edits * address feedback * Review request for Microsoft.ContainerService to add version 2022-06-01 (#19848) * Adds base for updating Microsoft.ContainerService from version stable/2022-04-01 to version 2022-06-01 * Updates readme * Updates API version in new specs and examples * update readmes (#19421) * Add key management service profile of a managed cluster for version 2022-06-01 (#19529) * Add NetworkPlugin none option to 2022-06-01 (#19510) * Add NetworkPlugin none option to 2022-06-01 * improve description for none value * Fix violated rule R4041 for 2022-06-01 managedCluster swagger (#19581) * remove useless directive * fix R4041 * GA AKS support for Dedicated Host Group (#19547) * GA AKS support for Dedicated Host Group * fit some format minor issue * add newline in end of files * Defender updates (#19665) * Defender updates * sample * remove old description Co-authored-by: Bin Xia <[email protected]> Co-authored-by: Matt Stam <[email protected]> Co-authored-by: Jianping Zeng <[email protected]> Co-authored-by: Or Parnes <[email protected]> * Update resources.json (#19861) * Pattts/predictive autoscale 20221001 (#19765) * Rev Autoscale API from 2021-05-01-preview to 2022-10-01. * Fix minor swagger issue. Default should be 'false' * Fix swagger validation error * Defining a new package 2022-10 * AutoscaleSettingResource now reference allOf 'resource' which is the actual autoscaleSetting resource definition * Fix require property issue * Run prettier against autoscale_API.json * [Maps - Render & Spatial Services] add v2022-08-01 (#19520) * copy old swagger to new folders * set api version to 2022-08-01 * apply api changes Co-authored-by: Gigi Grajo <[email protected]> * update appconfiguration (#19330) * update appconfiguration * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md * [Hub Generated] Publish private branch 'main' (#19852) * Add StorageMover specification for PubliC Preview * SpellCheck fix * Update custom-words * Update specification/storagemover/resource-manager/readme.md Co-authored-by: Abhishek Krishna <[email protected]> Co-authored-by: Dapeng Zhang <[email protected]> * Merging Dynatrace swagger in stable folder (#19862) * Committing base swagger version * Removing preview tag from stable folder api version * Changing version name in all the files * Updating readme.go and readme.md files * [CDN] Fix customDomains property type in Endpoint (#19788) * [CDN] Fix customDomains property type in Endpoint * Fix linter error Co-authored-by: Bo Zhang <[email protected]> * Adding Microsoft.Sql AdvancedThreatProtectionSettings APIs for MI on v5 tag for 2022-02-01-preview (#19866) * update folders * [Hub Generated] Review request for Microsoft.KeyVault to add version stable/7.3 (#19844) * Update description of exportable attribute and release_policy.data * Remove submodule azure-reset-api-specs * Fix description for exportable Co-authored-by: Sunny Solanki <[email protected]> * Add latest StorageMover updates (#19876) * Add StorageMover specification for PubliC Preview * SpellCheck fix * Update custom-words * Update specification/storagemover/resource-manager/readme.md * Add latest StorageMover updates Co-authored-by: Abhishek Krishna <[email protected]> Co-authored-by: Dapeng Zhang <[email protected]> * Update readme.python.md (#19899) * Update readme.python.md * Update readme.md * Moving files from azure-rest-spec-pr to azure-rest-spec repo after api review (#19878) * Moving files from azure-rest-spec-pr to azure-rest-spec repo after api review * Add known words * Removed static IP allocation only from examples (#19858) * Removed static IP allocation * Removed static only from examples Co-authored-by: Arpit Gagneja <[email protected]> * Update securityinsights readme.python (#19903) * update securityinsights readme.python * Update readme.python.md Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]> * fix lint errors in Synapse trigger.json (#19660) * put json files into RP folders * update readme * Add CONTRIBUTING.md (#19257) * Add CONTRIBUTING.md * Apply suggestions from PR review Co-authored-by: Heath Stewart <[email protected]> * Apply suggestions from PR review Co-authored-by: Weidong Xu <[email protected]> * Regen toc for CONTRIBUTING.md * Address PR review comments * Address PR review comments Co-authored-by: Heath Stewart <[email protected]> Co-authored-by: Weidong Xu <[email protected]> * fix devcenter readme.go.md config (#19906) * fix readme.go.md config * rename to SkuInfo * add annotation for labservices (#19884) * add to description of OS state (#19764) * [Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview (#19767) * Updated the managed hsm resource manager spec to include two additional properties for private endpoint connection item * Update managed hsm private endpoint connection item in mhsm spec for latest api version * Address LRO_RESPONSE_HEADER violation for managed hsm Long running operations that are annotated with x-ms-long-running-operation:true must return location header or azure-AsyncOperation in response. Added the missing location header for managed hsm update command as well as to the corresponding examples. * [Microsoft.DeviceUpdate] Adding first stable API version (#19846) * Copied the most recent preview version into the first stable version * Updated api version in new stable version, added the tag to readme.md * Fixed typo * Fixed the wrong path in readme.md * Reverted VS Code automatic breaking change * Fix broken link (#19688) * add aadObjectId property to kustoPool (#19856) Co-authored-by: Amit Elran <[email protected]> * Updata securityinsights readme.python (#19917) * update securityinsights readme.python * update readme.python Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]> * modify readme.typescripy.md for compute package (#19607) Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]> * Dev gubalasu frontdoor microsoft.network 2021 06 01 (#19578) * Adds base for updating Microsoft.Network from version stable/2020-05-01 to version 2021-06-01 * Updates readme * Updates API version in new specs and examples * update waf configs and examples from 2020-11-01 * Update api version in new specs and examples * Migration api update * Update readme * Fix readme * update readme * Fix readme again * Fix readme * Fix readme * update waf policy provisioning state * Update securityinsights readme.python (#19923) * update securityinsights readme.python * update readme.python * last modify * Update readme.python.md Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]> * sync with changes made to master * update folder structure * small errors and CI check * update folders * put json files into RP folders * update readme * resolve capitalization and number misplacement accident Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Deyaaeldeen Almahallawi <[email protected]> Co-authored-by: FumingZhang <[email protected]> Co-authored-by: Bin Xia <[email protected]> Co-authored-by: Matt Stam <[email protected]> Co-authored-by: Jianping Zeng <[email protected]> Co-authored-by: Or Parnes <[email protected]> Co-authored-by: Alexander Batishchev <[email protected]> Co-authored-by: PatrickTseng <[email protected]> Co-authored-by: gigi <[email protected]> Co-authored-by: Gigi Grajo <[email protected]> Co-authored-by: zhenbiao wei <[email protected]> Co-authored-by: Abhishek Krishna <[email protected]> Co-authored-by: Abhishek Krishna <[email protected]> Co-authored-by: Dapeng Zhang <[email protected]> Co-authored-by: Divyansh Agarwal <[email protected]> Co-authored-by: t-bzhan <[email protected]> Co-authored-by: Bo Zhang <[email protected]> Co-authored-by: Uriel Cohen <[email protected]> Co-authored-by: susolank <[email protected]> Co-authored-by: Sunny Solanki <[email protected]> Co-authored-by: Ralf Beckers <[email protected]> Co-authored-by: arpit-gagneja <[email protected]> Co-authored-by: Arpit Gagneja <[email protected]> Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]> Co-authored-by: YanjunGao <[email protected]> Co-authored-by: Mike Kistler <[email protected]> Co-authored-by: Heath Stewart <[email protected]> Co-authored-by: Weidong Xu <[email protected]> Co-authored-by: Jiahui Peng <[email protected]> Co-authored-by: j-zhong-ms <[email protected]> Co-authored-by: Tom FitzMacken <[email protected]> Co-authored-by: neeerajaakula <[email protected]> Co-authored-by: darkoa-msft <[email protected]> Co-authored-by: Roy Wellington <[email protected]> Co-authored-by: Amit Elran <[email protected]> Co-authored-by: Amit Elran <[email protected]> Co-authored-by: kazrael2119 <[email protected]> Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]> Co-authored-by: gubalasu <[email protected]>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.