Pattts/predictive autoscale 20221001 #19765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @PatrickTseng Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.6)] | new version | base version |
|---|---|---|
| autoscale_API.json | 2021-05-01(68609ec) | 2021-05-01(main) |
| autoscale_API.json | 2014-04-01(68609ec) | 2014-04-01(main) |
| autoscale_API.json | 2015-04-01(68609ec) | 2015-04-01(main) |
| Rule | Message |
|---|---|
|
The new version has a different default value than the previous one. New: Microsoft.Insights/preview/2021-05-01-preview/autoscale_API.json#L801:9 Old: Microsoft.Insights/preview/2021-05-01-preview/autoscale_API.json#L801:9 |
|
The new version has a different default value than the previous one. New: Microsoft.Insights/stable/2014-04-01/autoscale_API.json#L746:9 Old: Microsoft.Insights/stable/2014-04-01/autoscale_API.json#L746:9 |
|
The new version has a different default value than the previous one. New: Microsoft.Insights/stable/2015-04-01/autoscale_API.json#L759:9 Old: Microsoft.Insights/stable/2015-04-01/autoscale_API.json#L759:9 |
️❌Breaking Change(Cross-Version): 3 Errors, 44 Warnings failed [Detail]
| compared swaggers (via Oad v0.9.6)] | new version | base version |
|---|---|---|
| autoscale_API.json | 2022-10-01(68609ec) | 2015-04-01(main) |
| autoscale_API.json | 2022-10-01(68609ec) | 2021-05-01(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 13 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with the latest preview version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 2 Errors, 0 Warnings failed [Detail]
The following errors/warnings are introduced by current PR:
| Rule | Message |
|---|---|
|
"location":"specification/monitor/resource-manager/readme.md", "tag":"package-2022-10", "details":"swagger-document/compose - FAILED" |
|
"location":"specification/monitor/resource-manager/readme.md", "tag":"package-2022-10", "details":"Error: '$.definitions.Resource.properties.tags.description' has incompatible values (--->- Gets or sets a list of key value pairs that describe the resource. These tags can be used in viewing and grouping this resource (across resource groups). A maximum of 15 tags can be provided for a resource. Each tag must have a key no greater in length than 128 characters and a value no greater in length than 256 characters., ---Resource tags)." |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/monitor/resource-manager/readme.md tag: specification/monitor/resource-manager/readme.md#tag-package-2022-10 |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌SDK Track2 Validation: 6 Errors, 0 Warnings failed [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/68609ec5ab949d49803e2ffc8caec427f0ce054d/specification/monitor/resource-manager/readme.md#tag-package-2022-06">monitor/resource-manager/readme.md#package-2022-06
- "https://github.com/Azure/azure-rest-api-specs/blob/68609ec5ab949d49803e2ffc8caec427f0ce054d/specification/monitor/resource-manager/readme.md#tag-package-2022-04">monitor/resource-manager/readme.md#package-2022-04
- "https://github.com/Azure/azure-rest-api-specs/blob/68609ec5ab949d49803e2ffc8caec427f0ce054d/specification/monitor/resource-manager/readme.md#tag-package-2021-05-preview-diagnostics">monitor/resource-manager/readme.md#package-2021-05-preview-diagnostics
- "https://github.com/Azure/azure-rest-api-specs/blob/68609ec5ab949d49803e2ffc8caec427f0ce054d/specification/monitor/resource-manager/readme.md#tag-package-2022-02">monitor/resource-manager/readme.md#package-2022-02
- "https://github.com/Azure/azure-rest-api-specs/blob/68609ec5ab949d49803e2ffc8caec427f0ce054d/specification/monitor/resource-manager/readme.md#tag-package-2021-09">monitor/resource-manager/readme.md#package-2021-09
- "https://github.com/Azure/azure-rest-api-specs/blob/68609ec5ab949d49803e2ffc8caec427f0ce054d/specification/monitor/resource-manager/readme.md#tag-package-2021-07">monitor/resource-manager/readme.md#package-2021-07
- "https://github.com/Azure/azure-rest-api-specs/blob/68609ec5ab949d49803e2ffc8caec427f0ce054d/specification/monitor/resource-manager/readme.md#tag-package-2021-04">monitor/resource-manager/readme.md#package-2021-04
- "https://github.com/Azure/azure-rest-api-specs/blob/68609ec5ab949d49803e2ffc8caec427f0ce054d/specification/monitor/resource-manager/readme.md#tag-package-2021-05-01-preview-only">monitor/resource-manager/readme.md#package-2021-05-01-preview-only
- "https://github.com/Azure/azure-rest-api-specs/blob/68609ec5ab949d49803e2ffc8caec427f0ce054d/specification/monitor/resource-manager/readme.md#tag-package-2020-03">monitor/resource-manager/readme.md#package-2020-03
- "https://github.com/Azure/azure-rest-api-specs/blob/68609ec5ab949d49803e2ffc8caec427f0ce054d/specification/monitor/resource-manager/readme.md#tag-package-2019-11">monitor/resource-manager/readme.md#package-2019-11
- "https://github.com/Azure/azure-rest-api-specs/blob/68609ec5ab949d49803e2ffc8caec427f0ce054d/specification/monitor/resource-manager/readme.md#tag-package-2019-06">monitor/resource-manager/readme.md#package-2019-06
- "https://github.com/Azure/azure-rest-api-specs/blob/68609ec5ab949d49803e2ffc8caec427f0ce054d/specification/monitor/resource-manager/readme.md#tag-package-2019-03">monitor/resource-manager/readme.md#package-2019-03
- "https://github.com/Azure/azure-rest-api-specs/blob/68609ec5ab949d49803e2ffc8caec427f0ce054d/specification/monitor/resource-manager/readme.md#tag-package-2018-11-preview">monitor/resource-manager/readme.md#package-2018-11-preview
- "https://github.com/Azure/azure-rest-api-specs/blob/68609ec5ab949d49803e2ffc8caec427f0ce054d/specification/monitor/resource-manager/readme.md#tag-package-2018-09">monitor/resource-manager/readme.md#package-2018-09
- "https://github.com/Azure/azure-rest-api-specs/blob/68609ec5ab949d49803e2ffc8caec427f0ce054d/specification/monitor/resource-manager/readme.md#tag-package-2018-03">monitor/resource-manager/readme.md#package-2018-03
- "https://github.com/Azure/azure-rest-api-specs/blob/68609ec5ab949d49803e2ffc8caec427f0ce054d/specification/monitor/resource-manager/readme.md#tag-package-2018-02-preview">monitor/resource-manager/readme.md#package-2018-02-preview
- "https://github.com/Azure/azure-rest-api-specs/blob/68609ec5ab949d49803e2ffc8caec427f0ce054d/specification/monitor/resource-manager/readme.md#tag-package-2017-12">monitor/resource-manager/readme.md#package-2017-12
- "https://github.com/Azure/azure-rest-api-specs/blob/68609ec5ab949d49803e2ffc8caec427f0ce054d/specification/monitor/resource-manager/readme.md#tag-package-2017-09">monitor/resource-manager/readme.md#package-2017-09
- "https://github.com/Azure/azure-rest-api-specs/blob/68609ec5ab949d49803e2ffc8caec427f0ce054d/specification/monitor/resource-manager/readme.md#tag-package-2017-08">monitor/resource-manager/readme.md#package-2017-08
- "https://github.com/Azure/azure-rest-api-specs/blob/68609ec5ab949d49803e2ffc8caec427f0ce054d/specification/monitor/resource-manager/readme.md#tag-package-2015-04-01-only">monitor/resource-manager/readme.md#package-2015-04-01-only
- "https://github.com/Azure/azure-rest-api-specs/blob/68609ec5ab949d49803e2ffc8caec427f0ce054d/specification/monitor/resource-manager/readme.md#tag-package-2014-04-01-only">monitor/resource-manager/readme.md#package-2014-04-01-only
- "https://github.com/Azure/azure-rest-api-specs/blob/68609ec5ab949d49803e2ffc8caec427f0ce054d/specification/monitor/resource-manager/readme.md#tag-package-2022-10">monitor/resource-manager/readme.md#package-2022-10
| Rule | Message |
|---|---|
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-10", "details":"Duplicate Schema named 'Resource' (2 differences):\n - properties.tags.description: "Gets or sets a list of key value pairs that describe the resource. These tags can be used in viewing and grouping this resource (across resource groups). A maximum of 15 tags can be provided for a resource. Each tag must have a key no greater in length than 128 characters and a value no greater in length than 256 characters." => "Resource tags"\n - properties.systemData: "readOnly":true, "description":"The system metadata related to the response.", "$ref":"#/components/schemas/schemas:1088" =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-10", "details":"Duplicate Schema named 'Resource' (4 differences):\n - properties.tags.description: "Gets or sets a list of key value pairs that describe the resource. These tags can be used in viewing and grouping this resource (across resource groups). A maximum of 15 tags can be provided for a resource. Each tag must have a key no greater in length than 128 characters and a value no greater in length than 256 characters." => "Resource tags"\n - properties.systemData: "readOnly":true, "description":"The system metadata related to the response.", "$ref":"#/components/schemas/schemas:1088" =>\n - properties.kind: => "$ref":"#/components/schemas/schemas:650", "description":"Metadata used by portal/tooling/etc to render different UX experiences for resources of the same type; e.g. ApiApps are a kind of Microsoft.Web/sites type. If supported, the resource provider must validate and persist this value.", "readOnly":true\n - properties.etag: => "$ref":"#/components/schemas/schemas:651", "description":"The etag field is not required. If it is provided in the response body, it must also be provided as a header per the normal etag convention. Entity tags are used for comparing two or more entities from the same requested resource. HTTP/1.1 uses entity tags in the etag (section 14.19), If-Match (section 14.24), If-None-Match (section 14.26), and If-Range (section 14.27) header fields. ", "readOnly":true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-10", "details":"Duplicate Schema named 'ErrorResponse' (6 differences):\n - properties.code.$ref: "#/components/schemas/schemas:111" => "#/components/schemas/schemas:851"\n - properties.code.description: "Error code" => "The error code."\n - properties.code.readOnly: => true\n - properties.message.$ref: "#/components/schemas/schemas:112" => "#/components/schemas/schemas:852"\n - properties.message.description: "Error message indicating why the operation failed." => "The error message indicating why the operation failed."\n - properties.message.readOnly: => true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-10", "details":"Duplicate Schema named 'AzureResource' (11 differences):\n - properties.id.description: "Azure resource Id" => "The resource Id."\n - properties.name.description: "Azure resource name" => "The name of the resource."\n - properties.type.description: "Azure resource type" => "The type of the resource."\n - properties.kind: "$ref":"#/components/schemas/schemas:252", "description":"Azure resource kind", "readOnly":true =>\n - properties.identity: "$ref":"#/components/schemas/schemas:253", "description":"Azure resource identity", "readOnly":true =>\n - properties.location.x-ms-mutability.0: "create" => "read"\n - properties.location.x-ms-mutability.1: "read" => "create"\n - properties.location.$ref: "#/components/schemas/schemas:254" => "#/components/schemas/schemas:820"\n - properties.location.description: "Resource location" => "The location of the resource. Since Azure Activity Log Alerts is a global service, the location of the rules should always be 'global'."\n - properties.tags.description: "Resource tags" => "The tags of the resource."\n - required: ["location"] =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-10", "details":"Duplicate Schema named 'ActionGroup' (17 differences):\n - properties.groupShortName: "$ref":"#/components/schemas/schemas:290", "description":"The short name of the action group. This will be used in SMS messages." =>\n - properties.enabled: "type":"boolean", "default":true, "description":"Indicates whether this action group is enabled. If an action group is not enabled, then none of its receivers will receive communications." =>\n - properties.emailReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:291", "description":"The list of email receivers that are part of this action group." =>\n - properties.smsReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:292", "description":"The list of SMS receivers that are part of this action group." =>\n - properties.webhookReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:293", "description":"The list of webhook receivers that are part of this action group." =>\n - properties.itsmReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:294", "description":"The list of ITSM receivers that are part of this action group." =>\n - properties.azureAppPushReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:295", "description":"The list of AzureAppPush receivers that are part of this action group." =>\n - properties.automationRunbookReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:296", "description":"The list of AutomationRunbook receivers that are part of this action group." =>\n - properties.voiceReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:297", "description":"The list of voice receivers that are part of this action group." =>\n - properties.logicAppReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:298", "description":"The list of logic app receivers that are part of this action group." =>\n - properties.azureFunctionReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:299", "description":"The list of azure function receivers that are part of this action group." =>\n - properties.armRoleReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:300", "description":"The list of ARM role receivers that are part of this action group. Roles are Azure RBAC roles and only built-in roles are supported." =>\n - properties.eventHubReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:301", "description":"The list of event hub receivers that are part of this action group." =>\n - properties.actionGroupId: => "$ref":"#/components/schemas/schemas:843", "description":"The resource ID of the Action Group. This cannot be null or empty."\n - properties.webhookProperties: => "$ref":"#/components/schemas/schemas:844", "description":"the dictionary of custom properties to include with the post operation. These data are appended to the webhook payload."\n - required.0: "groupShortName" => "actionGroupId"\n - required.1: "enabled" =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-10", "details":"Error: 5 errors occured -- cannot continue." |
The following errors/warnings exist before current PR submission:
Only 13 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-06", "details":"Duplicate Schema named 'Resource' (2 differences):\n - properties.kind: => "$ref":"#/components/schemas/schemas:630", "description":"Metadata used by portal/tooling/etc to render different UX experiences for resources of the same type; e.g. ApiApps are a kind of Microsoft.Web/sites type. If supported, the resource provider must validate and persist this value.", "readOnly":true\n - properties.etag: => "$ref":"#/components/schemas/schemas:631", "description":"The etag field is not required. If it is provided in the response body, it must also be provided as a header per the normal etag convention. Entity tags are used for comparing two or more entities from the same requested resource. HTTP/1.1 uses entity tags in the etag (section 14.19), If-Match (section 14.24), If-None-Match (section 14.26), and If-Range (section 14.27) header fields. ", "readOnly":true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-06", "details":"Duplicate Schema named 'ErrorResponse' (6 differences):\n - properties.code.$ref: "#/components/schemas/schemas:66" => "#/components/schemas/schemas:831"\n - properties.code.description: "Error code" => "The error code."\n - properties.code.readOnly: => true\n - properties.message.$ref: "#/components/schemas/schemas:67" => "#/components/schemas/schemas:832"\n - properties.message.description: "Error message indicating why the operation failed." => "The error message indicating why the operation failed."\n - properties.message.readOnly: => true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-06", "details":"Duplicate Schema named 'AzureResource' (11 differences):\n - properties.id.description: "Azure resource Id" => "The resource Id."\n - properties.name.description: "Azure resource name" => "The name of the resource."\n - properties.type.description: "Azure resource type" => "The type of the resource."\n - properties.kind: "$ref":"#/components/schemas/schemas:232", "description":"Azure resource kind", "readOnly":true =>\n - properties.identity: "$ref":"#/components/schemas/schemas:233", "description":"Azure resource identity", "readOnly":true =>\n - properties.location.x-ms-mutability.0: "create" => "read"\n - properties.location.x-ms-mutability.1: "read" => "create"\n - properties.location.$ref: "#/components/schemas/schemas:234" => "#/components/schemas/schemas:800"\n - properties.location.description: "Resource location" => "The location of the resource. Since Azure Activity Log Alerts is a global service, the location of the rules should always be 'global'."\n - properties.tags.description: "Resource tags" => "The tags of the resource."\n - required: ["location"] =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-06", "details":"Duplicate Schema named 'ActionGroup' (17 differences):\n - properties.groupShortName: "$ref":"#/components/schemas/schemas:270", "description":"The short name of the action group. This will be used in SMS messages." =>\n - properties.enabled: "type":"boolean", "default":true, "description":"Indicates whether this action group is enabled. If an action group is not enabled, then none of its receivers will receive communications." =>\n - properties.emailReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:271", "description":"The list of email receivers that are part of this action group." =>\n - properties.smsReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:272", "description":"The list of SMS receivers that are part of this action group." =>\n - properties.webhookReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:273", "description":"The list of webhook receivers that are part of this action group." =>\n - properties.itsmReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:274", "description":"The list of ITSM receivers that are part of this action group." =>\n - properties.azureAppPushReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:275", "description":"The list of AzureAppPush receivers that are part of this action group." =>\n - properties.automationRunbookReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:276", "description":"The list of AutomationRunbook receivers that are part of this action group." =>\n - properties.voiceReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:277", "description":"The list of voice receivers that are part of this action group." =>\n - properties.logicAppReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:278", "description":"The list of logic app receivers that are part of this action group." =>\n - properties.azureFunctionReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:279", "description":"The list of azure function receivers that are part of this action group." =>\n - properties.armRoleReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:280", "description":"The list of ARM role receivers that are part of this action group. Roles are Azure RBAC roles and only built-in roles are supported." =>\n - properties.eventHubReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:281", "description":"The list of event hub receivers that are part of this action group." =>\n - properties.actionGroupId: => "$ref":"#/components/schemas/schemas:823", "description":"The resource ID of the Action Group. This cannot be null or empty."\n - properties.webhookProperties: => "$ref":"#/components/schemas/schemas:824", "description":"the dictionary of custom properties to include with the post operation. These data are appended to the webhook payload."\n - required.0: "groupShortName" => "actionGroupId"\n - required.1: "enabled" =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-06", "details":"Error: 4 errors occured -- cannot continue." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-04", "details":"Duplicate Schema named 'Resource' (2 differences):\n - properties.kind: => "$ref":"#/components/schemas/schemas:629", "description":"Metadata used by portal/tooling/etc to render different UX experiences for resources of the same type; e.g. ApiApps are a kind of Microsoft.Web/sites type. If supported, the resource provider must validate and persist this value.", "readOnly":true\n - properties.etag: => "$ref":"#/components/schemas/schemas:630", "description":"The etag field is not required. If it is provided in the response body, it must also be provided as a header per the normal etag convention. Entity tags are used for comparing two or more entities from the same requested resource. HTTP/1.1 uses entity tags in the etag (section 14.19), If-Match (section 14.24), If-None-Match (section 14.26), and If-Range (section 14.27) header fields. ", "readOnly":true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-04", "details":"Duplicate Schema named 'ErrorResponse' (6 differences):\n - properties.code.$ref: "#/components/schemas/schemas:66" => "#/components/schemas/schemas:830"\n - properties.code.description: "Error code" => "The error code."\n - properties.code.readOnly: => true\n - properties.message.$ref: "#/components/schemas/schemas:67" => "#/components/schemas/schemas:831"\n - properties.message.description: "Error message indicating why the operation failed." => "The error message indicating why the operation failed."\n - properties.message.readOnly: => true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-04", "details":"Duplicate Schema named 'AzureResource' (11 differences):\n - properties.id.description: "Azure resource Id" => "The resource Id."\n - properties.name.description: "Azure resource name" => "The name of the resource."\n - properties.type.description: "Azure resource type" => "The type of the resource."\n - properties.kind: "$ref":"#/components/schemas/schemas:232", "description":"Azure resource kind", "readOnly":true =>\n - properties.identity: "$ref":"#/components/schemas/schemas:233", "description":"Azure resource identity", "readOnly":true =>\n - properties.location.x-ms-mutability.0: "create" => "read"\n - properties.location.x-ms-mutability.1: "read" => "create"\n - properties.location.$ref: "#/components/schemas/schemas:234" => "#/components/schemas/schemas:799"\n - properties.location.description: "Resource location" => "The location of the resource. Since Azure Activity Log Alerts is a global service, the location of the rules should always be 'global'."\n - properties.tags.description: "Resource tags" => "The tags of the resource."\n - required: ["location"] =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-04", "details":"Duplicate Schema named 'ActionGroup' (17 differences):\n - properties.groupShortName: "$ref":"#/components/schemas/schemas:270", "description":"The short name of the action group. This will be used in SMS messages." =>\n - properties.enabled: "type":"boolean", "default":true, "description":"Indicates whether this action group is enabled. If an action group is not enabled, then none of its receivers will receive communications." =>\n - properties.emailReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:271", "description":"The list of email receivers that are part of this action group." =>\n - properties.smsReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:272", "description":"The list of SMS receivers that are part of this action group." =>\n - properties.webhookReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:273", "description":"The list of webhook receivers that are part of this action group." =>\n - properties.itsmReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:274", "description":"The list of ITSM receivers that are part of this action group." =>\n - properties.azureAppPushReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:275", "description":"The list of AzureAppPush receivers that are part of this action group." =>\n - properties.automationRunbookReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:276", "description":"The list of AutomationRunbook receivers that are part of this action group." =>\n - properties.voiceReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:277", "description":"The list of voice receivers that are part of this action group." =>\n - properties.logicAppReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:278", "description":"The list of logic app receivers that are part of this action group." =>\n - properties.azureFunctionReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:279", "description":"The list of azure function receivers that are part of this action group." =>\n - properties.armRoleReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:280", "description":"The list of ARM role receivers that are part of this action group. Roles are Azure RBAC roles and only built-in roles are supported." =>\n - properties.eventHubReceivers: "x-ms-identifiers":[], "$ref":"#/components/schemas/schemas:281", "description":"The list of event hub receivers that are part of this action group." =>\n - properties.actionGroupId: => "$ref":"#/components/schemas/schemas:822", "description":"The resource ID of the Action Group. This cannot be null or empty."\n - properties.webhookProperties: => "$ref":"#/components/schemas/schemas:823", "description":"the dictionary of custom properties to include with the post operation. These data are appended to the webhook payload."\n - required.0: "groupShortName" => "actionGroupId"\n - required.1: "enabled" =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-04", "details":"Error: 4 errors occured -- cannot continue." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-02", "details":"Duplicate Schema named 'Resource' (2 differences):\n - properties.kind: => "$ref":"#/components/schemas/schemas:631", "description":"Metadata used by portal/tooling/etc to render different UX experiences for resources of the same type; e.g. ApiApps are a kind of Microsoft.Web/sites type. If supported, the resource provider must validate and persist this value.", "readOnly":true\n - properties.etag: => "$ref":"#/components/schemas/schemas:632", "description":"The etag field is not required. If it is provided in the response body, it must also be provided as a header per the normal etag convention. Entity tags are used for comparing two or more entities from the same requested resource. HTTP/1.1 uses entity tags in the etag (section 14.19), If-Match (section 14.24), If-None-Match (section 14.26), and If-Range (section 14.27) header fields. ", "readOnly":true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-02", "details":"Duplicate Schema named 'ErrorResponse' (6 differences):\n - properties.code.$ref: "#/components/schemas/schemas:66" => "#/components/schemas/schemas:832"\n - properties.code.description: "Error code" => "The error code."\n - properties.code.readOnly: => true\n - properties.message.$ref: "#/components/schemas/schemas:67" => "#/components/schemas/schemas:833"\n - properties.message.description: "Error message indicating why the operation failed." => "The error message indicating why the operation failed."\n - properties.message.readOnly: => true; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"monitor/resource-manager/readme.md", "tag":"package-2022-02", "details":"Duplicate Schema named 'AzureResource' (11 differences):\n - properties.id.description: "Azure resource Id" => "The resource Id."\n - properties.name.description: "Azure resource name" => "The name of the resource."\n - properties.type.description: "Azure resource type" => "The type of the resource."\n - properties.kind: "$ref":"#/components/schemas/schemas:232", "description":"Azure resource kind", "readOnly":true =>\n - properties.identity: "$ref":"#/components/schemas/schemas:233", "description":"Azure resource identity", "readOnly":true =>\n - properties.location.x-ms-mutability.0: "create" => "read"\n - properties.location.x-ms-mutability.1: "read" => "create"\n - properties.location.$ref: "#/components/schemas/schemas:234" => "#/components/schemas/schemas:801"\n - properties.location.description: "Resource location" => "The location of the resource. Since Azure Activity Log Alerts is a global service, the location of the rules should always be 'global'."\n - properties.tags.description: "Resource tags" => "The tags of the resource."\n - required: ["location"] =>; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
|
Hi @PatrickTseng, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
Hi @PatrickTseng, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Jul 13, 2022
Closed
This was referenced Jul 13, 2022
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
…actual autoscaleSetting resource definition
mikekistler
added
the
Approved-BreakingChange
ArcturusZhang
added
the
Approved-SdkBreakingChange-Go
ArcturusZhang
approved these changes
Jul 21, 2022
This was referenced Jul 21, 2022
akning-ms
pushed a commit
that referenced
this pull request
Aug 1, 2022
* update folder structure * small errors and CI check * [Language Text] Update swagger titles (#19835) * [Language Text] Update swagger titles * edits * address feedback * Review request for Microsoft.ContainerService to add version 2022-06-01 (#19848) * Adds base for updating Microsoft.ContainerService from version stable/2022-04-01 to version 2022-06-01 * Updates readme * Updates API version in new specs and examples * update readmes (#19421) * Add key management service profile of a managed cluster for version 2022-06-01 (#19529) * Add NetworkPlugin none option to 2022-06-01 (#19510) * Add NetworkPlugin none option to 2022-06-01 * improve description for none value * Fix violated rule R4041 for 2022-06-01 managedCluster swagger (#19581) * remove useless directive * fix R4041 * GA AKS support for Dedicated Host Group (#19547) * GA AKS support for Dedicated Host Group * fit some format minor issue * add newline in end of files * Defender updates (#19665) * Defender updates * sample * remove old description Co-authored-by: Bin Xia <[email protected]> Co-authored-by: Matt Stam <[email protected]> Co-authored-by: Jianping Zeng <[email protected]> Co-authored-by: Or Parnes <[email protected]> * Update resources.json (#19861) * Pattts/predictive autoscale 20221001 (#19765) * Rev Autoscale API from 2021-05-01-preview to 2022-10-01. * Fix minor swagger issue. Default should be 'false' * Fix swagger validation error * Defining a new package 2022-10 * AutoscaleSettingResource now reference allOf 'resource' which is the actual autoscaleSetting resource definition * Fix require property issue * Run prettier against autoscale_API.json * [Maps - Render & Spatial Services] add v2022-08-01 (#19520) * copy old swagger to new folders * set api version to 2022-08-01 * apply api changes Co-authored-by: Gigi Grajo <[email protected]> * update appconfiguration (#19330) * update appconfiguration * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md * Update readme.python.md * [Hub Generated] Publish private branch 'main' (#19852) * Add StorageMover specification for PubliC Preview * SpellCheck fix * Update custom-words * Update specification/storagemover/resource-manager/readme.md Co-authored-by: Abhishek Krishna <[email protected]> Co-authored-by: Dapeng Zhang <[email protected]> * Merging Dynatrace swagger in stable folder (#19862) * Committing base swagger version * Removing preview tag from stable folder api version * Changing version name in all the files * Updating readme.go and readme.md files * [CDN] Fix customDomains property type in Endpoint (#19788) * [CDN] Fix customDomains property type in Endpoint * Fix linter error Co-authored-by: Bo Zhang <[email protected]> * Adding Microsoft.Sql AdvancedThreatProtectionSettings APIs for MI on v5 tag for 2022-02-01-preview (#19866) * update folders * [Hub Generated] Review request for Microsoft.KeyVault to add version stable/7.3 (#19844) * Update description of exportable attribute and release_policy.data * Remove submodule azure-reset-api-specs * Fix description for exportable Co-authored-by: Sunny Solanki <[email protected]> * Add latest StorageMover updates (#19876) * Add StorageMover specification for PubliC Preview * SpellCheck fix * Update custom-words * Update specification/storagemover/resource-manager/readme.md * Add latest StorageMover updates Co-authored-by: Abhishek Krishna <[email protected]> Co-authored-by: Dapeng Zhang <[email protected]> * Update readme.python.md (#19899) * Update readme.python.md * Update readme.md * Moving files from azure-rest-spec-pr to azure-rest-spec repo after api review (#19878) * Moving files from azure-rest-spec-pr to azure-rest-spec repo after api review * Add known words * Removed static IP allocation only from examples (#19858) * Removed static IP allocation * Removed static only from examples Co-authored-by: Arpit Gagneja <[email protected]> * Update securityinsights readme.python (#19903) * update securityinsights readme.python * Update readme.python.md Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]> * fix lint errors in Synapse trigger.json (#19660) * put json files into RP folders * update readme * Add CONTRIBUTING.md (#19257) * Add CONTRIBUTING.md * Apply suggestions from PR review Co-authored-by: Heath Stewart <[email protected]> * Apply suggestions from PR review Co-authored-by: Weidong Xu <[email protected]> * Regen toc for CONTRIBUTING.md * Address PR review comments * Address PR review comments Co-authored-by: Heath Stewart <[email protected]> Co-authored-by: Weidong Xu <[email protected]> * fix devcenter readme.go.md config (#19906) * fix readme.go.md config * rename to SkuInfo * add annotation for labservices (#19884) * add to description of OS state (#19764) * [Hub Generated] Review request for Microsoft.KeyVault to add version preview/2021-06-01-preview (#19767) * Updated the managed hsm resource manager spec to include two additional properties for private endpoint connection item * Update managed hsm private endpoint connection item in mhsm spec for latest api version * Address LRO_RESPONSE_HEADER violation for managed hsm Long running operations that are annotated with x-ms-long-running-operation:true must return location header or azure-AsyncOperation in response. Added the missing location header for managed hsm update command as well as to the corresponding examples. * [Microsoft.DeviceUpdate] Adding first stable API version (#19846) * Copied the most recent preview version into the first stable version * Updated api version in new stable version, added the tag to readme.md * Fixed typo * Fixed the wrong path in readme.md * Reverted VS Code automatic breaking change * Fix broken link (#19688) * add aadObjectId property to kustoPool (#19856) Co-authored-by: Amit Elran <[email protected]> * Updata securityinsights readme.python (#19917) * update securityinsights readme.python * update readme.python Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]> * modify readme.typescripy.md for compute package (#19607) Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]> * Dev gubalasu frontdoor microsoft.network 2021 06 01 (#19578) * Adds base for updating Microsoft.Network from version stable/2020-05-01 to version 2021-06-01 * Updates readme * Updates API version in new specs and examples * update waf configs and examples from 2020-11-01 * Update api version in new specs and examples * Migration api update * Update readme * Fix readme * update readme * Fix readme again * Fix readme * Fix readme * update waf policy provisioning state * Update securityinsights readme.python (#19923) * update securityinsights readme.python * update readme.python * last modify * Update readme.python.md Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]> * sync with changes made to master * update folder structure * small errors and CI check * update folders * put json files into RP folders * update readme * resolve capitalization and number misplacement accident Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Deyaaeldeen Almahallawi <[email protected]> Co-authored-by: FumingZhang <[email protected]> Co-authored-by: Bin Xia <[email protected]> Co-authored-by: Matt Stam <[email protected]> Co-authored-by: Jianping Zeng <[email protected]> Co-authored-by: Or Parnes <[email protected]> Co-authored-by: Alexander Batishchev <[email protected]> Co-authored-by: PatrickTseng <[email protected]> Co-authored-by: gigi <[email protected]> Co-authored-by: Gigi Grajo <[email protected]> Co-authored-by: zhenbiao wei <[email protected]> Co-authored-by: Abhishek Krishna <[email protected]> Co-authored-by: Abhishek Krishna <[email protected]> Co-authored-by: Dapeng Zhang <[email protected]> Co-authored-by: Divyansh Agarwal <[email protected]> Co-authored-by: t-bzhan <[email protected]> Co-authored-by: Bo Zhang <[email protected]> Co-authored-by: Uriel Cohen <[email protected]> Co-authored-by: susolank <[email protected]> Co-authored-by: Sunny Solanki <[email protected]> Co-authored-by: Ralf Beckers <[email protected]> Co-authored-by: arpit-gagneja <[email protected]> Co-authored-by: Arpit Gagneja <[email protected]> Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]> Co-authored-by: YanjunGao <[email protected]> Co-authored-by: Mike Kistler <[email protected]> Co-authored-by: Heath Stewart <[email protected]> Co-authored-by: Weidong Xu <[email protected]> Co-authored-by: Jiahui Peng <[email protected]> Co-authored-by: j-zhong-ms <[email protected]> Co-authored-by: Tom FitzMacken <[email protected]> Co-authored-by: neeerajaakula <[email protected]> Co-authored-by: darkoa-msft <[email protected]> Co-authored-by: Roy Wellington <[email protected]> Co-authored-by: Amit Elran <[email protected]> Co-authored-by: Amit Elran <[email protected]> Co-authored-by: kazrael2119 <[email protected]> Co-authored-by: ZiWei Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]> Co-authored-by: gubalasu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix? (pattts : I ran into some error when running 'autorest --validation' These errors are not related to my predictive Autoscale feature change. I am asking for exception on these errors. The following are errors are reported by th tool.)
ERROR (OperationsAPIImplementation/R3023/ARMViolation): Operations API must be implemented for '/providers/Microsoft.Insights/operations'.
- file:///C:/GitHub/azure-rest-api-specs/specification/monitor/resource-manager/Microsoft.Insights/stable/2022-10-01/autoscale_API.json:35:2 ($.paths)
ERROR (DefinitionsPropertiesNamesCamelCase/R3016/ARMViolation): Property named: 'DimensionName', for definition: 'ScaleRuleMetricDimension' must follow camelCase style. Example: 'dimensionName'.
- file:///C:/GitHub/azure-rest-api-specs/specification/monitor/resource-manager/Microsoft.Insights/stable/2022-10-01/autoscale_API.json:960:8 ($.definitions.ScaleRuleMetricDimension.properties.DimensionName)
ERROR (DefinitionsPropertiesNamesCamelCase/R3016/ARMViolation): Property named: 'Operator', for definition: 'ScaleRuleMetricDimension' must follow camelCase style. Example: 'operator'.
- file:///C:/GitHub/azure-rest-api-specs/specification/monitor/resource-manager/Microsoft.Insights/stable/2022-10-01/autoscale_API.json:964:8 ($.definitions.ScaleRuleMetricDimension.properties.Operator)
ERROR (DefinitionsPropertiesNamesCamelCase/R3016/ARMViolation): Property named: 'Values', for definition: 'ScaleRuleMetricDimension' must follow camelCase style. Example: 'values'.
- file:///C:/GitHub/azure-rest-api-specs/specification/monitor/resource-manager/Microsoft.Insights/stable/2022-10-01/autoscale_API.json:976:8 ($.definitions.ScaleRuleMetricDimension.properties.Values)
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.