Fixing RI s360 Flagged corrections in 2019-10-01 version #12777

saipv · 2021-02-02T06:43:21Z

(cherry picked from commit 919cb1df3931e1a2d5d892b44470e85b78f55696)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

(cherry picked from commit 919cb1df3931e1a2d5d892b44470e85b78f55696)

openapi-workflow-bot · 2021-02-02T06:43:23Z

Hi, @saipv Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2021-02-02T06:43:25Z

Swagger Validation Report

️❌BreakingChange: 5 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2019-10-01/consumption.json <---> new: stable/2019-10-01/consumption.json

Rule	Message
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3395:9 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3386:9
`❌` 1026 - TypeChanged	The new version has a different type 'integer' than the previous one 'string'. New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3395:9 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3386:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'true' to 'false'. New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L3006:9 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4937:9
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'error' renamed or removed? New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4634:7 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4609:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'Error' in response that was not found in the old version. New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4634:7 Old: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4609:7

️❌LintDiff: 4 Errors, 0 Warnings failed [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- consumption/resource-manager/readme.md tag:package-2019-10
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- consumption/resource-manager/readme.md tag:package-2019-10

Rule	Message
`❌` R3016 - DefinitionsPropertiesNamesCamelCase	Property named: 'Code', for definition: 'HighCasedErrorDetails' must follow camelCase style. Example: 'code'. New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4619
`❌` R3016 - DefinitionsPropertiesNamesCamelCase	Property named: 'Message', for definition: 'HighCasedErrorDetails' must follow camelCase style. Example: 'message'. New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4624
`❌` R3016 - DefinitionsPropertiesNamesCamelCase	Property named: 'Error', for definition: 'HighCasedErrorResponse' must follow camelCase style. Example: 'error'. New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L4635
`❌` R4007 - DefaultErrorResponseSchema	the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. New: Microsoft.Consumption/stable/2019-10-01/consumption.json#L1179

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-02-02T06:43:26Z

Swagger Generation Artifacts

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from b0cd622. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-consumption [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Operation has a new parameter id
info	[Changelog]   - Model Marketplace has a new parameter etag
info	[Changelog]   - Model ManagementGroupAggregatedCostResult has a new parameter etag
info	[Changelog]   - Model Notification has a new parameter threshold_type
info	[Changelog]   - Model ReservationDetail has a new parameter kind
info	[Changelog]   - Model ReservationDetail has a new parameter etag
info	[Changelog]   - Model ReservationDetail has a new parameter instance_flexibility_group
info	[Changelog]   - Model ReservationDetail has a new parameter instance_flexibility_ratio
info	[Changelog]   - Model Budget has a new parameter filter
info	[Changelog]   - Model Resource has a new parameter etag
info	[Changelog]   - Model PriceSheetResult has a new parameter etag
info	[Changelog]   - Model TagsResult has a new parameter next_link
info	[Changelog]   - Model TagsResult has a new parameter previous_link
info	[Changelog]   - Model ReservationSummary has a new parameter kind
info	[Changelog]   - Model ReservationSummary has a new parameter purchased_quantity
info	[Changelog]   - Model ReservationSummary has a new parameter etag
info	[Changelog]   - Model ReservationSummary has a new parameter total_reserved_quantity
info	[Changelog]   - Model ReservationSummary has a new parameter used_quantity
info	[Changelog]   - Model ReservationSummary has a new parameter utilized_percentage
info	[Changelog]   - Model ReservationSummary has a new parameter remaining_quantity
info	[Changelog]   - Model Balance has a new parameter etag
info	[Changelog]   - Model Forecast has a new parameter etag
info	[Changelog]   - Added operation ReservationsSummariesOperations.list
info	[Changelog]   - Added operation ReservationsDetailsOperations.list
info	[Changelog]   - Added operation ReservationRecommendationsOperations.list
info	[Changelog]   - Added operation ChargesOperations.list
info	[Changelog]   - Added operation group ReservationRecommendationDetailsOperations
info	[Changelog]   - Added operation group ReservationTransactionsOperations
info	[Changelog]   - Added operation group LotsOperations
info	[Changelog]   - Added operation group EventsOperations
info	[Changelog]   - Added operation group CreditsOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model Budget no longer has parameter filters
info	[Changelog]   - Removed operation UsageDetailsOperations.download
info	[Changelog]   - Model ChargeSummary has a new signature
info	[Changelog]   - Model UsageDetail has a new signature
info	[Changelog]   - Model ReservationRecommendation has a new signature
info	[Changelog]   - Removed operation ChargesOperations.list_by_scope

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b0cd622. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️consumption/mgmt/2019-10-01/consumption [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 11 items here, please refer to log for details.

info	[Changelog] - New field `NextLink` in struct `TagProperties`
info	[Changelog] - New field `PreviousLink` in struct `TagProperties`
info	[Changelog] - New field `Etag` in struct `ChargeSummary`
info	[Changelog] - New field `ID` in struct `Operation`
info	[Changelog] - New field `Etag` in struct `ModernUsageDetail`
info	[Changelog] - New field `Etag` in struct `EventSummary`
info	[Changelog] - New field `Etag` in struct `ManagementGroupAggregatedCostResult`
info	[Changelog] - New field `Etag` in struct `Resource`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 29 additive change(s).
info	[Changelog]

️✔️consumption/mgmt/2019-01-01/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-10-01/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-08-31/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-06-30/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-05-31/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-03-31/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-01-31/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2017-11-30/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/consumption/mgmt/2017-12-30-preview/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/consumption/mgmt/2017-04-24-preview/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from b0cd622. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/[email protected] --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
warn	No file changes detected after generation
warn	No package detected after generation

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from b0cd622. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-consumption [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Resource has a new parameter etag
info	[Changelog]   - Model Operation has a new parameter id
info	[Changelog]   - Model TagsResult has a new parameter next_link
info	[Changelog]   - Model TagsResult has a new parameter previous_link
info	[Changelog]   - Model ReservationRecommendationDetailsModel has a new parameter etag
info	[Changelog]   - Model ManagementGroupAggregatedCostResult has a new parameter etag
info	[Changelog]   - Model CreditSummary has a new parameter etag
info	[Changelog]   - Model EventSummary has a new parameter etag
info	[Changelog]   - Model ReservationDetail has a new parameter etag
info	[Changelog]   - Model ModernReservationRecommendation has a new parameter etag
info	[Changelog]   - Model LegacyChargeSummary has a new parameter etag
info	[Changelog]   - Model ReservationRecommendation has a new parameter etag
info	[Changelog]   - Model Balance has a new parameter etag
info	[Changelog]   - Model ReservationSummary has a new parameter etag
info	[Changelog]   - Model Forecast has a new parameter etag
info	[Changelog]   - Model LegacyReservationRecommendation has a new parameter resource_type
info	[Changelog]   - Model LegacyReservationRecommendation has a new parameter etag
info	[Changelog]   - Model LegacyUsageDetail has a new parameter etag
info	[Changelog]   - Model LotSummary has a new parameter etag
info	[Changelog]   - Model PriceSheetResult has a new parameter etag
info	[Changelog]   - Model ChargeSummary has a new parameter etag
info	[Changelog]   - Model ModernChargeSummary has a new parameter etag
info	[Changelog]   - Model UsageDetail has a new parameter etag
info	[Changelog]   - Model Marketplace has a new parameter etag
info	[Changelog]   - Model ModernUsageDetail has a new parameter etag

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b0cd622. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/consumption/resource-manager/readme.md

️✔️@azure/arm-consumption [View full logs] [Release SDK Changes]

azure-arm-consumption-6.3.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/consumptionManagementClient.js → ./dist/arm-consumption.js...
cmderr	[npmPack] created ./dist/arm-consumption.js in 573ms

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b0cd622. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Consumption [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Consumption.3.0.2.nupkg
- Microsoft.Azure.Management.Consumption.3.0.2.snupkg

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from b0cd622. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-10 01:38:00 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-consumption"
cmderr	[generate.py] 2021-02-10 01:38:00 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-02-10 01:38:00 INFO autorest --version=3.0.6369 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/consumption/azure-resourcemanager-consumption --java.namespace=com.azure.resourcemanager.consumption   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
cmderr	[generate.py] 2021-02-10 01:38:52 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-02-10 01:38:52 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-10 01:38:52 INFO [POM][Skip] pom already has module azure-resourcemanager-consumption
cmderr	[generate.py] 2021-02-10 01:38:52 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-10 01:38:52 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-10 01:38:52 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release

️✔️azure-resourcemanager-consumption [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-02-10 01:43:20 DEBUG Got artifact_id: azure-resourcemanager-consumption
cmderr	[Inst] 2021-02-10 01:43:20 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-10 01:43:20 DEBUG Got artifact: azure-resourcemanager-consumption-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-02-10 01:43:20 DEBUG Got artifact: azure-resourcemanager-consumption-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-02-10 01:43:20 DEBUG Got artifact: azure-resourcemanager-consumption-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-10 01:43:20 DEBUG Match jar package: azure-resourcemanager-consumption-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-10 01:43:20 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12777/azure-sdk-for-java/azure-resourcemanager-consumption/azure-resourcemanager-consumption-1.0.0-beta.1.jar\" -o azure-resourcemanager-consumption-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-consumption -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-consumption-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-02-02T06:43:36Z

In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki [Window to Fix Broken]( Window to Fix Broken - Overview (azure.com)) for more details.

openapi-workflow-bot · 2021-02-02T06:45:43Z

Hi @saipv, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

openapi-workflow-bot · 2021-02-02T06:46:32Z

Hi @saipv, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

raych1 · 2021-02-03T06:04:20Z

...cation/consumption/resource-manager/Microsoft.Consumption/stable/2019-10-01/consumption.json

@@ -1179,7 +1179,7 @@
          "default": {
            "description": "Error response describing why the operation failed.",
            "schema": {
-              "$ref": "#/definitions/ErrorResponse"
+              "$ref": "#/definitions/HighCasedErrorResponse"


How about other references to ErrorResponse? Do they need to be updated either?

@raych1 our APIs currently return both kind of Error Response - upper case one and the camelcasing ones. So keeping both these.

raych1 · 2021-02-03T06:05:58Z

@saipv , can you fix the lintDiff failures?

…into fix_resource_multiapi_submodule * 'master' of https://github.com/Azure/azure-rest-api-specs: (452 commits) Dev cost management microsoft.cost management 2020 12 01 preview new (Azure#12259) Edit securityContact swagger for 2020-01-01 (Azure#12265) [Hub Generated] Review request for Microsoft.Insights to add version stable/2020-10-01 (Azure#11579) [Hub Generated] Review request for Microsoft.Media to add version stable/2020-05-01 (Azure#12681) Fix TimeSeriesInsights swagger issues (Azure#12204) Fixing error in lastModifiedAt description (Azure#12854) Update comment.yml (Azure#12910) Fixing RI s360 Flagged corrections in 2019-10-01 version (Azure#12777) [Hub Generated] Review request for Microsoft.Web to add version stable/2020-10-01 (Azure#11636) [Ready For Review] New version 20210101 (Azure#12111) Update scheduledQueryRule_API.json (Azure#12895) Remove UserAssigned MSI (Azure#12900) Update library.json (Azure#12922) KeyVault: Feature/update security domain spec (Azure#12863) Fixes ExampleId type and incorrect ArmTokenParameter name (Azure#12896) Update contract for anomaly detector (Azure#12487) [NetAppFiles] Urgent bug fix, backup response, remove systemData(not in response yet) (Azure#12852) [AML] Add PipelineEndpoint with version and DataPathAssignments fields in AzureMLExecutePipeline (Azure#12744) remove duplicated schema (Azure#12779) [Web] Add Swagger for Service Principal (Azure#12780) ...

The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: #12777 #12555 #13039 #13097 #12822 #13280 #12942 #13248 #13378 This PR is to add those corrections to 2019-11-01 version

Adding fixes made in 2019-10-01 to 2019-11-01 (Azure#13414) The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure/azure-rest-api-specs#12777 Azure/azure-rest-api-specs#12555 Azure/azure-rest-api-specs#13039 Azure/azure-rest-api-specs#13097 Azure/azure-rest-api-specs#12822 Azure/azure-rest-api-specs#13280 Azure/azure-rest-api-specs#12942 Azure/azure-rest-api-specs#13248 Azure/azure-rest-api-specs#13378 This PR is to add those corrections to 2019-11-01 version

Adding fixes made in 2019-10-01 to 2019-11-01 (#13414) The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure/azure-rest-api-specs#12777 Azure/azure-rest-api-specs#12555 Azure/azure-rest-api-specs#13039 Azure/azure-rest-api-specs#13097 Azure/azure-rest-api-specs#12822 Azure/azure-rest-api-specs#13280 Azure/azure-rest-api-specs#12942 Azure/azure-rest-api-specs#13248 Azure/azure-rest-api-specs#13378 This PR is to add those corrections to 2019-11-01 version

Adding fixes made in 2019-10-01 to 2019-11-01 (Azure#13414) The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure/azure-rest-api-specs#12777 Azure/azure-rest-api-specs#12555 Azure/azure-rest-api-specs#13039 Azure/azure-rest-api-specs#13097 Azure/azure-rest-api-specs#12822 Azure/azure-rest-api-specs#13280 Azure/azure-rest-api-specs#12942 Azure/azure-rest-api-specs#13248 Azure/azure-rest-api-specs#13378 This PR is to add those corrections to 2019-11-01 version

Adding fixes made in 2019-10-01 to 2019-11-01 (#13414) The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure/azure-rest-api-specs#12777 Azure/azure-rest-api-specs#12555 Azure/azure-rest-api-specs#13039 Azure/azure-rest-api-specs#13097 Azure/azure-rest-api-specs#12822 Azure/azure-rest-api-specs#13280 Azure/azure-rest-api-specs#12942 Azure/azure-rest-api-specs#13248 Azure/azure-rest-api-specs#13378 This PR is to add those corrections to 2019-11-01 version

The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure#12777 Azure#12555 Azure#13039 Azure#13097 Azure#12822 Azure#13280 Azure#12942 Azure#13248 Azure#13378 This PR is to add those corrections to 2019-11-01 version

* Fixing RI s360 Flagged corrections in 2019-10-01 version (cherry picked from commit 919cb1df3931e1a2d5d892b44470e85b78f55696) * fix corresponding example

The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure#12777 Azure#12555 Azure#13039 Azure#13097 Azure#12822 Azure#13280 Azure#12942 Azure#13248 Azure#13378 This PR is to add those corrections to 2019-11-01 version

Sai Prasanna Vudataneni added 2 commits January 31, 2021 16:09

Fixing RI s360 Flagged corrections in 2019-10-01 version

1761e9a

(cherry picked from commit 919cb1df3931e1a2d5d892b44470e85b78f55696)

fix corresponding example

e5c068e

saipv requested a review from sri- February 2, 2021 06:43

saipv requested a review from kjeur as a code owner February 2, 2021 06:43

openapi-assignment-bot bot assigned raych1 Feb 2, 2021

openapi-workflow-bot bot added the FixS360 label Feb 2, 2021

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Feb 2, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Feb 2, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Python label Feb 2, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Go label Feb 2, 2021

saipv requested a review from sachin-msft February 2, 2021 18:40

sachin-msft approved these changes Feb 2, 2021

View reviewed changes

raych1 reviewed Feb 3, 2021

View reviewed changes

sri- approved these changes Feb 3, 2021

View reviewed changes

saipv requested a review from raych1 February 4, 2021 21:33

jianyexi added the Approved-LintDiff label Feb 9, 2021

raych1 added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 10, 2021

Lira-tron mentioned this pull request Mar 15, 2021

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-11-01 #13414

Merged

25 tasks

JackTn deleted the dev-consumption-Microsoft.Consumption-2019-10-01-saipv2 branch August 9, 2021 10:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing RI s360 Flagged corrections in 2019-10-01 version #12777

Fixing RI s360 Flagged corrections in 2019-10-01 version #12777

saipv commented Feb 2, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 2, 2021

openapi-pipeline-app bot commented Feb 2, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 2, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 2, 2021

openapi-workflow-bot bot commented Feb 2, 2021

openapi-workflow-bot bot commented Feb 2, 2021

raych1 Feb 3, 2021

saipv Feb 3, 2021

raych1 commented Feb 3, 2021

Fixing RI s360 Flagged corrections in 2019-10-01 version #12777

Fixing RI s360 Flagged corrections in 2019-10-01 version #12777

Conversation

saipv commented Feb 2, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 2, 2021

openapi-pipeline-app bot commented Feb 2, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 2, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Feb 2, 2021

openapi-workflow-bot bot commented Feb 2, 2021

openapi-workflow-bot bot commented Feb 2, 2021

raych1 Feb 3, 2021

Choose a reason for hiding this comment

saipv Feb 3, 2021

Choose a reason for hiding this comment

raych1 commented Feb 3, 2021

saipv commented Feb 2, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 2, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 2, 2021 •

edited

Loading