Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing RI s360 Flagged corrections in 2019-10-01 version #12777

Merged
merged 2 commits into from
Feb 10, 2021
Merged

Fixing RI s360 Flagged corrections in 2019-10-01 version #12777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1761e9a
Fixing RI s360 Flagged corrections in 2019-10-01 version
Feb 1, 2021
e5c068e
fix corresponding example
Feb 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 37 additions & 2 deletions ...ion/consumption/resource-manager/Microsoft.Consumption/stable/2019-10-01/consumption.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1179,7 +1179,7 @@
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/ErrorResponse"
"$ref": "#/definitions/HighCasedErrorResponse"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about other references to ErrorResponse? Do they need to be updated either?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raych1 our APIs currently return both kind of Error Response - upper case one and the camelcasing ones. So keeping both these.

}
}
}
Expand Down Expand Up @@ -3003,6 +3003,10 @@
"type": "string",
"description": "Resource sku"
},
"etag": {
"type": "string",
"description": "Resource etag."
},
"properties": {
"x-ms-client-flatten": true,
"$ref": "#/definitions/ReservationRecommendationDetailsProperties",
Expand Down Expand Up @@ -3295,6 +3299,11 @@
"format": "uuid",
"readOnly": true
},
"resourceType": {
"description": "The azure resource type.",
"type": "string",
"readOnly": true
},
"term": {
"description": "RI recommendations in one or three year terms.",
"type": "string",
Expand Down Expand Up @@ -3385,7 +3394,8 @@
"properties": {
"lookBackPeriod": {
"description": "The number of days of usage to look back for recommendation.",
"type": "string",
"type": "integer",
"format": "int32",
"readOnly": true
},
"instanceFlexibilityRatio": {
Expand Down Expand Up @@ -4603,6 +4613,31 @@
}
}
},
"HighCasedErrorDetails": {
"description": "The details of the error.",
"properties": {
"Code": {
"description": "Error code.",
"type": "string",
"readOnly": true
},
"Message": {
"description": "Error message indicating why the operation failed.",
"type": "string",
"readOnly": true
}
}
},
"HighCasedErrorResponse": {
"description": "Error response indicates that the service is not able to process the incoming request. The reason is provided in the error message. \n\nSome Error responses: \n\n * 429 TooManyRequests - Request is throttled. Retry after waiting for the time specified in the \"x-ms-ratelimit-microsoft.consumption-retry-after\" header. \n\n * 503 ServiceUnavailable - Service is temporarily unavailable. Retry after waiting for the time specified in the \"Retry-After\" header.",
"type": "object",
"properties": {
"Error": {
"description": "The details of the error.",
"$ref": "#/definitions/HighCasedErrorDetails"
}
}
},
"ErrorResponse": {
"description": "Error response indicates that the service is not able to process the incoming request. The reason is provided in the error message. \n\nSome Error responses: \n\n * 429 TooManyRequests - Request is throttled. Retry after waiting for the time specified in the \"x-ms-ratelimit-microsoft.consumption-retry-after\" header. \n\n * 503 ServiceUnavailable - Service is temporarily unavailable. Retry after waiting for the time specified in the \"Retry-After\" header.",
"type": "object",
Expand Down
4 changes: 2 additions & 2 deletions ...ft.Consumption/stable/2019-10-01/examples/ReservationRecommendationsByBillingProfile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
},
"firstUsageDate": "2019-07-07T00:00:00-07:00",
"scope": "Shared",
"lookBackPeriod": "Last7Days",
"lookBackPeriod": 7,
"instanceFlexibilityRatio": 1,
"instanceFlexibilityGroup": "DSv2 Series",
"normalizedSize": "Standard_DS1_v2",
Expand Down Expand Up @@ -74,7 +74,7 @@
},
"firstUsageDate": "2019-07-07T00:00:00-07:00",
"scope": "Shared",
"lookBackPeriod": "Last7Days",
"lookBackPeriod": 7,
"instanceFlexibilityRatio": 1,
"instanceFlexibilityGroup": "DSv2 Series",
"normalizedSize": "Standard_DS1",
Expand Down