[NetAppFiles] Urgent bug fix, backup response, #12852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @audunn Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version adds a response code '202'. New: Microsoft.NetApp/stable/2020-11-01/netapp.json#L2203:11 |
|
The new version is missing a property found in the old version. Was 'name' renamed or removed? New: Microsoft.NetApp/stable/2020-11-01/netapp.json#L3388:7 Old: Microsoft.NetApp/stable/2020-11-01/netapp.json#L3378:7 |
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 13 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"netapp/resource-manager/readme.md", "tag":"package-netapp-2020-11-01", "details":"The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"netapp/resource-manager/readme.md", "tag":"package-netapp-2020-11-01", "details":"The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"netapp/resource-manager/readme.md", "tag":"package-netapp-2020-11-01", "details":"The schema 'OperationProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"netapp/resource-manager/readme.md", "tag":"package-netapp-2020-11-01", "details":"The schema 'ServiceSpecification' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"netapp/resource-manager/readme.md", "tag":"package-netapp-2020-11-01", "details":"The schema 'MetricSpecification' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"netapp/resource-manager/readme.md", "tag":"package-netapp-2020-11-01", "details":"The schema 'Dimension' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"netapp/resource-manager/readme.md", "tag":"package-netapp-2020-11-01", "details":"The schema 'volumeProperties-exportPolicy' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"netapp/resource-manager/readme.md", "tag":"package-netapp-2020-11-01", "details":"The schema 'volumeProperties-dataProtection' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"netapp/resource-manager/readme.md", "tag":"package-netapp-2020-11-01", "details":"The schema 'volumePatchProperties-exportPolicy' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"netapp/resource-manager/readme.md", "tag":"package-netapp-2020-11-01", "details":"The schema 'volumePatchProperties-dataProtection' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
Hi @audunn, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Hi @audunn, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Feb 4, 2021
25 tasks
This was referenced Feb 4, 2021
|
@jianyexi Note this is urgent, and no SDK's have been released yet for this api verison. |
audunn
changed the title
audunn
changed the title
|
Please mark the appropriate checkboxes from ARM API Checklist and Breaking Change Review Checklist without marking them the review cannot proceed. |
@jorgecotillo done |
|
@jorgecotillo can we proceed with this? |
jianyexi
added
the
Approved-BreakingChange
jianyexi
approved these changes
Feb 9, 2021
jianyexi
added
the
Approved-BreakingChange
|
As the PR is to fix bug on a new api version added recently and have no customer impact , just approve the breaking change. |
This was referenced Feb 9, 2021
audunn
changed the title
iscai-msft
added a commit
to iscai-msft/azure-rest-api-specs
that referenced
this pull request
Feb 10, 2021
…into fix_resource_multiapi_submodule * 'master' of https://github.com/Azure/azure-rest-api-specs: (452 commits) Dev cost management microsoft.cost management 2020 12 01 preview new (Azure#12259) Edit securityContact swagger for 2020-01-01 (Azure#12265) [Hub Generated] Review request for Microsoft.Insights to add version stable/2020-10-01 (Azure#11579) [Hub Generated] Review request for Microsoft.Media to add version stable/2020-05-01 (Azure#12681) Fix TimeSeriesInsights swagger issues (Azure#12204) Fixing error in lastModifiedAt description (Azure#12854) Update comment.yml (Azure#12910) Fixing RI s360 Flagged corrections in 2019-10-01 version (Azure#12777) [Hub Generated] Review request for Microsoft.Web to add version stable/2020-10-01 (Azure#11636) [Ready For Review] New version 20210101 (Azure#12111) Update scheduledQueryRule_API.json (Azure#12895) Remove UserAssigned MSI (Azure#12900) Update library.json (Azure#12922) KeyVault: Feature/update security domain spec (Azure#12863) Fixes ExampleId type and incorrect ArmTokenParameter name (Azure#12896) Update contract for anomaly detector (Azure#12487) [NetAppFiles] Urgent bug fix, backup response, remove systemData(not in response yet) (Azure#12852) [AML] Add PipelineEndpoint with version and DataPathAssignments fields in AzureMLExecutePipeline (Azure#12744) remove duplicated schema (Azure#12779) [Web] Add Swagger for Service Principal (Azure#12780) ...
11 tasks
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…in response yet) (Azure#12852) * Fix backup response, remove systemData(not in response yet * Add long running op to backup patch * systemData * Remove name from volume properties, removed from service response * Reference system data from common types * Reference system data from common types Co-authored-by: Audunn Baldvinsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Note no SDK's have been released yet for this api verison.
This addresses an issue found after #12388 was merged last night.
Service team had updated the response of Backup Patch (Backups_Update) operation to respond with code 202, this was missing from the swagger. This causes an issue in the Python SDK, tested on locally generated SDK not official release since it has not been released.
We also ask if we can remove the systemData property from netAppAccount that added in PR12388 since that is not in the response yet will be added in API-Version 2021-02-01?
Changelog
Please ensure to add changelog with this PR by answering the following questions.
namefromvolumeProperties.Namejust was added in this api_version in PR [NetAppFiles] Anf 9085 update swagger rest api to 2020 11 01 #12388 to address a s360 ROUNDTRIP_MISSING_PROPERTY finding where thenameproperty was in the response but not defined in the swagger. However the property was removed from the response by the service team in a recent update so the change was no longer needed.Note no SDK's have been released yet for this api verison.
2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- [ ] SDK of .NET (need service team to ensure code readiness)
- [ ] SDK of Python
- [ ] SDK of Java
- [ ] SDK of Js
- [ ] SDK of Go
- [ ] PowerShell
- [ ] CLI
- [ ] Terraform
- [ ] No, no need to refresh for updates in this PR
Note no SDK's have been released yet for this api verison.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.